Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] populate PREVRANDAO with a random value from the FVM random generator #5281

Merged
merged 10 commits into from
Jan 26, 2024

Conversation

ramtinms
Copy link
Contributor

closes: #5207

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9857ec6) 55.57% compared to head (d92c2e9) 56.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5281      +/-   ##
==========================================
+ Coverage   55.57%   56.98%   +1.41%     
==========================================
  Files        1002      841     -161     
  Lines       96648    82472   -14176     
==========================================
- Hits        53712    46998    -6714     
+ Misses      38872    31880    -6992     
+ Partials     4064     3594     -470     
Flag Coverage Δ
unittests 56.98% <100.00%> (+1.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramtinms ramtinms marked this pull request as ready for review January 24, 2024 19:58
@ramtinms ramtinms requested a review from sideninja January 24, 2024 19:59
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@sideninja sideninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@ramtinms ramtinms enabled auto-merge January 26, 2024 19:16
@ramtinms ramtinms added this pull request to the merge queue Jan 26, 2024
Merged via the queue into master with commit ed23d21 Jan 26, 2024
50 of 51 checks passed
@ramtinms ramtinms deleted the ramtin/5207-evm-populate-prevrandao branch January 26, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flow EVM] Investigate possibility of use Flow block random seed for the EVM PREVRANDAO
4 participants