Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] Updating COA address allocation #5276

Conversation

ramtinms
Copy link
Contributor

This PR closes #5179, where we update the COA address allocation to use resource ID and a shuffle for address allocation,
The shuffle is used to make the address postfix look random.
Membership tests would be by prefix.

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9857ec6) 55.57% compared to head (d2379a9) 58.26%.

Files Patch % Lines
fvm/evm/types/address.go 0.00% 4 Missing ⚠️
fvm/evm/types/call.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5276      +/-   ##
==========================================
+ Coverage   55.57%   58.26%   +2.69%     
==========================================
  Files        1002      898     -104     
  Lines       96648    85002   -11646     
==========================================
- Hits        53712    49528    -4184     
+ Misses      38872    31833    -7039     
+ Partials     4064     3641     -423     
Flag Coverage Δ
unittests 58.26% <45.45%> (+2.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramtinms ramtinms changed the base branch from master to ramtin/5226-coa-smart-contracts January 29, 2024 20:10
@ramtinms ramtinms marked this pull request as ready for review January 30, 2024 05:04
@ramtinms ramtinms merged commit 5445289 into ramtin/5226-coa-smart-contracts Jan 30, 2024
@ramtinms ramtinms deleted the ramtin/5179-update-coa-address-allocation branch January 30, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flow EVM] new address allocation for the bridged accounts
2 participants