Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flex: Get FlexAddress construction and return working #4749

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Flex: Get FlexAddress construction and return working #4749

merged 3 commits into from
Sep 22, 2023

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Sep 22, 2023 •
edited
Loading

Depends on onflow/cadence#2811 and onflow/cadence#2806

  • Improve the Flex Cadence API:
    • Add a constructor for FlexAddress. Required adding support to the Cadence type code generator
    • Removed the incorrect view modifier from the Flex.run function
  • Move generated code to separate file. Uses the Stable Cadence type code generator

@turbolent turbolent self-assigned this Sep 22, 2023
@turbolent turbolent merged commit d47821f into ramtin/temp-flex-poc Sep 22, 2023
@turbolent turbolent deleted the bastian/flex-poc branch September 22, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramtinms ramtinms ramtinms approved these changes

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik

Assignees

@turbolent turbolent

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @ramtinms