Test storage capacity update on FLOW transfer

[robert-e-davidson3]

Test for verifying the fix for this bug: onflow/cadence#1367

[github-actions]

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit 9f2fbd1

The command (for i in {1..10}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeNFTBatchTransfer-2	112ms ± 1%	113ms ± 4%	~	(p=0.068 n=8+10)
RuntimeTransaction/reference_tx-2	26.3ms ±13%	24.9ms ± 8%	~	(p=0.095 n=10+9)
RuntimeTransaction/convert_int_to_string-2	27.2ms ± 7%	27.8ms ±10%	~	(p=0.720 n=9+10)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	28.8ms ± 6%	28.9ms ± 3%	~	(p=1.000 n=8+10)
RuntimeTransaction/get_signer_address-2	26.0ms ± 7%	25.9ms ± 6%	~	(p=0.730 n=9+9)
RuntimeTransaction/get_public_account-2	29.0ms ± 4%	28.7ms ± 5%	~	(p=0.436 n=10+10)
RuntimeTransaction/get_account_and_get_balance-2	279ms ± 1%	277ms ± 2%	~	(p=0.460 n=8+10)
RuntimeTransaction/get_account_and_get_available_balance-2	257ms ± 2%	256ms ± 1%	~	(p=0.796 n=10+10)
RuntimeTransaction/get_account_and_get_storage_used-2	31.2ms ± 7%	30.7ms ± 5%	~	(p=0.393 n=10+10)
RuntimeTransaction/get_account_and_get_storage_capacity-2	230ms ± 2%	230ms ± 1%	~	(p=0.340 n=9+9)
RuntimeTransaction/get_signer_vault-2	34.9ms ± 3%	34.1ms ± 7%	~	(p=0.079 n=9+10)
RuntimeTransaction/get_signer_receiver-2	43.2ms ± 4%	44.1ms ± 5%	~	(p=0.218 n=10+10)
RuntimeTransaction/transfer_tokens-2	206ms ± 2%	206ms ± 2%	~	(p=0.853 n=10+10)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	34.0ms ± 7%	33.8ms ± 4%	~	(p=0.529 n=10+10)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	76.9ms ± 5%	77.1ms ± 3%	~	(p=0.853 n=10+10)
RuntimeTransaction/create_new_account-2	843ms ± 1%	839ms ± 1%	~	(p=0.143 n=10+10)
RuntimeTransaction/call_empty_contract_function-2	29.1ms ± 4%	28.8ms ± 4%	~	(p=0.315 n=9+10)
RuntimeTransaction/emit_event-2	43.7ms ± 5%	44.0ms ± 4%	~	(p=0.481 n=10+10)
RuntimeTransaction/borrow_array_from_storage-2	125ms ± 4%	127ms ± 4%	~	(p=0.247 n=10+10)
RuntimeTransaction/copy_array_from_storage-2	129ms ± 3%	130ms ± 1%	~	(p=0.447 n=10+9)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	4.68s ± 3%	4.69s ± 2%	~	(p=0.684 n=10+10)
	alloc/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeNFTBatchTransfer-2	58.3MB ± 3%	58.4MB ± 3%	~	(p=0.739 n=10+10)
RuntimeTransaction/reference_tx-2	37.5MB ± 4%	37.0MB ± 9%	~	(p=0.579 n=10+10)
RuntimeTransaction/convert_int_to_string-2	37.0MB ± 5%	36.8MB ± 4%	~	(p=0.739 n=10+10)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	37.5MB ± 6%	37.3MB ± 4%	~	(p=0.549 n=9+10)
RuntimeTransaction/get_signer_address-2	37.5MB ± 6%	36.8MB ± 4%	~	(p=0.203 n=8+10)
RuntimeTransaction/get_public_account-2	39.1MB ± 5%	38.2MB ± 7%	~	(p=0.165 n=10+10)
RuntimeTransaction/get_account_and_get_balance-2	140MB ± 2%	140MB ± 3%	~	(p=0.684 n=10+10)
RuntimeTransaction/get_account_and_get_available_balance-2	124MB ± 2%	124MB ± 2%	~	(p=1.000 n=10+10)
RuntimeTransaction/get_account_and_get_storage_used-2	38.6MB ± 7%	37.9MB ± 2%	~	(p=0.604 n=10+9)
RuntimeTransaction/get_account_and_get_storage_capacity-2	117MB ± 3%	118MB ± 2%	~	(p=0.353 n=10+10)
RuntimeTransaction/get_signer_vault-2	39.5MB ± 5%	38.8MB ± 8%	~	(p=0.218 n=10+10)
RuntimeTransaction/get_signer_receiver-2	40.7MB ± 5%	41.3MB ± 4%	~	(p=0.247 n=10+10)
RuntimeTransaction/transfer_tokens-2	90.2MB ± 4%	90.8MB ± 3%	~	(p=0.684 n=10+10)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	39.2MB ±10%	38.7MB ± 6%	~	(p=0.579 n=10+10)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	58.3MB ± 6%	57.3MB ± 2%	~	(p=0.133 n=10+9)
RuntimeTransaction/create_new_account-2	208MB ± 3%	209MB ± 0%	~	(p=0.133 n=10+7)
RuntimeTransaction/call_empty_contract_function-2	38.0MB ± 4%	37.8MB ± 3%	~	(p=1.000 n=9+10)
RuntimeTransaction/emit_event-2	42.5MB ± 3%	42.9MB ± 5%	~	(p=0.393 n=10+10)
RuntimeTransaction/borrow_array_from_storage-2	68.6MB ± 3%	69.0MB ± 4%	~	(p=0.529 n=10+10)
RuntimeTransaction/copy_array_from_storage-2	83.9MB ± 4%	84.8MB ± 2%	~	(p=0.400 n=10+9)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	1.32GB ± 1%	1.32GB ± 1%	~	(p=1.000 n=10+10)
	allocs/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeNFTBatchTransfer-2	304k ± 0%	304k ± 0%	+0.25%	(p=0.006 n=10+8)
RuntimeTransaction/reference_tx-2	89.2k ± 0%	89.2k ± 0%	~	(p=0.095 n=10+8)
RuntimeTransaction/convert_int_to_string-2	103k ± 0%	103k ± 0%	~	(p=0.794 n=9+10)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	118k ± 0%	118k ± 0%	~	(p=0.565 n=10+10)
RuntimeTransaction/get_signer_address-2	94.4k ± 0%	94.4k ± 0%	~	(p=0.382 n=10+10)
RuntimeTransaction/get_public_account-2	118k ± 0%	118k ± 0%	~	(p=0.402 n=10+10)
RuntimeTransaction/get_account_and_get_balance-2	1.70M ± 0%	1.70M ± 0%	~	(p=0.362 n=10+10)
RuntimeTransaction/get_account_and_get_available_balance-2	1.57M ± 0%	1.57M ± 0%	~	(p=0.631 n=10+10)
RuntimeTransaction/get_account_and_get_storage_used-2	139k ± 0%	139k ± 0%	~	(p=0.956 n=10+10)
RuntimeTransaction/get_account_and_get_storage_capacity-2	1.42M ± 0%	1.42M ± 0%	~	(p=0.288 n=10+10)
RuntimeTransaction/get_signer_receiver-2	222k ± 0%	222k ± 0%	~	(p=0.171 n=10+10)
RuntimeTransaction/transfer_tokens-2	971k ± 0%	971k ± 0%	~	(p=0.927 n=10+10)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	139k ± 0%	139k ± 0%	~	(p=0.362 n=10+10)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	242k ± 0%	242k ± 0%	~	(p=0.324 n=10+10)
RuntimeTransaction/create_new_account-2	2.80M ± 0%	2.80M ± 0%	~	(p=0.436 n=10+10)
RuntimeTransaction/call_empty_contract_function-2	106k ± 0%	106k ± 0%	~	(p=0.234 n=9+10)
RuntimeTransaction/emit_event-2	151k ± 0%	151k ± 0%	~	(p=0.578 n=10+10)
RuntimeTransaction/borrow_array_from_storage-2	378k ± 0%	378k ± 0%	~	(p=0.562 n=10+9)
RuntimeTransaction/copy_array_from_storage-2	335k ± 0%	335k ± 0%	~	(p=0.138 n=10+10)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	21.0M ± 0%	21.0M ± 0%	~	(p=0.684 n=10+10)
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/get_signer_vault-2	141k ± 0%	141k ± 0%	−0.01%	(p=0.021 n=10+10)
	computation		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	202 ± 0%	202 ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	502 ± 0%	502 ± 0%	~	(all equal)
RuntimeTransaction/get_signer_address-2	302 ± 0%	302 ± 0%	~	(all equal)
RuntimeTransaction/get_public_account-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_balance-2	1.00k ± 0%	1.00k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_available_balance-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-2	1.30k ± 0%	1.30k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_vault-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_signer_receiver-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/transfer_tokens-2	3.50k ± 0%	3.50k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/create_new_account-2	202 ± 0%	202 ± 0%	~	(all equal)
RuntimeTransaction/call_empty_contract_function-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/emit_event-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/borrow_array_from_storage-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)
RuntimeTransaction/copy_array_from_storage-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)
	interactions		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	44.4k ± 0%	44.4k ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string-2	44.4k ± 0%	44.4k ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	44.4k ± 0%	44.4k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_address-2	44.4k ± 0%	44.4k ± 0%	~	(all equal)
RuntimeTransaction/get_public_account-2	44.4k ± 0%	44.4k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_balance-2	16.8M ± 0%	16.8M ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_available_balance-2	5.28M ± 0%	5.28M ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2	48.0k ± 0%	48.0k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-2	5.27M ± 0%	5.27M ± 0%	~	(all equal)
RuntimeTransaction/get_signer_vault-2	44.7k ± 0%	44.7k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_receiver-2	45.0k ± 0%	45.0k ± 0%	~	(all equal)
RuntimeTransaction/transfer_tokens-2	45.8k ± 0%	45.8k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	44.8k ± 0%	44.8k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	49.7k ± 0%	49.7k ± 0%	~	(all equal)
RuntimeTransaction/create_new_account-2	8.53M ± 0%	8.53M ± 0%	~	(all equal)
RuntimeTransaction/call_empty_contract_function-2	44.6k ± 0%	44.6k ± 0%	~	(all equal)
RuntimeTransaction/emit_event-2	44.6k ± 0%	44.6k ± 0%	~	(all equal)
RuntimeTransaction/borrow_array_from_storage-2	49.8k ± 0%	49.8k ± 0%	~	(all equal)
RuntimeTransaction/copy_array_from_storage-2	49.8k ± 0%	49.8k ± 0%	~	(all equal)
	us/tx		delta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	2.28k ± 3%	2.29k ± 2%	~	(p=0.755 n=10+10)

[codecov-commenter]

Codecov Report

Merging #2193 (de3ea5f) into master (9f2fbd1) will decrease coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2193      +/-   ##
==========================================
- Coverage   54.40%   54.04%   -0.36%     
==========================================
  Files         734      684      -50     
  Lines       67861    62575    -5286     
==========================================
- Hits        36920    33821    -3099     
+ Misses      27871    25864    -2007     
+ Partials     3070     2890     -180     

Flag	Coverage Δ
unittests	54.04% <ø> (-0.36%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
consensus/hotstuff/eventloop/event_loop.go	74.82% <0.00%> (-1.37%)	⬇️
engine/consensus/compliance/core.go	75.10% <0.00%> (ø)
fvm/meter/weighted_meter.go
fvm/crypto/hash.go
fvm/transactionEnv.go
fvm/programs/programs.go
fvm/environment/transaction_info.go
fvm/environment/tracer.go
fvm/contractFunctionInvoker.go
fvm/environment/account_creator.go
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[janezpodhostnik]

Looks good.

Isn't there a similar test somewhere already. This looks familiar. Maybe it was only in cadence...?

[robert-e-davidson3]

Looks good.

Isn't there a similar test somewhere already. This looks familiar. Maybe it was only in cadence...?

You may be remembering this test. I wrote it to verify the original change but it depended on cadence changes that weren't in yet.