Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

potential bug? #1984

Closed
wants to merge 1 commit into from
Closed

potential bug? #1984

wants to merge 1 commit into from

Conversation

robert-e-davidson3
Copy link
Contributor

@robert-e-davidson3 robert-e-davidson3 commented Feb 10, 2022 •
edited
Loading

I was looking into reproducing onflow/cadence#1367 when I found that the test I was modeling off of throws an error that might be overlooked.

=== RUN   TestTransactionFeeDeduction/Transaction_Fees_without_storage_0:_Transaction_fee_deduction_emits_events
    execution_verification_test.go:279: 
        	Error Trace:	execution_verification_test.go:279
        	            				execution_verification_test.go:583
        	Error:      	Should be empty, but was [Error Code: 1101] cadence runtime error Execution failed:
        	            	error: cannot find declaration `FlowEpoch` in `8624b52f9ddcd04a.FlowEpoch`
        	            	 --> b4fc3d14db4df4040e530f63d9debbecab0a587e20a039320e286d42261522e5:2:7
        	            	  |
        	            	2 | import FlowEpoch from 0x8624b52f9ddcd04a
        	            	  |        ^^^^^^^^^ available exported declarations are:
        	            	
        	            	
        	            	error: cannot infer type parameter: `T`
        	            	 --> b4fc3d14db4df4040e530f63d9debbecab0a587e20a039320e286d42261522e5:6:17
        	            	  |
        	            	6 | 	let heartbeat = serviceAccount.borrow<&FlowEpoch.Heartbeat>(from: FlowEpoch.heartbeatStoragePath)
        	            	  |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        	Test:       	TestTransactionFeeDeduction/Transaction_Fees_without_storage_0:_Transaction_fee_deduction_emits_events
    --- FAIL: TestTransactionFeeDeduction/Transaction_Fees_without_storage_0:_Transaction_fee_deduction_emits_events (0.17s)

@janezpodhostnik janezpodhostnik mentioned this pull request Feb 15, 2022
Merged
bors bot added a commit that referenced this pull request May 11, 2022
@bors @janezpodhostnik
Merge #2007
6bd6913 
2007: Update execution verification tests r=janezpodhostnik a=janezpodhostnik

No functional change.

I just consolidated the chain ID used for the transactions and the system transactions and added a disclaimer to the tests that system transactions are expected to fail due to the epoch configuration not being set up.

Relates to #1984.

Co-authored-by: Janez Podhostnik <[email protected]>
Co-authored-by: Janez Podhostnik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robert-e-davidson3