-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage migration to inject static types to cadence values #1264
Conversation
[Storage Migration] Remove broken contracts from storage
…w/flow-go into supun/storage-migration-flag
[Storage Migration] Add a flag to cleanup storage during migration
…an/cadence-storage-v5
…w/flow-go into bastian/cadence-storage-v5
Looks good to me. as soon as we fix the issue with storage_used this can be used |
Fixed storage_used issue in 72fd6fc. Manually tested with the state dumps, no issues now. I'll add some unit tests as well in the meantime. |
e77a19f
to
e01d6a9
Compare
e01d6a9
to
2d86829
Compare
Codecov Report
@@ Coverage Diff @@
## master #1264 +/- ##
==========================================
- Coverage 56.03% 54.59% -1.44%
==========================================
Files 497 498 +1
Lines 30386 31533 +1147
==========================================
+ Hits 17027 17217 +190
- Misses 11049 11968 +919
- Partials 2310 2348 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bors merge |
Description:
This migration adds static types info to cadence values with missing type info. This is required for onflow/cadence#870
Depends on: #1265
Steps to run:
<checkpoint-dir>
is the directory where the checkpoint file is located.<output-dir>
is the directory where outputs will be generated (assumes<output-dir>
exists).--cleanup-storage
flag. e.g: