PKG -- [sdk] Fix infinite recursion bug for multiple signing keys/arr…

…ay authorization function
onflow · Jun 23, 2022 · 45951f1 · 45951f1
1 parent 817339c
commit 45951f1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/.changeset/old-spies-wash.md b/.changeset/old-spies-wash.md
@@ -0,0 +1,5 @@
+---
+"@onflow/sdk": patch
+---
+
+Fix infinite recursion bug when using array authorization function (used for multiple signing keys)
diff --git a/packages/sdk/src/resolve/resolve-accounts.js b/packages/sdk/src/resolve/resolve-accounts.js
@@ -27,8 +27,10 @@ async function collectAccounts(ix, accounts, last, depth = 3) {
 
   let authorizations = []
   for (let ax of accounts) {
+    let resolve = ax.resolve
+    ax.resolve = null
     var old = last || ax
-    if (isFn(ax.resolve)) ax = await ax.resolve(ax, buildPreSignable(ax, ix))
+    if (isFn(resolve)) ax = await resolve(ax, buildPreSignable(ax, ix))
 
     if (Array.isArray(ax)) {
       await collectAccounts(ix, ax, old, depth - 1)

diff --git a/packages/sdk/src/resolve/resolve-accounts.test.js b/packages/sdk/src/resolve/resolve-accounts.test.js
@@ -76,7 +76,6 @@ test("Voucher in PreSignable multiple payer keys", async () => {
           addr: "0x02",
           keyId: 0,
         }),
-        resolve: null,
       },
       {
         ...account,
@@ -89,7 +88,6 @@ test("Voucher in PreSignable multiple payer keys", async () => {
           addr: "0x02",
           keyId: 1,
         }),
-        resolve: null,
       },
     ],
   }
@@ -151,7 +149,6 @@ test("Voucher in PreSignable multiple payer keys different accounts", async () =
           addr: "0x02",
           keyId: 0,
         }),
-        resolve: null,
       },
       {
         ...account,
@@ -164,7 +161,6 @@ test("Voucher in PreSignable multiple payer keys different accounts", async () =
           addr: "0x02",
           keyId: 1,
         }),
-        resolve: null,
       },
     ],
   }