Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade FCLCrypto contract to Cadence 1.0 #19

Open
wants to merge 5 commits into
base: cadence-1.0
Choose a base branch
from
Open

Upgrade FCLCrypto contract to Cadence 1.0 #19

wants to merge 5 commits into from

Conversation

jribbink
Copy link

@jribbink jribbink commented Jan 5, 2024

No description provided.

@jribbink jribbink marked this pull request as ready for review April 8, 2024 15:36
@jribbink jribbink requested a review from JeffreyDoyle as a code owner April 8, 2024 15:36
sisyphusSmiling
sisyphusSmiling approved these changes May 17, 2024
View reviewed changes
Copy link

@sisyphusSmiling sisyphusSmiling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Suggested adding view modifiers so the verification methods could be used in pre/post conditions if needed, but not a blocker at all.

cadence/contracts/FCLCrypto.cdc Outdated Show resolved Hide resolved
cadence/contracts/FCLCrypto.cdc Outdated Show resolved Hide resolved
cadence/contracts/FCLCrypto.cdc Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sisyphusSmiling sisyphusSmiling sisyphusSmiling approved these changes

@JeffreyDoyle JeffreyDoyle Awaiting requested review from JeffreyDoyle JeffreyDoyle is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jribbink @sisyphusSmiling