Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler] Add compiler tests for default functions and function conditions #3788

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Feb 21, 2025

Work towards #3773

Description

$subject


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS added the Testing label Feb 21, 2025
@SupunS SupunS self-assigned this Feb 21, 2025
@SupunS SupunS requested a review from turbolent as a code owner February 21, 2025 20:38
@SupunS SupunS requested a review from jsproz February 21, 2025 20:38
Copy link

github-actions bot commented Feb 21, 2025

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit 2719e99
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature/compiler@049c7ef). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             feature/compiler    #3788   +/-   ##
===================================================
  Coverage                    ?   81.67%           
===================================================
  Files                       ?      449           
  Lines                       ?   100329           
  Branches                    ?        0           
===================================================
  Hits                        ?    81941           
  Misses                      ?    15628           
  Partials                    ?     2760           
Flag Coverage Δ
unittests 81.67% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SupunS SupunS changed the title Add compiler tests for default functions and function conditions [Compiler] Add compiler tests for default functions and function conditions Feb 21, 2025
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The comments help a lot 🙏

@SupunS SupunS merged commit 1382553 into feature/compiler Feb 24, 2025
7 of 9 checks passed
@SupunS SupunS deleted the supun/compiler-test branch February 24, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants