Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler] Test compilation of currently supported features #3786

Merged
merged 6 commits into from
Feb 21, 2025

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Feb 20, 2025

Closes #3773

Description

  • Test existing features, see issue
  • Improve compilation of nil-coalescing
  • Fix compilation of nested loops

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit 0266434
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent marked this pull request as ready for review February 20, 2025 22:08
@turbolent turbolent requested a review from SupunS as a code owner February 20, 2025 22:08
@turbolent turbolent mentioned this pull request Feb 21, 2025
6 tasks
@turbolent turbolent merged commit 2719e99 into feature/compiler Feb 21, 2025
7 of 9 checks passed
@turbolent turbolent deleted the bastian/3773-test-compilation branch February 22, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants