Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler] Compile and execute emit statement #3768

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

turbolent
Copy link
Member

Work towards #3742

Description

Compile emit statements to a new EmitEvent instruction, and execute the instruction by invoking a config callback.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from jsproz February 13, 2025 22:36
@turbolent turbolent self-assigned this Feb 13, 2025
@turbolent turbolent requested a review from SupunS as a code owner February 13, 2025 22:36
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit d861cc4
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@turbolent turbolent enabled auto-merge February 13, 2025 22:55
@turbolent turbolent merged commit 56c8fbd into feature/compiler Feb 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants