Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler] Improve compiler tests #3755

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Feb 4, 2025

Work towards #3742

Description

Generate instructions instead of bytecode, which makes asserting / debugging easier, and makes the tests independent of the instruction encoding.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from jsproz February 4, 2025 01:29
@turbolent turbolent self-assigned this Feb 4, 2025
@turbolent turbolent requested a review from SupunS as a code owner February 4, 2025 01:29
Copy link

github-actions bot commented Feb 4, 2025

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/compiler commit 03ea43b
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Yeah, this makes it a lot easier to debug/update

@turbolent turbolent merged commit 21dfd63 into feature/compiler Feb 5, 2025
9 checks passed
@turbolent turbolent deleted the bastian/improve-compiler-tests branch February 5, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants