Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple interpreter values from interpreter – Part 2 #3748

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Jan 30, 2025

Work towards #3693

Description

Continue decoupling the values from the interpreter / cleaning up unnecessary code in the interpreter values.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels
    …decouple-values-from-interpreter-2

Base automatically changed from bastian/decouple-values-from-interpreter to master February 12, 2025 23:35
@turbolent turbolent requested a review from SupunS February 12, 2025 23:38
@turbolent turbolent closed this Feb 13, 2025
@turbolent turbolent reopened this Feb 13, 2025
@turbolent turbolent enabled auto-merge February 13, 2025 01:24
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 95b96a0
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent merged commit b72a603 into master Feb 13, 2025
10 of 12 checks passed
@turbolent turbolent deleted the bastian/decouple-values-from-interpreter-2 branch February 13, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants