Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync feature/atree-register-inlining-v1.0 with master #3351

Merged
merged 77 commits into from
May 15, 2024
Merged

Sync feature/atree-register-inlining-v1.0 with master #3351

merged 77 commits into from
May 15, 2024

Conversation

fxamacker
Copy link
Member

Merge master into feature/atree-register-inlining-v1.0

Conflict Resolution 
commit 986cb088969cda297f70c7713f662ef6820984bb
Merge: ab00c4942 bb4542c46
Author: Faye Amacker <[email protected]>
Date:   Wed May 15 13:05:31 2024 -0500

    Merge branch 'master' into fxamacker/sync-atree-register-inlining-v1.0

diff --git a/go.mod b/go.mod
remerge CONFLICT (content): Merge conflict in go.mod
index a59dbfdc0..0898c48e9 100644
--- a/go.mod
+++ b/go.mod
@@ -13,11 +13,7 @@ require (
 	github.com/kr/pretty v0.3.1
 	github.com/leanovate/gopter v0.2.9
 	github.com/logrusorgru/aurora/v4 v4.0.0
-<<<<<<< ab00c4942 (Merge pull request #3346 from onflow/fxamacker/bump-atree-inlining-version-for-cadence-v1.0)
 	github.com/onflow/atree v0.8.0-rc.2
-=======
-	github.com/onflow/atree v0.7.0-rc.2
->>>>>>> bb4542c46 (Merge pull request #3349 from onflow/release/v1.0.0-preview.27)
 	github.com/rivo/uniseg v0.4.4
 	github.com/schollz/progressbar/v3 v3.13.1
 	github.com/stretchr/testify v1.8.4
diff --git a/go.sum b/go.sum
remerge CONFLICT (content): Merge conflict in go.sum
index db9244683..6e2283683 100644
--- a/go.sum
+++ b/go.sum
@@ -72,13 +72,8 @@ github.com/mattn/go-tty v0.0.3/go.mod h1:ihxohKRERHTVzN+aSVRwACLCeqIoZAWpoICkkvr
 github.com/mitchellh/colorstring v0.0.0-20190213212951-d06e56a500db h1:62I3jR2EmQ4l5rM/4FEfDWcRD+abF5XlKShorW5LRoQ=
 github.com/mitchellh/colorstring v0.0.0-20190213212951-d06e56a500db/go.mod h1:l0dey0ia/Uv7NcFFVbCLtqEBQbrT4OCwCSKTEv6enCw=
 github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e h1:fD57ERR4JtEqsWbfPhv4DMiApHyliiK5xCTNVSPiaAs=
-<<<<<<< ab00c4942 (Merge pull request #3346 from onflow/fxamacker/bump-atree-inlining-version-for-cadence-v1.0)
 github.com/onflow/atree v0.8.0-rc.2 h1:7XYaOiiYJqLadzmyLyju2ztoqyTw/ikzcI0HI2LA+bI=
 github.com/onflow/atree v0.8.0-rc.2/go.mod h1:7YNAyCd5JENq+NzH+fR1ABUZVzbSq9dkt0+5fZH3L2A=
-=======
-github.com/onflow/atree v0.7.0-rc.2 h1:mZmVrl/zPlfI44EjV3FdR2QwIqT8nz1sCONUBFcML/U=
-github.com/onflow/atree v0.7.0-rc.2/go.mod h1:xvP61FoOs95K7IYdIYRnNcYQGf4nbF/uuJ0tHf4DRuM=
->>>>>>> bb4542c46 (Merge pull request #3349 from onflow/release/v1.0.0-preview.27)
 github.com/onflow/crypto v0.25.0 h1:BeWbLsh3ZD13Ej+Uky6kg1PL1ZIVBDVX+2MVBNwqddg=
 github.com/onflow/crypto v0.25.0/go.mod h1:C8FbaX0x8y+FxWjbkHy0Q4EASCDR9bSPWZqlpCLYyVI=
 github.com/pkg/diff v0.0.0-20210226163009-20ebb0f2a09e/go.mod h1:pJLUxLENpZxwdsKMEsNbx1VGcRFpLqf3715MtcvvzbA=
diff --git a/runtime/stdlib/account.go b/runtime/stdlib/account.go
remerge CONFLICT (content): Merge conflict in runtime/stdlib/account.go
index 6b74434a6..546f00554 100644
--- a/runtime/stdlib/account.go
+++ b/runtime/stdlib/account.go
@@ -977,7 +977,6 @@ func newAccountInboxPublishFunction(
 					locationRange,
 				)
 
-<<<<<<< ab00c4942 (Merge pull request #3346 from onflow/fxamacker/bump-atree-inlining-version-for-cadence-v1.0)
 				publishedValue := interpreter.NewPublishedValue(inter, recipientValue, value).Transfer(
 					inter,
 					locationRange,
@@ -987,16 +986,6 @@ func newAccountInboxPublishFunction(
 					nil,
 					true, // New PublishedValue is standalone.
 				)
-=======
-				publishedValue := interpreter.NewPublishedValue(inter, recipientValue, value).Transfer(
-					inter,
-					locationRange,
-					atree.Address(provider),
-					true,
-					nil,
-					nil,
-				)
->>>>>>> bb4542c46 (Merge pull request #3349 from onflow/release/v1.0.0-preview.27)
 
 				storageMapKey := interpreter.StringStorageMapKey(nameValue.Str)
 
@@ -1059,7 +1048,6 @@ func newAccountInboxUnpublishFunction(
 					})
 				}
 
-<<<<<<< ab00c4942 (Merge pull request #3346 from onflow/fxamacker/bump-atree-inlining-version-for-cadence-v1.0)
 				value := publishedValue.Value.Transfer(
 					inter,
 					locationRange,
@@ -1069,16 +1057,6 @@ func newAccountInboxUnpublishFunction(
 					nil,
 					false, // publishedValue is an element in storage map because it is returned by ReadStored.
 				)
-=======
-				value := publishedValue.Value.Transfer(
-					inter,
-					locationRange,
-					atree.Address{},
-					true,
-					nil,
-					nil,
-				)
->>>>>>> bb4542c46 (Merge pull request #3349 from onflow/release/v1.0.0-preview.27)
 
 				inter.WriteStored(
 					provider,
@@ -1160,7 +1138,6 @@ func newAccountInboxClaimFunction(
 					})
 				}
 
-<<<<<<< ab00c4942 (Merge pull request #3346 from onflow/fxamacker/bump-atree-inlining-version-for-cadence-v1.0)
 				value := publishedValue.Value.Transfer(
 					inter,
 					locationRange,
@@ -1170,16 +1147,6 @@ func newAccountInboxClaimFunction(
 					nil,
 					false, // publishedValue is an element in storage map because it is returned by ReadStored.
 				)
-=======
-				value := publishedValue.Value.Transfer(
-					inter,
-					locationRange,
-					atree.Address{},
-					true,
-					nil,
-					nil,
-				)
->>>>>>> bb4542c46 (Merge pull request #3349 from onflow/release/v1.0.0-preview.27)
 
 				inter.WriteStored(
 					providerAddress,
@@ -3442,7 +3409,6 @@ func newAccountCapabilitiesPublishFunction(
 					})
 				}
 
-<<<<<<< ab00c4942 (Merge pull request #3346 from onflow/fxamacker/bump-atree-inlining-version-for-cadence-v1.0)
 				capabilityValue, ok = capabilityValue.Transfer(
 					inter,
 					locationRange,
@@ -3455,19 +3421,6 @@ func newAccountCapabilitiesPublishFunction(
 				if !ok {
 					panic(errors.NewUnreachableError())
 				}
-=======
-				capabilityValue, ok = capabilityValue.Transfer(
-					inter,
-					locationRange,
-					atree.Address(accountAddress),
-					true,
-					nil,
-					nil,
-				).(*interpreter.IDCapabilityValue)
-				if !ok {
-					panic(errors.NewUnreachableError())
-				}
->>>>>>> bb4542c46 (Merge pull request #3349 from onflow/release/v1.0.0-preview.27)
 
 				// Write new value
 
@@ -3527,7 +3480,6 @@ func newAccountCapabilitiesUnpublishFunction(
 					panic(errors.NewUnreachableError())
 				}
 
-<<<<<<< ab00c4942 (Merge pull request #3346 from onflow/fxamacker/bump-atree-inlining-version-for-cadence-v1.0)
 				capabilityValue, ok = capabilityValue.Transfer(
 					inter,
 					locationRange,
@@ -3540,19 +3492,6 @@ func newAccountCapabilitiesUnpublishFunction(
 				if !ok {
 					panic(errors.NewUnreachableError())
 				}
-=======
-				capabilityValue, ok = capabilityValue.Transfer(
-					inter,
-					locationRange,
-					atree.Address{},
-					true,
-					nil,
-					nil,
-				).(*interpreter.IDCapabilityValue)
-				if !ok {
-					panic(errors.NewUnreachableError())
-				}
->>>>>>> bb4542c46 (Merge pull request #3349 from onflow/release/v1.0.0-preview.27)
 
 				inter.WriteStored(
 					address,
diff --git a/version.go b/version.go
remerge CONFLICT (content): Merge conflict in version.go
index 1f86b0898..71c45741a 100644
--- a/version.go
+++ b/version.go
@@ -21,8 +21,4 @@
 
 package cadence
 
-<<<<<<< ab00c4942 (Merge pull request #3346 from onflow/fxamacker/bump-atree-inlining-version-for-cadence-v1.0)
 const Version = "v1.0.0-preview-atree-register-inlining.26"
-=======
-const Version = "v1.0.0-preview.27"
->>>>>>> bb4542c46 (Merge pull request #3349 from onflow/release/v1.0.0-preview.27)
______
  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

turbolent and others added 30 commits May 7, 2024 10:31
@turbolent
Cadence 1.0 got merged into master, Emulator has been on Cadence 1.0 …
2bbe2f6 
…for a while
@turbolent
v1.0.0-preview.26
8bd7911
@turbolent
Merge pull request #3321 from onflow/release/v1.0.0-preview.26
ee20f86
@SupunS
Make migration error stack trace configurable
e8315d5
@turbolent
add reproducer
4bfebda
@turbolent
remove panic
a9d1105
@dsainati1
report error if capability is issued with id 0
beb77f2
@SupunS
Merge pull request #3322 from onflow/supun/disable-error-stacktraces
34ef697 
Make migration error stacktrace configurable
@turbolent
Merge pull request #3325 from onflow/bastian/3323-fix-invalid-capabil…
e52d5a5 
…ity-id-panic
@turbolent
fix borrowing of contract interface
dc924bd
@turbolent
Merge pull request #3327 from onflow/bastian/3241-fix-contract-interf…
b69571a 
…ace-borrowing
@turbolent
cache the results of the static type migration
a90f1ac
@turbolent
clean up
6bfcfb4
@turbolent
refactor static type tests to run test cases independently
a0c136d
@turbolent
always cache result of entitlements migration, even when result is th…
f3f92ab 
…at no migration is necessary
@turbolent
improve explanation why only parent is cached
0e6ae52
@turbolent
cache migration errors
81c7de9
@turbolent
only cache at root type
21f06f7
@turbolent
Merge pull request #3329 from onflow/bastian/3326-cache-static-type-m…
64d069c 
…igration-results

Add/improve caching in static type and entitlements migration
@j1010001
adding staged contracts migration report from TN state taken on May 8
716e0c5
@turbolent
Merge pull request #3330 from onflow/jan/add-migrations-data
a4a2434
@SupunS
Fix resource loss check in dictionary set-key
41f0300
@dsainati1 @SupunS
port fixes to v0.42
bb10009
@dsainati1 @SupunS
apply suggested fixes
63abc0f
@SupunS
Fix merge
e0d5536
@turbolent
Merge pull request #3319 from onflow/bastian/update-flow-go-related-c…
f73163c 
…onfiguration

Update flow-go related configuration
@SupunS
Merge pull request #3331 from onflow/supun/port-fixes
850c2db 
Port bug fixes
@turbolent
handle missing interfaces in Cadence 1.0 contract update validator
b1700d5
@turbolent
Merge pull request #3337 from onflow/bastian/3336-fix-missing-interfa…
f02a00f 
…ce-crasher
@turbolent
allow construction of paths with syntactically invalid identifiers
4297256
fxamacker and others added 21 commits May 14, 2024 17:14
@fxamacker
Merge pull request #3348 from onflow/fxamacker/add-nondeterministic-c…
25c2174 
…ommit-for-migration

Add Storage.NondeterministicCommit for faster migrations
@SupunS
Refactor
a0e71bd
@SupunS
Merge pull request #3339 from onflow/supun/port-229
282c93c 
Check dictionary keys when checking the ability for dereferencing
@SupunS
Merge pull request #3340 from onflow/supun/port-220
49c7f8f 
Use parent to determine whether an expression is target of an invocation
@SupunS
Merge branch 'master' of https://github.com/onflow/cadence into supun…
dc63152 
…/port-221
@SupunS
Refactor
321a305
@SupunS
Remove invalid runtime test
b2a8d8e
@SupunS
Merge pull request #3345 from onflow/supun/port-225
fb35240 
Add back transaction `execute` tests
@SupunS
Make linter happy
07a2143
@SupunS
Merge pull request #3341 from onflow/supun/port-221
8b6e4b6 
Improve static validation of contract/transaction moves
@SupunS
Improve comment
b2462eb
@SupunS
Merge branch 'master' of https://github.com/onflow/cadence into supun…
ba7c74c 
…/port-222
@SupunS
Merge branch 'supun/port-222' of https://github.com/onflow/cadence in…
6e3c6ee 
…to supun/port-222
@SupunS
Fix merge
b7cafe9
@SupunS
Merge pull request #3342 from onflow/supun/port-222
b36c399 
Wrap host-function typed member-values with a bound-function
@SupunS
Merge branch 'master' of https://github.com/onflow/cadence into supun…
7584510 
…/port-223
@SupunS
Fix lint issues
f420d12
@SupunS
Merge pull request #3343 from onflow/supun/port-223
e7fbb09 
Add invalidation for storage references
@turbolent
v1.0.0-preview.27
a7942a2
@turbolent
Merge pull request #3349 from onflow/release/v1.0.0-preview.27
bb4542c
@fxamacker
Merge branch 'master' into fxamacker/sync-atree-register-inlining-v1.0
986cb08
@fxamacker fxamacker self-assigned this May 15, 2024
@github-actions GitHub Actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/atree-register-inlining-v1.0 commit ab00c49
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
DecodeBatchEventsCCF-4130ms ± 0%131ms ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsJSON-4382ms ± 0%390ms ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-42.84µs ± 0%2.90µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.TokensWithdrawn-42.16µs ± 0%2.18µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-42.89µs ± 0%2.86µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-43.19µs ± 0%3.17µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-42.17µs ± 0%2.19µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.RewardsPaid-42.58µs ± 0%2.58µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited-42.71µs ± 0%2.61µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-42.55µs ± 0%2.53µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensMinted-42.15µs ± 0%2.18µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensWithdrawn-42.65µs ± 0%2.67µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowFees.FeesDeducted-49.49µs ± 0%9.60µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowFees.TokensWithdrawn-45.64µs ± 0%5.60µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-48.59µs ± 0%8.67µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-411.7µs ± 0%12.0µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-45.65µs ± 0%5.69µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.RewardsPaid-47.26µs ± 0%7.28µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited-47.65µs ± 0%7.67µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-46.96µs ± 0%6.98µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensMinted-45.56µs ± 0%5.65µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensWithdrawn-47.57µs ± 0%7.65µs ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsCCF-492.1ms ± 0%92.1ms ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-4108ms ± 0%108ms ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-42.18µs ± 0%6.27µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.TokensWithdrawn-41.61µs ± 0%4.91µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-41.99µs ± 0%1.98µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-42.32µs ± 0%2.28µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-41.65µs ± 0%1.73µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.RewardsPaid-41.80µs ± 0%1.78µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited-41.86µs ± 0%1.83µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-41.83µs ± 0%1.83µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensMinted-41.64µs ± 0%1.63µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensWithdrawn-41.88µs ± 0%1.86µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowFees.FeesDeducted-42.58µs ± 0%2.57µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowFees.TokensWithdrawn-41.46µs ± 0%1.45µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-42.27µs ± 0%2.26µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-43.20µs ± 0%3.21µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-41.51µs ± 0%1.48µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.RewardsPaid-41.95µs ± 0%1.94µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited-42.22µs ± 0%2.21µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-41.75µs ± 0%1.74µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensMinted-41.50µs ± 0%1.47µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensWithdrawn-42.19µs ± 0%2.18µs ± 0%~(p=1.000 n=1+1)
ExportType/composite_type-4289ns ± 0%290ns ± 0%~(p=1.000 n=1+1)
ExportType/simple_type-470.8ns ± 0%70.6ns ± 0%~(p=1.000 n=1+1)
InterpretRecursionFib-42.24ms ± 0%2.22ms ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4923ns ± 0%922ns ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4497ns ± 0%470ns ± 0%~(p=1.000 n=1+1)
ParseArray-45.85ms ± 0%6.04ms ± 0%~(p=0.333 n=2+2)
ParseDeploy/byte_array-48.80ms ± 1%9.08ms ± 1%~(p=0.333 n=2+2)
ParseDeploy/decode_hex-4972µs ± 2%997µs ± 0%~(p=0.333 n=2+2)
ParseFungibleToken/With_memory_metering-4148µs ± 5%150µs ± 4%~(p=0.667 n=2+2)
ParseFungibleToken/Without_memory_metering-4119µs ± 1%119µs ± 5%~(p=1.000 n=2+2)
ParseInfix-45.21µs ± 2%5.38µs ± 2%~(p=0.667 n=2+2)
QualifiedIdentifierCreation/One_level-42.48ns ± 0%2.48ns ± 0%~(p=1.000 n=1+1)
QualifiedIdentifierCreation/Three_levels-484.0ns ± 0%84.8ns ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-43.68µs ± 0%3.79µs ± 0%~(p=1.000 n=1+1)
SuperTypeInference/arrays-4241ns ± 0%246ns ± 0%~(p=1.000 n=1+1)
SuperTypeInference/composites-493.2ns ± 0%87.2ns ± 0%~(p=1.000 n=1+1)
SuperTypeInference/integers-4311ns ± 0%315ns ± 0%~(p=1.000 n=1+1)
ValueIsSubtypeOfSemaType-474.9ns ± 0%75.8ns ± 0%~(p=1.000 n=1+1)
 
alloc/opdelta
DecodeBatchEventsCCF-466.5MB ± 0%66.5MB ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsJSON-4244MB ± 0%244MB ± 0%~(all equal)
DecodeCCF/FlowFees.FeesDeducted-41.40kB ± 0%1.40kB ± 0%~(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-41.21kB ± 0%1.21kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-41.48kB ± 0%1.48kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-41.49kB ± 0%1.49kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-41.26kB ± 0%1.26kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-41.38kB ± 0%1.38kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited-41.32kB ± 0%1.32kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-41.30kB ± 0%1.30kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensMinted-41.21kB ± 0%1.21kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-41.33kB ± 0%1.33kB ± 0%~(all equal)
DecodeJSON/FlowFees.FeesDeducted-46.00kB ± 0%6.00kB ± 0%~(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-43.60kB ± 0%3.60kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-45.43kB ± 0%5.43kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-47.35kB ± 0%7.35kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-43.64kB ± 0%3.64kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-44.54kB ± 0%4.54kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited-44.88kB ± 0%4.88kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-44.46kB ± 0%4.46kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensMinted-43.60kB ± 0%3.60kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-44.88kB ± 0%4.88kB ± 0%~(all equal)
EncodeBatchEventsCCF-463.9MB ± 0%63.9MB ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-440.7MB ± 0%40.7MB ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-41.25kB ± 0%1.25kB ± 0%~(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-41.20kB ± 0%1.20kB ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-41.47kB ± 0%1.47kB ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-41.44kB ± 0%1.44kB ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-41.38kB ± 0%1.38kB ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-41.46kB ± 0%1.46kB ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited-41.25kB ± 0%1.25kB ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-41.23kB ± 0%1.23kB ± 0%~(all equal)
EncodeCCF/FlowToken.TokensMinted-41.20kB ± 0%1.20kB ± 0%~(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-41.25kB ± 0%1.25kB ± 0%~(all equal)
EncodeJSON/FlowFees.FeesDeducted-4896B ± 0%896B ± 0%~(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-4536B ± 0%536B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4920B ± 0%920B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-41.11kB ± 0%1.11kB ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4584B ± 0%584B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4784B ± 0%784B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited-4808B ± 0%808B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4672B ± 0%672B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensMinted-4544B ± 0%544B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-4800B ± 0%800B ± 0%~(all equal)
ExportType/composite_type-4120B ± 0%120B ± 0%~(all equal)
ExportType/simple_type-40.00B 0.00B ~(all equal)
InterpretRecursionFib-41.19MB ± 0%1.19MB ± 0%~(all equal)
NewInterpreter/new_interpreter-4944B ± 0%944B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-4200B ± 0%200B ± 0%~(all equal)
ParseArray-42.70MB ± 0%2.73MB ± 1%~(p=0.333 n=2+2)
ParseDeploy/byte_array-44.15MB ± 2%4.16MB ± 2%~(p=0.667 n=2+2)
ParseDeploy/decode_hex-4214kB ± 0%214kB ± 0%~(p=1.000 n=2+2)
ParseFungibleToken/With_memory_metering-429.6kB ± 0%29.6kB ± 0%~(p=1.000 n=2+2)
ParseFungibleToken/Without_memory_metering-429.6kB ± 0%29.6kB ± 0%~(p=1.000 n=2+2)
ParseInfix-41.92kB ± 0%1.92kB ± 0%~(p=0.333 n=2+2)
QualifiedIdentifierCreation/One_level-40.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-464.0B ± 0%64.0B ± 0%~(all equal)
RuntimeScriptNoop-43.37kB ± 0%3.37kB ± 0%~(all equal)
SuperTypeInference/arrays-496.0B ± 0%96.0B ± 0%~(all equal)
SuperTypeInference/composites-40.00B 0.00B ~(all equal)
SuperTypeInference/integers-40.00B 0.00B ~(all equal)
ValueIsSubtypeOfSemaType-448.0B ± 0%48.0B ± 0%~(all equal)
 
allocs/opdelta
DecodeBatchEventsCCF-41.48M ± 0%1.48M ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsJSON-44.70M ± 0%4.70M ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-430.0 ± 0%30.0 ± 0%~(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-426.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-430.0 ± 0%30.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-432.0 ± 0%32.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-426.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-429.0 ± 0%29.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited-431.0 ± 0%31.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-429.0 ± 0%29.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensMinted-426.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-431.0 ± 0%31.0 ± 0%~(all equal)
DecodeJSON/FlowFees.FeesDeducted-4126 ± 0%126 ± 0%~(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-471.0 ± 0%71.0 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4102 ± 0%102 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4159 ± 0%159 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-470.0 ± 0%70.0 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-487.0 ± 0%87.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited-495.0 ± 0%95.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-486.0 ± 0%86.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensMinted-471.0 ± 0%71.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-495.0 ± 0%95.0 ± 0%~(all equal)
EncodeBatchEventsCCF-41.00M ± 0%1.00M ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-4902k ± 0%902k ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-420.0 ± 0%20.0 ± 0%~(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-420.0 ± 0%20.0 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-420.0 ± 0%20.0 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-420.0 ± 0%20.0 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-420.0 ± 0%20.0 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-420.0 ± 0%20.0 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited-421.0 ± 0%21.0 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-421.0 ± 0%21.0 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensMinted-420.0 ± 0%20.0 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-421.0 ± 0%21.0 ± 0%~(all equal)
EncodeJSON/FlowFees.FeesDeducted-420.0 ± 0%20.0 ± 0%~(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-413.0 ± 0%13.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-417.0 ± 0%17.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-426.0 ± 0%26.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-413.0 ± 0%13.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-416.0 ± 0%16.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited-420.0 ± 0%20.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-415.0 ± 0%15.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensMinted-414.0 ± 0%14.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-419.0 ± 0%19.0 ± 0%~(all equal)
ExportType/composite_type-43.00 ± 0%3.00 ± 0%~(all equal)
ExportType/simple_type-40.00 0.00 ~(all equal)
InterpretRecursionFib-418.9k ± 0%18.9k ± 0%~(all equal)
NewInterpreter/new_interpreter-415.0 ± 0%15.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-44.00 ± 0%4.00 ± 0%~(all equal)
ParseArray-459.6k ± 0%59.6k ± 0%~(p=0.667 n=2+2)
ParseDeploy/byte_array-489.4k ± 0%89.4k ± 0%~(p=1.000 n=2+2)
ParseDeploy/decode_hex-463.0 ± 0%63.0 ± 0%~(all equal)
ParseFungibleToken/With_memory_metering-4773 ± 1%773 ± 1%~(p=1.000 n=2+2)
ParseFungibleToken/Without_memory_metering-4773 ± 1%773 ± 1%~(p=1.000 n=2+2)
ParseInfix-448.0 ± 0%48.0 ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-40.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-42.00 ± 0%2.00 ± 0%~(all equal)
RuntimeScriptNoop-451.0 ± 0%51.0 ± 0%~(all equal)
SuperTypeInference/arrays-43.00 ± 0%3.00 ± 0%~(all equal)
SuperTypeInference/composites-40.00 0.00 ~(all equal)
SuperTypeInference/integers-40.00 0.00 ~(all equal)
ValueIsSubtypeOfSemaType-41.00 ± 0%1.00 ± 0%~(all equal)
 

turbolent
turbolent approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fxamacker fxamacker merged commit 72871ab into feature/atree-register-inlining-v1.0 May 15, 2024
7 of 9 checks passed
@fxamacker fxamacker deleted the fxamacker/sync-atree-register-inlining-v1.0 branch June 18, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@SupunS SupunS Awaiting requested review from SupunS

@dsainati1 dsainati1 Awaiting requested review from dsainati1

Assignees

@fxamacker fxamacker

Labels
Chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fxamacker @turbolent @SupunS @dsainati1 @j1010001