Update atree inlining v1.0 feature branch #3301

turbolent · 2024-04-30T19:08:34Z

Description

Conflict resolution

commit 88681eda059e9c9dcb96e772c0914de9331c734a
Merge: e29e0f380 111954535
Author: Bastian Müller <[email protected]>
Date:   Tue Apr 30 12:07:13 2024 -0700

    Merge branch 'master' into bastian/update-atree-register-inlining-v1.0-2

diff --git a/go.mod b/go.mod
remerge CONFLICT (content): Merge conflict in go.mod
index ec4d8250b..fbfad771c 100644
--- a/go.mod
+++ b/go.mod
@@ -13,11 +13,7 @@ require (
 	github.com/kr/pretty v0.3.1
 	github.com/leanovate/gopter v0.2.9
 	github.com/logrusorgru/aurora/v4 v4.0.0
-<<<<<<< e29e0f380 (Merge pull request #3295 from onflow/fxamacker/bump-atree-version-in-atree-register-inlining-v1.0)
 	github.com/onflow/atree v0.6.1-0.20240429171214-e4400b25dfa9
-=======
-	github.com/onflow/atree v0.6.1-0.20240429171449-cb486ceb1f9c
->>>>>>> 111954535 (go mod tidy)
 	github.com/rivo/uniseg v0.4.4
 	github.com/schollz/progressbar/v3 v3.13.1
 	github.com/stretchr/testify v1.8.4
diff --git a/go.sum b/go.sum
remerge CONFLICT (content): Merge conflict in go.sum
index 915563284..be06ade17 100644
--- a/go.sum
+++ b/go.sum
@@ -72,13 +72,8 @@ github.com/mattn/go-tty v0.0.3/go.mod h1:ihxohKRERHTVzN+aSVRwACLCeqIoZAWpoICkkvr
 github.com/mitchellh/colorstring v0.0.0-20190213212951-d06e56a500db h1:62I3jR2EmQ4l5rM/4FEfDWcRD+abF5XlKShorW5LRoQ=
 github.com/mitchellh/colorstring v0.0.0-20190213212951-d06e56a500db/go.mod h1:l0dey0ia/Uv7NcFFVbCLtqEBQbrT4OCwCSKTEv6enCw=
 github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e h1:fD57ERR4JtEqsWbfPhv4DMiApHyliiK5xCTNVSPiaAs=
-<<<<<<< e29e0f380 (Merge pull request #3295 from onflow/fxamacker/bump-atree-version-in-atree-register-inlining-v1.0)
 github.com/onflow/atree v0.6.1-0.20240429171214-e4400b25dfa9 h1:lS/47Nt8qRIEC+V8QPobTAWnudK982u/wJboucugndg=
 github.com/onflow/atree v0.6.1-0.20240429171214-e4400b25dfa9/go.mod h1:7YNAyCd5JENq+NzH+fR1ABUZVzbSq9dkt0+5fZH3L2A=
-=======
-github.com/onflow/atree v0.6.1-0.20240429171449-cb486ceb1f9c h1:Ol+qFATYiS7LfwQQKBjfLJ8z6VwzZehVrYH1JI2ssUU=
-github.com/onflow/atree v0.6.1-0.20240429171449-cb486ceb1f9c/go.mod h1:xvP61FoOs95K7IYdIYRnNcYQGf4nbF/uuJ0tHf4DRuM=
->>>>>>> 111954535 (go mod tidy)
 github.com/onflow/crypto v0.25.0 h1:BeWbLsh3ZD13Ej+Uky6kg1PL1ZIVBDVX+2MVBNwqddg=
 github.com/onflow/crypto v0.25.0/go.mod h1:C8FbaX0x8y+FxWjbkHy0Q4EASCDR9bSPWZqlpCLYyVI=
 github.com/pkg/diff v0.0.0-20210226163009-20ebb0f2a09e/go.mod h1:pJLUxLENpZxwdsKMEsNbx1VGcRFpLqf3715MtcvvzbA=
diff --git a/migrations/migration_test.go b/migrations/migration_test.go
index d89041d7d..0665f4eec 100644
--- a/migrations/migration_test.go
+++ b/migrations/migration_test.go
@@ -2722,10 +2722,10 @@ func TestFixLoadedBrokenReferences(t *testing.T) {
 
 		// Convert the owner/key to a storage ID.
 
-		var storageIndex atree.StorageIndex
-		copy(storageIndex[:], key[1:])
+		var slabIndex atree.SlabIndex
+		copy(slabIndex[:], key[1:])
 
-		storageID := atree.NewStorageID(atree.Address(owner), storageIndex)
+		storageID := atree.NewSlabID(atree.Address(owner), slabIndex)
 
 		// Retrieve the slab.
 		_, _, err = storage.Retrieve(storageID)
diff --git a/tools/storage-explorer/go.mod b/tools/storage-explorer/go.mod
remerge CONFLICT (content): Merge conflict in tools/storage-explorer/go.mod
index 39e92acf5..9da1febc3 100644
--- a/tools/storage-explorer/go.mod
+++ b/tools/storage-explorer/go.mod
@@ -4,11 +4,7 @@ go 1.20
 
 require (
 	github.com/gorilla/mux v1.8.1
-<<<<<<< e29e0f380 (Merge pull request #3295 from onflow/fxamacker/bump-atree-version-in-atree-register-inlining-v1.0)
-	github.com/onflow/atree v0.6.1-0.20240417191405-e11f55fa33a3
-=======
-	github.com/onflow/atree v0.6.1-0.20240429171449-cb486ceb1f9c
->>>>>>> 111954535 (go mod tidy)
+	github.com/onflow/atree v0.6.1-0.20240429171214-e4400b25dfa9
 	github.com/onflow/cadence v1.0.0-M8
 	github.com/onflow/flow-go v0.34.0-crescendo-preview.5.0.20240229164931-a67398875618
 	github.com/rs/zerolog v1.32.0
diff --git a/tools/storage-explorer/go.sum b/tools/storage-explorer/go.sum
remerge CONFLICT (content): Merge conflict in tools/storage-explorer/go.sum
index fafaa228d..124422d51 100644
--- a/tools/storage-explorer/go.sum
+++ b/tools/storage-explorer/go.sum
@@ -1775,13 +1775,8 @@ github.com/oklog/ulid v1.3.1/go.mod h1:CirwcVhetQ6Lv90oh/F+FBtV6XMibvdAFo93nm5qn
 github.com/olekukonko/tablewriter v0.0.5 h1:P2Ga83D34wi1o9J6Wh1mRuqd4mF/x/lgBS7N7AbDhec=
 github.com/olekukonko/tablewriter v0.0.5/go.mod h1:hPp6KlRPjbx+hW8ykQs1w3UBbZlj6HuIJcUGPhkA7kY=
 github.com/onflow/atree v0.6.1-0.20230711151834-86040b30171f/go.mod h1:xvP61FoOs95K7IYdIYRnNcYQGf4nbF/uuJ0tHf4DRuM=
-<<<<<<< e29e0f380 (Merge pull request #3295 from onflow/fxamacker/bump-atree-version-in-atree-register-inlining-v1.0)
-github.com/onflow/atree v0.6.1-0.20240417191405-e11f55fa33a3 h1:K8LKxRn1rRdDXLCvYlDNdlQyB28b+fx2doYiIaNGnQU=
-github.com/onflow/atree v0.6.1-0.20240417191405-e11f55fa33a3/go.mod h1:7YNAyCd5JENq+NzH+fR1ABUZVzbSq9dkt0+5fZH3L2A=
-=======
-github.com/onflow/atree v0.6.1-0.20240429171449-cb486ceb1f9c h1:Ol+qFATYiS7LfwQQKBjfLJ8z6VwzZehVrYH1JI2ssUU=
-github.com/onflow/atree v0.6.1-0.20240429171449-cb486ceb1f9c/go.mod h1:xvP61FoOs95K7IYdIYRnNcYQGf4nbF/uuJ0tHf4DRuM=
->>>>>>> 111954535 (go mod tidy)
+github.com/onflow/atree v0.6.1-0.20240429171214-e4400b25dfa9 h1:lS/47Nt8qRIEC+V8QPobTAWnudK982u/wJboucugndg=
+github.com/onflow/atree v0.6.1-0.20240429171214-e4400b25dfa9/go.mod h1:7YNAyCd5JENq+NzH+fR1ABUZVzbSq9dkt0+5fZH3L2A=
 github.com/onflow/crypto v0.25.0 h1:BeWbLsh3ZD13Ej+Uky6kg1PL1ZIVBDVX+2MVBNwqddg=
 github.com/onflow/crypto v0.25.0/go.mod h1:C8FbaX0x8y+FxWjbkHy0Q4EASCDR9bSPWZqlpCLYyVI=
 github.com/onflow/flow-core-contracts/lib/go/contracts v0.15.2-0.20240227190927-0e6ce7e3222b h1:oXHQft30sElpK7G3xWB5tEizI2G+S4p64iVh0LtX4E0=

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

Update update tool config

Bump atree version in master branch

Add runtime check for transaction value moves

…LoadedBrokenReferences

…s-by-index

…oken-references

github-actions · 2024-04-30T19:13:42Z

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/atree-register-inlining-v1.0 commit e29e0f3
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
DecodeBatchEventsCCF-4	128ms ± 0%	129ms ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	383ms ± 0%	379ms ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	2.80µs ± 0%	2.82µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.TokensWithdrawn-4	2.11µs ± 0%	2.14µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	2.80µs ± 0%	2.81µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	3.15µs ± 0%	3.12µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	2.12µs ± 0%	2.16µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	2.49µs ± 0%	2.50µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited-4	2.57µs ± 0%	2.56µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	2.48µs ± 0%	2.49µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensMinted-4	2.10µs ± 0%	2.13µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensWithdrawn-4	2.58µs ± 0%	2.58µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowFees.FeesDeducted-4	9.38µs ± 0%	9.71µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowFees.TokensWithdrawn-4	5.48µs ± 0%	5.45µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	8.48µs ± 0%	8.50µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	11.6µs ± 0%	11.6µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	5.59µs ± 0%	5.64µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	7.18µs ± 0%	7.16µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited-4	8.05µs ± 0%	7.50µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	6.83µs ± 0%	6.83µs ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensMinted-4	5.57µs ± 0%	5.57µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensWithdrawn-4	7.65µs ± 0%	7.62µs ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsCCF-4	88.2ms ± 0%	96.8ms ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	104ms ± 0%	107ms ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	1.95µs ± 0%	2.05µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.TokensWithdrawn-4	1.52µs ± 0%	1.58µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.87µs ± 0%	1.95µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	2.20µs ± 0%	2.25µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.56µs ± 0%	1.62µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	1.71µs ± 0%	1.79µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited-4	1.78µs ± 0%	1.83µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.73µs ± 0%	1.81µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensMinted-4	1.53µs ± 0%	1.60µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensWithdrawn-4	1.78µs ± 0%	1.84µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.FeesDeducted-4	2.56µs ± 0%	2.56µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.TokensWithdrawn-4	1.41µs ± 0%	1.47µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	2.19µs ± 0%	2.27µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	3.11µs ± 0%	3.19µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	1.45µs ± 0%	1.48µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	1.88µs ± 0%	1.95µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited-4	2.14µs ± 0%	2.31µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	1.68µs ± 0%	1.73µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensMinted-4	1.43µs ± 0%	1.46µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensWithdrawn-4	2.12µs ± 0%	2.17µs ± 0%	~	(p=1.000 n=1+1)
ExportType/composite_type-4	276ns ± 0%	283ns ± 0%	~	(p=1.000 n=1+1)
ExportType/simple_type-4	71.8ns ± 0%	70.0ns ± 0%	~	(p=1.000 n=1+1)
InterpretRecursionFib-4	2.22ms ± 0%	2.28ms ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	1.03µs ± 0%	0.95µs ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4	477ns ± 0%	463ns ± 0%	~	(p=1.000 n=1+1)
ParseArray-4	5.96ms ± 0%	5.95ms ± 1%	~	(p=1.000 n=2+2)
ParseDeploy/byte_array-4	8.92ms ± 1%	8.92ms ± 1%	~	(p=1.000 n=2+2)
ParseDeploy/decode_hex-4	948µs ± 0%	948µs ± 0%	~	(p=1.000 n=2+2)
ParseFungibleToken/With_memory_metering-4	146µs ± 4%	146µs ± 4%	~	(p=0.667 n=2+2)
ParseFungibleToken/Without_memory_metering-4	114µs ± 3%	117µs ± 6%	~	(p=1.000 n=2+2)
ParseInfix-4	5.28µs ± 2%	5.21µs ± 0%	~	(p=1.000 n=2+2)
QualifiedIdentifierCreation/One_level-4	2.48ns ± 0%	2.49ns ± 0%	~	(p=1.000 n=1+1)
QualifiedIdentifierCreation/Three_levels-4	83.3ns ± 0%	87.5ns ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	3.71µs ± 0%	3.72µs ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/arrays-4	238ns ± 0%	237ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/composites-4	98.4ns ± 0%	98.6ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/integers-4	313ns ± 0%	310ns ± 0%	~	(p=1.000 n=1+1)
ValueIsSubtypeOfSemaType-4	69.8ns ± 0%	70.6ns ± 0%	~	(p=1.000 n=1+1)

	alloc/op		delta
DecodeBatchEventsCCF-4	66.5MB ± 0%	66.5MB ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	244MB ± 0%	244MB ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	1.40kB ± 0%	1.40kB ± 0%	~	(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-4	1.21kB ± 0%	1.21kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.48kB ± 0%	1.48kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.49kB ± 0%	1.49kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.26kB ± 0%	1.26kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	1.38kB ± 0%	1.38kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited-4	1.32kB ± 0%	1.32kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.30kB ± 0%	1.30kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensMinted-4	1.21kB ± 0%	1.21kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-4	1.33kB ± 0%	1.33kB ± 0%	~	(all equal)
DecodeJSON/FlowFees.FeesDeducted-4	6.00kB ± 0%	6.00kB ± 0%	~	(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-4	3.60kB ± 0%	3.60kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	5.43kB ± 0%	5.43kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	7.35kB ± 0%	7.35kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	3.64kB ± 0%	3.64kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	4.54kB ± 0%	4.54kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited-4	4.88kB ± 0%	4.88kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	4.46kB ± 0%	4.46kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensMinted-4	3.60kB ± 0%	3.60kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-4	4.88kB ± 0%	4.88kB ± 0%	~	(all equal)
EncodeBatchEventsCCF-4	62.4MB ± 0%	63.9MB ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	39.1MB ± 0%	40.7MB ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	1.22kB ± 0%	1.25kB ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.TokensWithdrawn-4	1.17kB ± 0%	1.20kB ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.44kB ± 0%	1.47kB ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.41kB ± 0%	1.44kB ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.34kB ± 0%	1.38kB ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	1.42kB ± 0%	1.46kB ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited-4	1.22kB ± 0%	1.25kB ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.20kB ± 0%	1.23kB ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensMinted-4	1.17kB ± 0%	1.20kB ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensWithdrawn-4	1.22kB ± 0%	1.25kB ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.FeesDeducted-4	864B ± 0%	896B ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.TokensWithdrawn-4	504B ± 0%	536B ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	888B ± 0%	920B ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.08kB ± 0%	1.11kB ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	552B ± 0%	584B ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	752B ± 0%	784B ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited-4	776B ± 0%	808B ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	640B ± 0%	672B ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensMinted-4	512B ± 0%	544B ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensWithdrawn-4	768B ± 0%	800B ± 0%	~	(p=1.000 n=1+1)
ExportType/composite_type-4	120B ± 0%	120B ± 0%	~	(all equal)
ExportType/simple_type-4	0.00B	0.00B	~	(all equal)
InterpretRecursionFib-4	1.19MB ± 0%	1.19MB ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	944B ± 0%	944B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	200B ± 0%	200B ± 0%	~	(all equal)
ParseArray-4	2.71MB ± 2%	2.68MB ± 1%	~	(p=1.000 n=2+2)
ParseDeploy/byte_array-4	4.22MB ± 0%	4.16MB ± 2%	~	(p=1.000 n=2+2)
ParseDeploy/decode_hex-4	214kB ± 0%	214kB ± 0%	~	(p=1.000 n=2+2)
ParseFungibleToken/With_memory_metering-4	29.6kB ± 0%	29.6kB ± 0%	~	(p=0.667 n=2+2)
ParseFungibleToken/Without_memory_metering-4	29.6kB ± 0%	29.6kB ± 0%	~	(p=1.000 n=2+2)
ParseInfix-4	1.92kB ± 0%	1.92kB ± 0%	~	(p=0.667 n=2+2)
QualifiedIdentifierCreation/One_level-4	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	64.0B ± 0%	64.0B ± 0%	~	(all equal)
RuntimeScriptNoop-4	3.37kB ± 0%	3.37kB ± 0%	~	(all equal)
SuperTypeInference/arrays-4	96.0B ± 0%	96.0B ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00B	0.00B	~	(all equal)
SuperTypeInference/integers-4	0.00B	0.00B	~	(all equal)
ValueIsSubtypeOfSemaType-4	48.0B ± 0%	48.0B ± 0%	~	(all equal)

	allocs/op		delta
DecodeBatchEventsCCF-4	1.48M ± 0%	1.48M ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	4.70M ± 0%	4.70M ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	30.0 ± 0%	30.0 ± 0%	~	(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	30.0 ± 0%	30.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	32.0 ± 0%	32.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	29.0 ± 0%	29.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited-4	31.0 ± 0%	31.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	29.0 ± 0%	29.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensMinted-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-4	31.0 ± 0%	31.0 ± 0%	~	(all equal)
DecodeJSON/FlowFees.FeesDeducted-4	126 ± 0%	126 ± 0%	~	(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-4	71.0 ± 0%	71.0 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	102 ± 0%	102 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	159 ± 0%	159 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	70.0 ± 0%	70.0 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	87.0 ± 0%	87.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited-4	95.0 ± 0%	95.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	86.0 ± 0%	86.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensMinted-4	71.0 ± 0%	71.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-4	95.0 ± 0%	95.0 ± 0%	~	(all equal)
EncodeBatchEventsCCF-4	950k ± 0%	998k ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	853k ± 0%	902k ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	19.0 ± 0%	20.0 ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.TokensWithdrawn-4	19.0 ± 0%	20.0 ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	19.0 ± 0%	20.0 ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	19.0 ± 0%	20.0 ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	19.0 ± 0%	20.0 ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	19.0 ± 0%	20.0 ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited-4	20.0 ± 0%	21.0 ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	20.0 ± 0%	21.0 ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensMinted-4	19.0 ± 0%	20.0 ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensWithdrawn-4	20.0 ± 0%	21.0 ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.FeesDeducted-4	19.0 ± 0%	20.0 ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.TokensWithdrawn-4	12.0 ± 0%	13.0 ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	16.0 ± 0%	17.0 ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	25.0 ± 0%	26.0 ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	12.0 ± 0%	13.0 ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	15.0 ± 0%	16.0 ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited-4	19.0 ± 0%	20.0 ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	14.0 ± 0%	15.0 ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensMinted-4	13.0 ± 0%	14.0 ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensWithdrawn-4	18.0 ± 0%	19.0 ± 0%	~	(p=1.000 n=1+1)
ExportType/composite_type-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
ExportType/simple_type-4	0.00	0.00	~	(all equal)
InterpretRecursionFib-4	18.9k ± 0%	18.9k ± 0%	~	(all equal)
NewInterpreter/new_interpreter-4	15.0 ± 0%	15.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	4.00 ± 0%	4.00 ± 0%	~	(all equal)
ParseArray-4	59.6k ± 0%	59.6k ± 0%	~	(p=1.000 n=2+2)
ParseDeploy/byte_array-4	89.4k ± 0%	89.4k ± 0%	~	(p=1.000 n=2+2)
ParseDeploy/decode_hex-4	63.0 ± 0%	63.0 ± 0%	~	(all equal)
ParseFungibleToken/With_memory_metering-4	773 ± 1%	773 ± 1%	~	(p=1.000 n=2+2)
ParseFungibleToken/Without_memory_metering-4	773 ± 1%	773 ± 1%	~	(p=1.000 n=2+2)
ParseInfix-4	48.0 ± 0%	48.0 ± 0%	~	(all equal)
QualifiedIdentifierCreation/One_level-4	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	2.00 ± 0%	2.00 ± 0%	~	(all equal)
RuntimeScriptNoop-4	51.0 ± 0%	51.0 ± 0%	~	(all equal)
SuperTypeInference/arrays-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00	0.00	~	(all equal)
SuperTypeInference/integers-4	0.00	0.00	~	(all equal)
ValueIsSubtypeOfSemaType-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)

turbolent and others added 17 commits April 26, 2024 10:57

Merge pull request #3289 from onflow/release/v1.0.0-preview.23

89f8a41

unexport fields to prevent access by index

0f10d57

remove Value.ToGoValue and NewValue

6c50a30

tests module got renamed

d93686b

nolint

8d20e96

Merge pull request #3292 from onflow/bastian/update-update-tool-config

7d3f1e9

Update update tool config

Bump atree version to latest

56d60c0

Merge pull request #3293 from onflow/fxamacker/bump-atree-version

fb2e13d

Bump atree version in master branch

Add runtime check for transaction value moves

ef4680d

Merge pull request #3298 from onflow/supun/transaction-move

0805a65

Add runtime check for transaction value moves

add predicate function and test for atree's PersistentSlabStorage.Fix…

5d04cba

…LoadedBrokenReferences

Merge pull request #3290 from onflow/bastian/2952-remove-fields-acces…

e9105b6

…s-by-index

Merge branch 'master' into bastian/remove-value-togovalue

6dcc2d4

Merge pull request #3291 from onflow/bastian/remove-value-togovalue

b620906

Merge pull request #3300 from onflow/bastian/test-atree-fix-loaded-br…

5b44ba6

…oken-references

go mod tidy

1119545

Merge branch 'master' into bastian/update-atree-register-inlining-v1.0-2

88681ed

turbolent added the Chore label Apr 30, 2024

turbolent requested a review from fxamacker April 30, 2024 19:08

turbolent requested review from SupunS and dsainati1 as code owners April 30, 2024 19:08

SupunS approved these changes May 1, 2024

View reviewed changes

dsainati1 approved these changes May 1, 2024

View reviewed changes

turbolent merged commit 09bb39a into feature/atree-register-inlining-v1.0 May 1, 2024
7 of 9 checks passed

turbolent deleted the bastian/update-atree-register-inlining-v1.0-2 branch May 1, 2024 15:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update atree inlining v1.0 feature branch #3301

Update atree inlining v1.0 feature branch #3301

turbolent commented Apr 30, 2024 •

edited

Loading

github-actions bot commented Apr 30, 2024

Update atree inlining v1.0 feature branch #3301

Update atree inlining v1.0 feature branch #3301

Conversation

turbolent commented Apr 30, 2024 • edited Loading

Description

github-actions bot commented Apr 30, 2024

Cadence Benchstat comparison

turbolent commented Apr 30, 2024 •

edited

Loading