Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent container mutation while iterating #3126

Merged
merged 2 commits into from
Feb 27, 2024

Transfer elements only for the for-loop

2354104
Select commit
Loading
Failed to load commit list.
Merged

Prevent container mutation while iterating #3126

Transfer elements only for the for-loop
2354104
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 27, 2024 in 0s

80.62% (-0.05%) compared to 99159e8

View this Pull Request on Codecov

80.62% (-0.05%) compared to 99159e8

Details

Codecov Report

Attention: Patch coverage is 84.59119% with 49 lines in your changes are missing coverage. Please review.

Project coverage is 80.62%. Comparing base (99159e8) to head (2354104).
Report is 63 commits behind head on master.

Files Patch % Lines
runtime/stdlib/test.go 28.00% 18 Missing ⚠️
runtime/interpreter/interpreter.go 83.63% 6 Missing and 3 partials ⚠️
runtime/stdlib/bls.go 69.23% 4 Missing and 4 partials ⚠️
runtime/stdlib/test_emulatorbackend.go 41.66% 7 Missing ⚠️
runtime/convertValues.go 83.33% 2 Missing and 1 partial ⚠️
runtime/interpreter/value.go 98.33% 2 Missing ⚠️
runtime/interpreter/value_string.go 95.34% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3126      +/-   ##
==========================================
- Coverage   80.67%   80.62%   -0.05%     
==========================================
  Files         379      380       +1     
  Lines       91523    92053     +530     
==========================================
+ Hits        73834    74218     +384     
- Misses      15047    15160     +113     
- Partials     2642     2675      +33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov