Rewrite owned intersection types in migration #3118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupunS
approved these changes
Feb 20, 2024
SupunS
reviewed
Feb 20, 2024
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit e60051d Collapsed results for better readability
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3118 +/- ##
==========================================
- Coverage 80.67% 80.56% -0.11%
==========================================
Files 379 379
Lines 91523 91576 +53
==========================================
- Hits 73834 73782 -52
- Misses 15047 15134 +87
- Partials 2642 2660 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6 tasks
SupunS
approved these changes
Feb 21, 2024
|
I tried to add the rules to the entitlements migration in a2232d9. I refactored it and fixed some bugs and gaps along the way. I got the rules working by re-using However, I noticed there is one crucial exception: https://github.com/onflow/cadence/pull/3118/files#diff-8fed0196f6dd9c6e80c1943403eff29f29b7f4651dded1b7df9ffa1c6449e9afR892-R893: For the particular case This is currently difficult to implement, because the static type to sema type conversion looses the information that is necessary. I'll keep fixing this last issue tomorrow |
|
Improved the entitlements migration further in c10a6eb, unifying the authorization/entitlements calculation for static intersection types and in general for other entitlements-supporting types, and refactoring the migration to be mainly based on static types, only converting to sema types if needed. Before, the migration always converted static to sema, added entitlements, and converted back from sema to static, for the whole type. This also fixes the last edge case, |
6 tasks
turbolent
commented
Feb 22, 2024
SupunS
reviewed
Feb 22, 2024
SupunS
approved these changes
Feb 22, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3112
masterbranchFiles changedin the Github PR explorer