Allow analysis.Load to continue with parsing/checking errors #3083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 1f7a1f6 Collapsed results for better readability
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3083 +/- ##
=======================================
Coverage 80.65% 80.65%
=======================================
Files 379 379
Lines 91436 91478 +42
=======================================
+ Hits 73749 73785 +36
- Misses 15041 15045 +4
- Partials 2646 2648 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6 tasks
jribbink
changed the title
jribbink
force-pushed
the
jribbink/analysis-error-handlers
branch
from
6821734
to
5d88a4a
Compare
jribbink
requested review from
turbolent,
SupunS and
dsainati1
as code owners
Co-authored-by: Bastian Müller <[email protected]>
jribbink
changed the title
turbolent
reviewed
Feb 13, 2024
|
@SupunS Can you please also have a look? |
|
Merging this for now so we can get a release out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3087
Description
Allow for custom checker/parser handlers to be configured in the analysis tool. These errors may be non-fatal & this gives the option to choose whether to suppress them and continue analysis.
Unblocks onflow/cadence-tools#285. Pre-cadence 1.0 code is not semantically valid in cadence 1.0 checker so these errors will be present. In order to run the cadence 1.0 analyzer, a mechanism needs to exist to suppress these errors. This is similar to the behaviour that already exists in the language server.
masterbranchFiles changedin the Github PR explorer