Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync stable-cadence branch with master #2964

Merged
merged 143 commits into from
Dec 5, 2023
Merged

Sync stable-cadence branch with master #2964

merged 143 commits into from
Dec 5, 2023

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Dec 5, 2023 •
edited
Loading

Description

Conflicts: https://gist.github.com/SupunS/5d26a4319af2a4a5a69507b75d4a7ce4

Manually added changes:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

darkdrag00nv2 and others added 30 commits October 15, 2023 15:27
@darkdrag00nv2
WIP: Introduce HashableStruct
dd2e003
@darkdrag00nv2
remove commented code
531e40d
@darkdrag00nv2
Fix all existing tests
d6298f5
@darkdrag00nv2
Add import/export for HashableStruct
047939d
@darkdrag00nv2
Add test cases
c94d3ff
@darkdrag00nv2
regenerate primitivestatictype
2e07531
@SupunS
Prevent nested contract deployments
df4b6fd
@SupunS
Separate nested update vs sequential update tracking
03f1b91
@SupunS @turbolent
Refactor code
a9a65d7 
Co-authored-by: Bastian Müller <[email protected]>
@SupunS
Merge pull request #148 from dapperlabs/supun/port-147
ba93bb3 
[v0.42] Prevent nested contract deployments
rename the generator interface to RandomGenerator
9e1716b
add new standard library value for revertibleRandom
86de31b
add revertibleRandom test
611ad45
fix indent
217c359
@darkdrag00nv2 @SupunS
Remove redundant IsResourceType() check
c305cae 
Co-authored-by: Supun Setunga <[email protected]>
@darkdrag00nv2 @SupunS
Fix identation
464b4ef 
Co-authored-by: Supun Setunga <[email protected]>
@darkdrag00nv2 @SupunS
Fix indentation
65c6499 
Co-authored-by: Supun Setunga <[email protected]>
@darkdrag00nv2
Remove redundant change
b619887
@darkdrag00nv2
Define HashableStruct in Cadence and auto generate
4d6442b
@turbolent
commit storage temporarily before creating account, so host can obser…
4f95580 
…ve existing writes
@darkdrag00nv2
Add hashable_struct_test in sema
9ea3e61
@darkdrag00nv2
Update ccf test for HashableStruct
a067ed6
@darkdrag00nv2
Remove test for HashableStruct inside a static function
3e3f169
@SupunS
Prevent nested contract deployments
9ec4d34
@SupunS
Separate nested update vs sequential update tracking
ba9e470
@SupunS @turbolent
Refactor code
3d85fe0 
Co-authored-by: Bastian Müller <[email protected]>
update computation constant name from revertible to unsafe
1d90ebe
@turbolent
Merge pull request #149 from dapperlabs/bastian/fix-authaccount-creation
1ba2d97
@SupunS
Prevent nested contract deployments
e7d6412
@SupunS
Separate nested update vs sequential update tracking
b0d4489
turbolent and others added 14 commits November 24, 2023 13:49
@turbolent
Merge pull request #166 from dapperlabs/bastian/improve-if-variable-d…
3151d8b 
…eclaration-evaluation
@turbolent
Merge branch 'v0.42' into supun/fix-transfer
6be2863
@SupunS
Merge pull request #165 from dapperlabs/supun/fix-transfer
25ee29b 
Transfer value before the second value is visited
@turbolent
add test for invalid resoruce use in else branch after second value i…
27297e1 
…nvalidation
@turbolent
Merge pull request #167 from dapperlabs/bastian/add-test-2
a2f4f34
@SupunS
Reject resource method pointers in assignment
f9f4e6d
@SupunS
Merge pull request #179 from dapperlabs/supun/resource-method-poointers
6524cd9 
Reject resource method pointers in assignment
@SupunS
Merge pull request #2955 from onflow/supun/internal-v0.42
cdae59a 
Port bug fixes from `v0.42.5-patch.1`
@SupunS
Merge branch 'v0.42' of https://github.com/onflow/cadence into supun/…
7beb8f2 
…sync-with-0.42
@SupunS
Merge pull request #2956 from onflow/supun/sync-with-0.42
b48fd6b 
Port bug fixes from v0.42.5-patch.1
@SupunS
Merge branch 'master' of https://github.com/onflow/cadence into supun…
ee46be9 
…/sc-sync-master
@SupunS
Fix bound function tests
ef7f1f7
@SupunS
Bring back 'inAssignment' flag
a6bf7a9
@SupunS
Update newly added tests to match stable-cadence changes
f2b08fa
@SupunS SupunS self-assigned this Dec 5, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/stable-cadence commit 787812f
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
DecodeBatchEventsCCF-4127ms ± 0%128ms ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsJSON-4384ms ± 0%1179ms ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-42.79µs ± 0%2.77µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.TokensWithdrawn-42.10µs ± 0%2.22µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-42.76µs ± 0%2.81µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-43.16µs ± 0%3.11µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-42.25µs ± 0%2.12µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.RewardsPaid-42.48µs ± 0%2.47µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited-42.57µs ± 0%2.56µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-42.49µs ± 0%2.46µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensMinted-42.10µs ± 0%2.11µs ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensWithdrawn-42.59µs ± 0%2.59µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowFees.FeesDeducted-49.60µs ± 0%9.46µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowFees.TokensWithdrawn-45.53µs ± 0%5.52µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-48.59µs ± 0%8.58µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-411.8µs ± 0%11.7µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-45.68µs ± 0%5.77µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.RewardsPaid-47.27µs ± 0%7.26µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited-47.57µs ± 0%7.60µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-46.87µs ± 0%7.13µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensMinted-45.59µs ± 0%5.64µs ± 0%~(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensWithdrawn-47.61µs ± 0%7.59µs ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsCCF-488.1ms ± 0%88.2ms ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-4104ms ± 0%103ms ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-41.96µs ± 0%1.98µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.TokensWithdrawn-41.55µs ± 0%1.56µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-41.90µs ± 0%1.89µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-42.21µs ± 0%2.21µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-41.58µs ± 0%1.59µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.RewardsPaid-41.73µs ± 0%1.73µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited-41.78µs ± 0%1.79µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-41.76µs ± 0%1.79µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensMinted-41.57µs ± 0%1.56µs ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensWithdrawn-41.78µs ± 0%1.80µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowFees.FeesDeducted-42.45µs ± 0%2.41µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowFees.TokensWithdrawn-41.40µs ± 0%1.38µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-42.17µs ± 0%2.17µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-43.06µs ± 0%3.02µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-41.42µs ± 0%1.41µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.RewardsPaid-41.81µs ± 0%1.80µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited-42.10µs ± 0%2.09µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-41.67µs ± 0%1.65µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensMinted-41.41µs ± 0%1.39µs ± 0%~(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensWithdrawn-42.08µs ± 0%2.07µs ± 0%~(p=1.000 n=1+1)
ExportType/composite_type-4300ns ± 0%294ns ± 0%~(p=1.000 n=1+1)
ExportType/simple_type-471.0ns ± 0%70.0ns ± 0%~(p=1.000 n=1+1)
InterpretRecursionFib-41.94ms ± 0%1.91ms ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4964ns ± 0%966ns ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4450ns ± 0%453ns ± 0%~(p=1.000 n=1+1)
ParseArray-46.03ms ± 0%5.95ms ± 0%~(p=1.000 n=1+1)
ParseDeploy/byte_array-49.20ms ± 0%8.96ms ± 0%~(p=1.000 n=1+1)
ParseDeploy/decode_hex-41.05ms ± 0%1.02ms ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/With_memory_metering-4153µs ± 0%153µs ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/Without_memory_metering-4120µs ± 0%128µs ± 0%~(p=1.000 n=1+1)
ParseInfix-45.46µs ± 0%5.20µs ± 0%~(p=1.000 n=1+1)
QualifiedIdentifierCreation/One_level-42.48ns ± 0%2.48ns ± 0%~(all equal)
QualifiedIdentifierCreation/Three_levels-483.7ns ± 0%83.6ns ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-43.75µs ± 0%3.60µs ± 0%~(p=1.000 n=1+1)
SuperTypeInference/arrays-4240ns ± 0%238ns ± 0%~(p=1.000 n=1+1)
SuperTypeInference/composites-490.8ns ± 0%88.9ns ± 0%~(p=1.000 n=1+1)
SuperTypeInference/integers-4132ns ± 0%136ns ± 0%~(p=1.000 n=1+1)
ValueIsSubtypeOfSemaType-472.5ns ± 0%77.3ns ± 0%~(p=1.000 n=1+1)
 
alloc/opdelta
DecodeBatchEventsCCF-466.1MB ± 0%66.1MB ± 0%~(p=1.000 n=1+1)
DecodeBatchEventsJSON-4244MB ± 0%244MB ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-41.39kB ± 0%1.39kB ± 0%~(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-41.20kB ± 0%1.20kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-41.47kB ± 0%1.47kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-41.48kB ± 0%1.48kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-41.25kB ± 0%1.25kB ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-41.37kB ± 0%1.37kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited-41.31kB ± 0%1.31kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-41.30kB ± 0%1.30kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensMinted-41.20kB ± 0%1.20kB ± 0%~(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-41.32kB ± 0%1.32kB ± 0%~(all equal)
DecodeJSON/FlowFees.FeesDeducted-46.00kB ± 0%6.00kB ± 0%~(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-43.60kB ± 0%3.60kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-45.43kB ± 0%5.43kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-47.35kB ± 0%7.35kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-43.64kB ± 0%3.64kB ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-44.54kB ± 0%4.54kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited-44.88kB ± 0%4.88kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-44.46kB ± 0%4.46kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensMinted-43.60kB ± 0%3.60kB ± 0%~(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-44.88kB ± 0%4.88kB ± 0%~(all equal)
EncodeBatchEventsCCF-462.4MB ± 0%62.4MB ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-439.1MB ± 0%39.1MB ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-41.22kB ± 0%1.22kB ± 0%~(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-41.17kB ± 0%1.17kB ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-41.44kB ± 0%1.44kB ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-41.41kB ± 0%1.41kB ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-41.34kB ± 0%1.34kB ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-41.42kB ± 0%1.42kB ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited-41.22kB ± 0%1.22kB ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-41.20kB ± 0%1.20kB ± 0%~(all equal)
EncodeCCF/FlowToken.TokensMinted-41.17kB ± 0%1.17kB ± 0%~(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-41.22kB ± 0%1.22kB ± 0%~(all equal)
EncodeJSON/FlowFees.FeesDeducted-4864B ± 0%864B ± 0%~(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-4504B ± 0%504B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4888B ± 0%888B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-41.08kB ± 0%1.08kB ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4552B ± 0%552B ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4752B ± 0%752B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited-4776B ± 0%776B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4640B ± 0%640B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensMinted-4512B ± 0%512B ± 0%~(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-4768B ± 0%768B ± 0%~(all equal)
ExportType/composite_type-4120B ± 0%120B ± 0%~(all equal)
ExportType/simple_type-40.00B 0.00B ~(all equal)
InterpretRecursionFib-41.00MB ± 0%1.00MB ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4928B ± 0%928B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-4200B ± 0%200B ± 0%~(all equal)
ParseArray-42.71MB ± 0%2.71MB ± 0%~(p=1.000 n=1+1)
ParseDeploy/byte_array-44.22MB ± 0%4.09MB ± 0%~(p=1.000 n=1+1)
ParseDeploy/decode_hex-4214kB ± 0%214kB ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/With_memory_metering-429.7kB ± 0%29.8kB ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/Without_memory_metering-429.7kB ± 0%29.7kB ± 0%~(all equal)
ParseInfix-41.92kB ± 0%1.92kB ± 0%~(p=1.000 n=1+1)
QualifiedIdentifierCreation/One_level-40.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-464.0B ± 0%64.0B ± 0%~(all equal)
RuntimeScriptNoop-43.21kB ± 0%3.21kB ± 0%~(all equal)
SuperTypeInference/arrays-496.0B ± 0%96.0B ± 0%~(all equal)
SuperTypeInference/composites-40.00B 0.00B ~(all equal)
SuperTypeInference/integers-40.00B 0.00B ~(all equal)
ValueIsSubtypeOfSemaType-448.0B ± 0%48.0B ± 0%~(all equal)
 
allocs/opdelta
DecodeBatchEventsCCF-41.48M ± 0%1.48M ± 0%~(all equal)
DecodeBatchEventsJSON-44.70M ± 0%4.70M ± 0%~(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-430.0 ± 0%30.0 ± 0%~(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-426.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-430.0 ± 0%30.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-432.0 ± 0%32.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-426.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-429.0 ± 0%29.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited-431.0 ± 0%31.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-429.0 ± 0%29.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensMinted-426.0 ± 0%26.0 ± 0%~(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-431.0 ± 0%31.0 ± 0%~(all equal)
DecodeJSON/FlowFees.FeesDeducted-4126 ± 0%126 ± 0%~(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-471.0 ± 0%71.0 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4102 ± 0%102 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4159 ± 0%159 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-470.0 ± 0%70.0 ± 0%~(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-487.0 ± 0%87.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited-495.0 ± 0%95.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-486.0 ± 0%86.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensMinted-471.0 ± 0%71.0 ± 0%~(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-495.0 ± 0%95.0 ± 0%~(all equal)
EncodeBatchEventsCCF-4950k ± 0%950k ± 0%~(p=1.000 n=1+1)
EncodeBatchEventsJSON-4853k ± 0%853k ± 0%~(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-419.0 ± 0%19.0 ± 0%~(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-419.0 ± 0%19.0 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-419.0 ± 0%19.0 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-419.0 ± 0%19.0 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-419.0 ± 0%19.0 ± 0%~(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-419.0 ± 0%19.0 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited-420.0 ± 0%20.0 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-420.0 ± 0%20.0 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensMinted-419.0 ± 0%19.0 ± 0%~(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-420.0 ± 0%20.0 ± 0%~(all equal)
EncodeJSON/FlowFees.FeesDeducted-419.0 ± 0%19.0 ± 0%~(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-412.0 ± 0%12.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-416.0 ± 0%16.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-425.0 ± 0%25.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-412.0 ± 0%12.0 ± 0%~(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-415.0 ± 0%15.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited-419.0 ± 0%19.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-414.0 ± 0%14.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensMinted-413.0 ± 0%13.0 ± 0%~(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-418.0 ± 0%18.0 ± 0%~(all equal)
ExportType/composite_type-43.00 ± 0%3.00 ± 0%~(all equal)
ExportType/simple_type-40.00 0.00 ~(all equal)
InterpretRecursionFib-418.9k ± 0%18.9k ± 0%~(all equal)
NewInterpreter/new_interpreter-415.0 ± 0%15.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-44.00 ± 0%4.00 ± 0%~(all equal)
ParseArray-459.6k ± 0%59.6k ± 0%~(p=1.000 n=1+1)
ParseDeploy/byte_array-489.5k ± 0%89.4k ± 0%~(p=1.000 n=1+1)
ParseDeploy/decode_hex-463.0 ± 0%63.0 ± 0%~(all equal)
ParseFungibleToken/With_memory_metering-4778 ± 0%778 ± 0%~(all equal)
ParseFungibleToken/Without_memory_metering-4778 ± 0%778 ± 0%~(all equal)
ParseInfix-448.0 ± 0%48.0 ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-40.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-42.00 ± 0%2.00 ± 0%~(all equal)
RuntimeScriptNoop-451.0 ± 0%51.0 ± 0%~(all equal)
SuperTypeInference/arrays-43.00 ± 0%3.00 ± 0%~(all equal)
SuperTypeInference/composites-40.00 0.00 ~(all equal)
SuperTypeInference/integers-40.00 0.00 ~(all equal)
ValueIsSubtypeOfSemaType-41.00 ± 0%1.00 ± 0%~(all equal)
 

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (787812f) 80.02% compared to head (934aa05) 80.05%.

Files Patch % Lines
runtime/literal.go 60.00% 8 Missing and 4 partials ⚠️
runtime/ast/block.go 80.00% 4 Missing ⚠️
runtime/ast/position.go 0.00% 3 Missing ⚠️
runtime/stdlib/account.go 85.71% 1 Missing and 1 partial ⚠️
runtime/stdlib/random.go 88.88% 1 Missing and 1 partial ⚠️
runtime/ast/conditionkind.go 85.71% 1 Missing ⚠️
runtime/convertValues.go 0.00% 0 Missing and 1 partial ⚠️
runtime/sema/type_tags.go 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #2964      +/-   ##
==========================================================
+ Coverage                   80.02%   80.05%   +0.03%     
==========================================================
  Files                         344      342       -2     
  Lines                       81583    81696     +113     
==========================================================
+ Hits                        65284    65402     +118     
+ Misses                      13989    13977      -12     
- Partials                     2310     2317       +7
Flag Coverage Δ
unittests 80.05% <89.60%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SupunS
SupunS commented Dec 5, 2023
View reviewed changes
@SupunS SupunS force-pushed the supun/sc-sync-master branch from c312886 to 934aa05 Compare December 5, 2023 00:44
@SupunS SupunS marked this pull request as ready for review December 5, 2023 00:52
@turbolent turbolent added the Chore label Dec 5, 2023
turbolent
turbolent approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you for adding the comments with the reasoning for (re)moving the test cases 🙏

@SupunS SupunS merged commit e132ddb into feature/stable-cadence Dec 5, 2023
@SupunS SupunS deleted the supun/sc-sync-master branch December 5, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@dsainati1 dsainati1 dsainati1 approved these changes

Assignees

@SupunS SupunS

Labels
Chore Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SupunS @turbolent @dsainati1 @darkdrag00nv2 @m-Peter @bluesign