-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow InclusiveRange<T> if T is a non-leaf integer #2959
Disallow InclusiveRange<T> if T is a non-leaf integer #2959
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/range-type #2959 +/- ##
======================================================
- Coverage 79.63% 79.61% -0.02%
======================================================
Files 336 336
Lines 79754 79813 +59
======================================================
+ Hits 63511 63547 +36
- Misses 13875 13894 +19
- Partials 2368 2372 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Co-authored-by: Bastian Müller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Closes #2885
Description
Disallow InclusiveRange if T is a non-leaf integer. At the moment, the two non-leaf integer types are -
Integer
andSignedInteger
.master
branchFiles changed
in the Github PR explorer