Make checkParameterizedTypeIsInstantiated recursive #2915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdrag00nv2
requested review from
turbolent,
SupunS and
dsainati1
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/range-type #2915 +/- ##
======================================================
+ Coverage 79.61% 79.64% +0.02%
======================================================
Files 336 336
Lines 79813 79858 +45
======================================================
+ Hits 63547 63600 +53
+ Misses 13894 13886 -8
Partials 2372 2372
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Somehow CI is complaining about data race in tests. Need to check that but the PR can be looked at in the meantime. |
turbolent
reviewed
Nov 10, 2023
turbolent
reviewed
Nov 10, 2023
darkdrag00nv2
commented
Dec 2, 2023
turbolent
approved these changes
Dec 4, 2023
|
@dsainati1 Could you please also have a look? |
darkdrag00nv2
commented
Dec 8, 2023
Co-authored-by: Bastian Müller <[email protected]>
darkdrag00nv2
force-pushed
the
range_type_check_parameterized_type_recursive
branch
from
f25769a
to
70e16fa
Compare
darkdrag00nv2
force-pushed
the
range_type_check_parameterized_type_recursive
branch
from
70e16fa
to
3bd5990
Compare
darkdrag00nv2
deleted the
range_type_check_parameterized_type_recursive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2884
Description
This PR makes the checker function
checkParameterizedTypeIsInstantiatedrecursive so that a non-instantiated type parameter is caught even if it is inside a container.See linked issue for more.
masterbranchFiles changedin the Github PR explorer