-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying a mapping with source paths for locations in coverage reports #2859
Allow specifying a mapping with source paths for locations in coverage reports #2859
Conversation
…in coverage reports Having AddressLocation or StringLocation in coverage reports, is not usable when trying to use these reports with standard tools, such as LCOV.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2859 +/- ##
==========================================
+ Coverage 79.38% 79.41% +0.02%
==========================================
Files 334 334
Lines 78826 78930 +104
==========================================
+ Hits 62576 62680 +104
+ Misses 13944 13943 -1
- Partials 2306 2307 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! Only have one concern regarding location clashes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Nice! |
Description
Having
AddressLocation
orStringLocation
in coverage reports, is not usable when trying to use these reports with standard tools, such asLCOV
. The file path is what is needed to exploit the existing tools dealing with theLCOV
format.The
flow.json
config file, already defines the source file for all contracts involved in a dApp, e.g.:master
branchFiles changed
in the Github PR explorer