Sync feature/range-type branch with master

.github/workflows/benchmark.yml

@@ -13,7 +13,7 @@ on:
       - 'v**'
 
 env:
-  GO_VERSION: '1.19.2'
+  GO_VERSION: '1.20'
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}

.github/workflows/ci.yml

@@ -13,7 +13,7 @@ on:
       - 'v**'
 
 env:
-  GO_VERSION: '1.19.2'
+  GO_VERSION: '1.20'
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}

.github/workflows/codeql-analysis.yml

@@ -13,7 +13,7 @@ on:
       - 'v**'
 
 env:
-  GO_VERSION: '1.19.2'
+  GO_VERSION: '1.20'
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}

.github/workflows/compatibility-check-template.yml

@@ -21,7 +21,7 @@ on:
         type: string
 
 env:
-  GO_VERSION: '1.19.2'
+  GO_VERSION: '1.20'
 
 concurrency:
   group: ${{ github.workflow }}-${{ inputs.base-branch || github.run_id }}-${{ inputs.chain }}
@@ -113,6 +113,5 @@ jobs:
       # Check Diff
 
       - name: Check diff
-        working-directory: ./tools/compatibility-check
         run: |
-          go run ./cmd/check_diff/main.go ../../tmp/output-old.txt ../../tmp/output-new.txt
+          diff -u --color ./tmp/output-old.txt ./tmp/output-new.txt

.github/workflows/compatibility-check.yml

@@ -23,7 +23,7 @@ on:
       - 'v**'
 
 env:
-  GO_VERSION: '1.19.2'
+  GO_VERSION: '1.20'
 
 concurrency:
   group: ${{ github.workflow }}-${{ inputs.base || github.run_id }}
@@ -53,7 +53,7 @@ jobs:
             echo "branch=`(echo "${{ github.event.pull_request.head.sha }}")`" >> $GITHUB_OUTPUT
             echo "base=`(echo "${{ github.base_ref }}")`" >> $GITHUB_OUTPUT
           else
-            echo "repo=`(echo "${{ inputs.repo || 'onflow/cadence' }}")`" >> $GITHUB_OUTPUT
+            echo "repo=`(echo "${{ inputs.repo || github.repository }}")`" >> $GITHUB_OUTPUT
             echo "branch=`(echo "${{ inputs.branch }}")`" >> $GITHUB_OUTPUT
             echo "base=`(echo "${{ inputs.base }}")`" >> $GITHUB_OUTPUT
           fi

.github/workflows/downstream.yml

@@ -13,7 +13,7 @@ on:
       - 'v**'
 
 env:
-  GO_VERSION: '1.19.2'
+  GO_VERSION: '1.20'
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
@@ -39,7 +39,7 @@ jobs:
         run: sh crypto_setup.sh
 
       - name: Update Cadence
-        run: go mod edit -replace github.com/onflow/cadence=github.com/${{ github.event.pull_request.head.repo.full_name }}@${{ github.event.pull_request.head.sha }}
+        run: go mod edit -replace github.com/onflow/cadence=github.com/${{ github.event.pull_request.head.repo.full_name || github.repository }}@${{ github.event.pull_request.head.sha || github.sha }}
 
       - name: Tidy up
         run: go mod tidy
@@ -63,7 +63,7 @@ jobs:
           cache: true
 
       - name: Update Cadence
-        run: go mod edit -replace github.com/onflow/cadence=github.com/${{ github.event.pull_request.head.repo.full_name }}@${{ github.event.pull_request.head.sha }}
+        run: go mod edit -replace github.com/onflow/cadence=github.com/${{ github.event.pull_request.head.repo.full_name || github.repository }}@${{ github.event.pull_request.head.sha || github.sha }}
 
       - name: Tidy up
         run: go mod tidy

.github/workflows/release.yml

@@ -20,7 +20,7 @@ on:
         default: 'master'
 
 env:
-  GO_VERSION: '1.19.2'
+  GO_VERSION: '1.20'
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}

encoding/json/decode.go

@@ -301,7 +301,7 @@ func (d *Decoder) decodeAddress(valueJSON any) cadence.Address {
 	actualPrefix := v[:prefixLength]
 	if actualPrefix != addressPrefix {
 		panic(errors.NewDefaultUserError(
-			"invalid address prefix: expected `%s`, got `%s`",
+			"invalid address prefix: (shown as hex) expected %x, got %x", // hex encoding user input (actualPrefix) avoids invalid UTF-8.
 			addressPrefix,
 			actualPrefix,
 		))

encoding/json/encoding_test.go

@@ -197,6 +197,16 @@ func TestEncodeAddress(t *testing.T) {
 	)
 }
 
+func TestDecodeInvalidAddress(t *testing.T) {
+
+	t.Parallel()
+
+	msg := `{"type":"Address","value":"000000000102030405"}`
+
+	_, err := json.Decode(nil, []byte(msg))
+	require.ErrorContains(t, err, "invalid address prefix: (shown as hex) expected 3078, got 3030")
+}
+
 func TestEncodeInt(t *testing.T) {
 
 	t.Parallel()

go.cap

@@ -10,3 +10,4 @@ github.com/stretchr/testify/require (network)
 github.com/texttheater/golang-levenshtein/levenshtein (file)
 github.com/zeebo/blake3/internal/consts (file)
 golang.org/x/xerrors (runtime)
+github.com/onflow/cadence/runtime/interpreter (runtime)

go.mod

@@ -1,6 +1,6 @@
 module github.com/onflow/cadence
 
-go 1.18
+go 1.20
 
 require (
 	github.com/bits-and-blooms/bitset v1.5.0

meetings/2023-08-15.md

@@ -0,0 +1,167 @@
+# Aug 14th, 2023
+
+## Ways to contribute
+
+* Participate in [FLIP (Flow Improvement Proposal) discussions](https://github.com/onflow/flips)
+* Contribute to Cadence implementation: ➡️[GitHub issues](https://github.com/onflow/cadence/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A%22Good+First+Issue%22)
+* Contribute Cadence tools: ➡️[GitHub issues](https://github.com/onflow/cadence-tools/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A%22Good+First+Issue%22)
+
+## FLIPs
+
+### Interface Conformance Improvements
+
+* FLIP: [https://github.com/onflow/flips/pull/83](https://github.com/onflow/flips/pull/83)
+* Status:
+    * FLIP approved and merged 🎉
+
+### Remove pub, pub(set) and priv
+
+* FLIP: [https://github.com/onflow/flips/pull/84](https://github.com/onflow/flips/pull/84)
+* Status:
+    * FLIP approved and merged 🎉
+
+### Emit events from function conditions, allow concrete events in interfaces
+
+* FLIP: [https://github.com/onflow/flips/pull/111](https://github.com/onflow/flips/pull/111)
+* Status:
+    * FLIP approved and merged 🎉
+
+### Remove restricted types, interface set types
+
+* FLIP: [https://github.com/onflow/flips/pull/85](https://github.com/onflow/flips/pull/85)
+* Status:
+    * FLIP approved and merged 🎉
+
+### Add Range type
+
+* FLIP: [https://github.com/onflow/flips/pull/96](https://github.com/onflow/flips/pull/96)
+* Status:
+    * FLIP approved and merged 🎉
+
+### External Mutability
+
+* Vision: [https://github.com/onflow/flips/pull/97](https://github.com/onflow/flips/pull/97)
+* FLIPs:
+    * **Change member access semantic**
+        * FLIP: [https://github.com/onflow/flips/pull/89](https://github.com/onflow/flips/pull/89)
+        * Status:
+            * FLIP approved and merged 🎉
+    * **Improve entitlement mappings**
+        * FLIP: [https://github.com/onflow/flips/pull/94](https://github.com/onflow/flips/pull/94)
+        * Status:
+            * FLIP approved and merged 🎉
+    * **Introduce built-in mutability entitlements**
+        * FLIP: [https://github.com/onflow/flips/pull/86](https://github.com/onflow/flips/pull/86)
+        * Status:
+            * Positive sentiment
+            * No new feedback in last few weeks
+            * Implementation and documentation ready
+            * Last conversation was about naming convention for entitlements
+        * Open problems:
+            * None
+        * Next steps:
+            * **Approved**
+
+### Account Type
+
+* FLIP: [https://github.com/onflow/flips/pull/92](https://github.com/onflow/flips/pull/92)
+* Status:
+    * Positive sentiment
+    * No new feedback in last few weeks
+    * Implementation ready
+* Open problems:
+    * None
+* Next steps:
+    * **Approved**
+
+### Remove nested type requirements
+
+* FLIP: [https://github.com/onflow/flips/pull/118](https://github.com/onflow/flips/pull/118)
+* Overview:
+    * Remove nested type requirements
+    * Allow declaration of events in interfaces as concrete types (used in core contracts)
+* Status:
+    * Positive sentiment
+    * No new feedback in last few weeks
+    * Implementation ready (2 PRs)
+* Open problems:
+    * None
+* Next steps:
+    * **Approved**
+
+### Random function
+
+* FLIP: [https://github.com/onflow/flips/pull/118](https://github.com/onflow/flips/pull/118)
+* Overview:
+    * Rename unsafeRandom to random, underlying implementation has been secured using Flow protocol native random beacon
+    * Update the interface to a safer and more convenient one (generalized types and a modulo parameter)
+    * Rollout: add random, deprecate unsafeRandom, finally remove in SC release
+* Status:
+    * Positive sentiment for random
+* Open problems:
+    * Behavior in scripts
+        * Should not panic
+        * Several options
+    * Naming:
+        * Potential for misuse by developers. Unsafe → safe renaming might be confusing
+        * Maybe addressed by commit-reveal scheme FLIP: [https://github.com/onflow/flips/pull/123](https://github.com/onflow/flips/pull/123)
+* Next steps:
+    * Determine script behavior, maybe propose in separate FLIP
+    * Schedule breakout session
+        * Deniz
+        * You? Leave a comment!
+* Feedback:
+    * Just switch unsafeRandom to safe random generator for now
+    * Different name/indicator to prevent misuse?
+        * Trigger developers to check documentation, see/use commit-reveal scheme design pattern to use returned safe random properly
+        * `random(iReadTheDocs: Bool)`
+    * Our bar is very high, other systems isn't
+
+### Commit-reveal scheme for non-reverted randomness
+
+* FLIP: [https://github.com/onflow/flips/pull/123](https://github.com/onflow/flips/pull/123)
+* Overview:
+    * Provide a safe pattern to address transaction abortion after a random is revealed
+    * Commit to block
+    * In the future, query history of past randoms
+    * Use past, committed seed for new random
+* Status:
+    * Positive sentiment
+    * Waiting for feedback
+* Open problems:
+    * None
+* Next steps:
+    * Gather more feedback
+
+### Remove custom destructors
+
+* FLIP:  [https://github.com/onflow/flips/pull/131](https://github.com/onflow/flips/pull/131)
+* Overview:
+    * Proposal to address inability for users to destroy resources they own
+    * One of the discussed options (others: try/catch, etc.)
+    * Originated from attachments feature (attachment might prevent destruction of whole resource)
+    * Remove destroy
+    * Allows users to always destroy resources
+* Status:
+    * New
+    * Very much an RFC!
+* Open problems:
+    * Philosophical question (sending to "burner account")
+    * Existing code / applications
+    * "Migration" path for use-cases like FT total supply
+* Next steps:
+    * Discuss
+    * Breakout session
+        * You? Leave a comment!
+    * Publish resource destruction options document, add to FLIP
+* Feedback:
+    * Provide details on impact on applications, e.g. core contracts like FT/NFT
+        * Chicken-and-egg problem: need more data on how feature is used, can then figure out if/what alternative is
+    * Even if exploit vector isn’t used today, it should be addressed/prevented
+    * If important use-case exists, also not worth it to remove
+    * Emitting events could maybe be allowed
+    * Given impact, reach out to more developers / gather more feedback
+
+## Related FLIPs / forum discussions
+
+* [https://forum.onflow.org/t/storage-fees-improvements-and-few-random-ideas-on-the-way/5104](https://forum.onflow.org/t/storage-fees-improvements-and-few-random-ideas-on-the-way/5104)

npm-packages/cadence-parser/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@onflow/cadence-parser",
-  "version": "0.39.12",
+  "version": "0.40.0",
   "description": "The Cadence parser",
   "homepage": "https://github.com/onflow/cadence",
   "repository": {

runtime/account_test.go

@@ -2361,7 +2361,7 @@ func TestGetAuthAccount(t *testing.T) {
 
 		errs := checker.RequireCheckerErrors(t, err, 1)
 
-		assert.IsType(t, &sema.ArgumentCountError{}, errs[0])
+		assert.IsType(t, &sema.InsufficientArgumentsError{}, errs[0])
 	})
 
 	t.Run("too many args", func(t *testing.T) {
@@ -2388,7 +2388,7 @@ func TestGetAuthAccount(t *testing.T) {
 		)
 		errs := checker.RequireCheckerErrors(t, err, 1)
 
-		assert.IsType(t, &sema.ArgumentCountError{}, errs[0])
+		assert.IsType(t, &sema.ExcessiveArgumentsError{}, errs[0])
 	})
 
 	t.Run("transaction", func(t *testing.T) {