-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge attachments to master #2365
Conversation
Co-authored-by: Naomi Liu <[email protected]>
… into sainati/attachments-checking
… into sainati/attachments-checking
Merge master into feature/attachments
…sainati/attachments-defensive-checks
…low/cadence into sainati/attachments-feature-flag
Co-authored-by: Bastian Müller <[email protected]>
…ecks Add defensive check for adding and removing attachments
Attachments Feature Flag
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 1aa324e Collapsed results for better readability
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Fantastic work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 👏
Now that attachments is feature-flagged, merge the feature branch to master
master
branchFiles changed
in the Github PR explorer