Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge attachments to master #2365

Merged
merged 217 commits into from
Mar 2, 2023
Merged

Merge attachments to master #2365

merged 217 commits into from
Mar 2, 2023

Conversation

dsainati1
Copy link
Contributor

Now that attachments is feature-flagged, merge the feature branch to master


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

dsainati1 and others added 30 commits August 29, 2022 15:01
@dsainati1 dsainati1 self-assigned this Mar 2, 2023
@dsainati1 dsainati1 marked this pull request as ready for review March 2, 2023 17:47
@dsainati1 dsainati1 enabled auto-merge March 2, 2023 17:47
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 1aa324e
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
CheckContractInterfaceFungibleTokenConformance-2108µs ± 0%111µs ± 0%~(p=1.000 n=1+1)
ContractInterfaceFungibleToken-237.0µs ± 0%38.1µs ± 0%~(p=1.000 n=1+1)
ExportType/composite_type-2325ns ± 0%477ns ± 0%~(p=1.000 n=1+1)
ExportType/simple_type-252.6ns ± 0%56.7ns ± 0%~(p=1.000 n=1+1)
InterpretRecursionFib-22.74ms ± 0%2.44ms ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_interpreter-21.07µs ± 0%1.09µs ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-2568ns ± 0%573ns ± 0%~(p=1.000 n=1+1)
ParseArray-27.56ms ± 0%7.69ms ± 0%~(p=1.000 n=1+1)
ParseDeploy/byte_array-211.5ms ± 0%11.5ms ± 0%~(p=1.000 n=1+1)
ParseDeploy/decode_hex-21.18ms ± 0%1.19ms ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/With_memory_metering-2180µs ± 0%181µs ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/Without_memory_metering-2141µs ± 0%141µs ± 0%~(p=1.000 n=1+1)
ParseInfix-27.06µs ± 0%6.99µs ± 0%~(p=1.000 n=1+1)
QualifiedIdentifierCreation/One_level-22.41ns ± 0%2.41ns ± 0%~(all equal)
QualifiedIdentifierCreation/Three_levels-2117ns ± 0%115ns ± 0%~(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-25.03ms ± 0%5.31ms ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-24.28µs ± 0%4.02µs ± 0%~(p=1.000 n=1+1)
SuperTypeInference/arrays-2286ns ± 0%292ns ± 0%~(p=1.000 n=1+1)
SuperTypeInference/composites-2132ns ± 0%132ns ± 0%~(p=1.000 n=1+1)
SuperTypeInference/integers-292.5ns ± 0%92.9ns ± 0%~(p=1.000 n=1+1)
ValueIsSubtypeOfSemaType-286.0ns ± 0%88.1ns ± 0%~(p=1.000 n=1+1)
 
alloc/opdelta
CheckContractInterfaceFungibleTokenConformance-249.3kB ± 0%48.9kB ± 0%~(p=1.000 n=1+1)
ContractInterfaceFungibleToken-223.2kB ± 0%23.2kB ± 0%~(p=1.000 n=1+1)
ExportType/composite_type-2136B ± 0%136B ± 0%~(all equal)
ExportType/simple_type-20.00B 0.00B ~(all equal)
InterpretRecursionFib-21.00MB ± 0%1.00MB ± 0%~(p=1.000 n=1+1)
NewInterpreter/new_interpreter-2768B ± 0%768B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-2200B ± 0%200B ± 0%~(all equal)
ParseArray-22.65MB ± 0%2.79MB ± 0%~(p=1.000 n=1+1)
ParseDeploy/byte_array-24.26MB ± 0%4.26MB ± 0%~(p=1.000 n=1+1)
ParseDeploy/decode_hex-2214kB ± 0%214kB ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/With_memory_metering-228.7kB ± 0%28.9kB ± 0%~(p=1.000 n=1+1)
ParseFungibleToken/Without_memory_metering-228.7kB ± 0%28.9kB ± 0%~(p=1.000 n=1+1)
ParseInfix-21.92kB ± 0%1.92kB ± 0%~(p=1.000 n=1+1)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
RuntimeResourceDictionaryValues-22.29MB ± 0%2.29MB ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-22.70kB ± 0%2.70kB ± 0%~(all equal)
SuperTypeInference/arrays-296.0B ± 0%96.0B ± 0%~(all equal)
SuperTypeInference/composites-20.00B 0.00B ~(all equal)
SuperTypeInference/integers-20.00B 0.00B ~(all equal)
ValueIsSubtypeOfSemaType-248.0B ± 0%48.0B ± 0%~(all equal)
 
allocs/opdelta
CheckContractInterfaceFungibleTokenConformance-2806 ± 0%806 ± 0%~(all equal)
ContractInterfaceFungibleToken-2370 ± 0%370 ± 0%~(all equal)
ExportType/composite_type-23.00 ± 0%3.00 ± 0%~(all equal)
ExportType/simple_type-20.00 0.00 ~(all equal)
InterpretRecursionFib-218.9k ± 0%18.9k ± 0%~(all equal)
NewInterpreter/new_interpreter-213.0 ± 0%13.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-24.00 ± 0%4.00 ± 0%~(all equal)
ParseArray-259.6k ± 0%59.6k ± 0%~(p=1.000 n=1+1)
ParseDeploy/byte_array-289.4k ± 0%89.4k ± 0%~(p=1.000 n=1+1)
ParseDeploy/decode_hex-263.0 ± 0%63.0 ± 0%~(all equal)
ParseFungibleToken/With_memory_metering-2768 ± 0%768 ± 0%~(all equal)
ParseFungibleToken/Without_memory_metering-2768 ± 0%768 ± 0%~(all equal)
ParseInfix-248.0 ± 0%48.0 ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
RuntimeResourceDictionaryValues-236.9k ± 0%36.9k ± 0%~(p=1.000 n=1+1)
RuntimeScriptNoop-243.0 ± 0%43.0 ± 0%~(all equal)
SuperTypeInference/arrays-23.00 ± 0%3.00 ± 0%~(all equal)
SuperTypeInference/composites-20.00 0.00 ~(all equal)
SuperTypeInference/integers-20.00 0.00 ~(all equal)
ValueIsSubtypeOfSemaType-21.00 ± 0%1.00 ± 0%~(all equal)
 

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Fantastic work!

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏

@dsainati1 dsainati1 merged commit 0f76c23 into master Mar 2, 2023
@dsainati1 dsainati1 deleted the feature/attachments branch March 2, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants