Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fxamacker/cbor and atree to latest versions #1682

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

fxamacker
Copy link
Member

Description

Bump fxamacker/cbor and onflow/atree to latest versions.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #1682 (97fa3e7) into master (56e9997) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1682      +/-   ##
==========================================
- Coverage   76.57%   76.57%   -0.01%     
==========================================
  Files         292      292              
  Lines       61197    61197              
==========================================
- Hits        46864    46862       -2     
- Misses      12720    12722       +2     
  Partials     1613     1613              
Flag Coverage Δ
unittests 76.57% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/interpreter/storage.go 69.04% <0.00%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56e9997...97fa3e7. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 56e9997
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
CheckContractInterfaceFungibleTokenConformance-2132µs ± 2%133µs ± 2%~(p=0.445 n=6+7)
ContractInterfaceFungibleToken-239.8µs ± 2%41.0µs ± 8%~(p=0.268 n=5+7)
InterpretRecursionFib-22.91ms ± 3%2.84ms ± 2%~(p=0.132 n=6+6)
NewInterpreter/new_interpreter-21.10µs ± 1%1.10µs ± 2%~(p=0.599 n=6+7)
NewInterpreter/new_sub-interpreter-22.22µs ± 1%2.27µs ± 5%~(p=0.421 n=6+7)
ParseArray-28.32ms ± 2%8.54ms ± 5%~(p=0.165 n=7+7)
ParseDeploy/byte_array-212.6ms ± 2%12.6ms ± 1%~(p=0.699 n=6+6)
ParseDeploy/decode_hex-21.15ms ± 0%1.15ms ± 0%~(p=0.589 n=6+6)
ParseFungibleToken/With_memory_metering-2207µs ± 1%208µs ± 1%~(p=0.792 n=5+6)
ParseFungibleToken/Without_memory_metering-2159µs ± 3%158µs ± 1%~(p=0.875 n=7+7)
ParseInfix-27.53µs ± 4%7.61µs ± 1%~(p=0.383 n=7+7)
QualifiedIdentifierCreation/One_level-22.34ns ± 0%2.35ns ± 0%~(p=0.557 n=6+7)
QualifiedIdentifierCreation/Three_levels-2134ns ± 2%135ns ± 2%~(p=0.531 n=6+7)
RuntimeFungibleTokenTransfer-21.35ms ±26%1.34ms ±24%~(p=1.000 n=7+7)
RuntimeResourceDictionaryValues-26.72ms ± 1%6.73ms ± 5%~(p=0.805 n=7+7)
Transfer-288.7ns ± 0%90.6ns ± 2%+2.16%(p=0.004 n=5+6)
 
alloc/opdelta
CheckContractInterfaceFungibleTokenConformance-266.3kB ± 0%66.3kB ± 0%~(p=0.636 n=5+7)
ContractInterfaceFungibleToken-226.7kB ± 0%26.7kB ± 0%~(p=0.140 n=6+7)
InterpretRecursionFib-21.25MB ± 0%1.25MB ± 0%~(p=0.385 n=6+7)
NewInterpreter/new_interpreter-2872B ± 0%872B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.38kB ± 0%1.38kB ± 0%~(all equal)
ParseArray-22.95MB ± 1%2.95MB ± 2%~(p=1.000 n=7+7)
ParseDeploy/byte_array-24.30MB ± 2%4.39MB ± 1%+2.12%(p=0.014 n=7+6)
ParseDeploy/decode_hex-2213kB ± 0%213kB ± 0%~(p=0.773 n=7+7)
ParseFungibleToken/With_memory_metering-236.3kB ± 0%36.3kB ± 0%−0.04%(p=0.042 n=7+6)
ParseFungibleToken/Without_memory_metering-236.3kB ± 0%36.3kB ± 0%~(p=0.294 n=7+7)
ParseInfix-22.17kB ± 0%2.17kB ± 0%~(p=1.000 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
RuntimeFungibleTokenTransfer-2237kB ± 0%237kB ± 0%~(p=0.383 n=7+7)
RuntimeResourceDictionaryValues-22.24MB ± 0%2.24MB ± 0%~(p=0.805 n=7+7)
Transfer-248.0B ± 0%48.0B ± 0%~(all equal)
 
allocs/opdelta
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
ContractInterfaceFungibleToken-2460 ± 0%460 ± 0%~(all equal)
InterpretRecursionFib-223.8k ± 0%23.8k ± 0%~(all equal)
NewInterpreter/new_interpreter-212.0 ± 0%12.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-240.0 ± 0%40.0 ± 0%~(all equal)
ParseArray-270.0k ± 0%70.0k ± 0%~(p=0.592 n=7+7)
ParseDeploy/byte_array-2105k ± 0%105k ± 0%~(p=0.592 n=7+7)
ParseDeploy/decode_hex-279.0 ± 0%79.0 ± 0%~(all equal)
ParseFungibleToken/With_memory_metering-21.06k ± 0%1.06k ± 0%~(all equal)
ParseFungibleToken/Without_memory_metering-21.06k ± 0%1.06k ± 0%~(all equal)
ParseInfix-266.0 ± 0%66.0 ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
RuntimeFungibleTokenTransfer-24.58k ± 0%4.58k ± 0%~(p=1.000 n=7+7)
RuntimeResourceDictionaryValues-237.6k ± 0%37.6k ± 0%~(p=0.355 n=7+7)
Transfer-21.00 ± 0%1.00 ± 0%~(all equal)
 

@turbolent turbolent merged commit 8b113c5 into master Jun 1, 2022
@turbolent turbolent deleted the fxamacker/bump-atree-cbor-version branch June 1, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants