Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flow-go sync #1645

Merged
merged 1 commit into from
May 11, 2022
Merged

Disable flow-go sync #1645

merged 1 commit into from
May 11, 2022

Conversation

janezpodhostnik
Copy link
Contributor

Description

The flow-go sync action has not been useful for a while now. The reason is that both cadence doesn't use the master branch as the one that is being actively worked on.

Let's disable this for now, and we can see if it can be fixed later.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #1645 (ede8fa0) into master (e5859a1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1645   +/-   ##
=======================================
  Coverage   74.76%   74.76%           
=======================================
  Files         288      288           
  Lines       55386    55386           
=======================================
  Hits        41408    41408           
  Misses      12483    12483           
  Partials     1495     1495           
Flag Coverage Δ
unittests 74.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5859a1...ede8fa0. Read the comment docs.

@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit e5859a1
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
Transfer-278.9ns ± 1%79.5ns ± 1%+0.78%(p=0.024 n=6+7)
RuntimeFungibleTokenTransfer-21.22ms ±22%1.23ms ±21%~(p=0.620 n=7+7)
RuntimeResourceDictionaryValues-26.12ms ± 3%6.16ms ± 2%~(p=0.945 n=6+7)
ParseInfix-28.00µs ± 2%7.95µs ± 0%~(p=0.234 n=7+6)
ParseDeploy/byte_array-219.8ms ± 2%19.7ms ± 3%~(p=0.485 n=6+6)
ParseDeploy/decode_hex-21.09ms ± 1%1.09ms ± 1%~(p=0.456 n=7+7)
ParseFungibleToken-2169µs ± 1%168µs ± 1%~(p=0.181 n=7+6)
ParseArray-212.5ms ±11%12.9ms ± 8%~(p=0.128 n=7+7)
QualifiedIdentifierCreation/One_level-22.22ns ± 7%2.18ns ± 7%~(p=0.737 n=7+7)
ContractInterfaceFungibleToken-236.9µs ± 2%36.9µs ± 3%~(p=0.836 n=7+6)
CheckContractInterfaceFungibleTokenConformance-2124µs ± 7%126µs ± 5%~(p=0.535 n=7+7)
NewInterpreter/new_interpreter-21.06µs ± 2%1.06µs ± 1%~(p=0.383 n=6+7)
NewInterpreter/new_sub-interpreter-22.07µs ± 1%2.11µs ± 5%~(p=0.781 n=7+7)
InterpretRecursionFib-22.60ms ± 2%2.55ms ± 3%~(p=0.101 n=6+7)
QualifiedIdentifierCreation/Three_levels-2132ns ± 1%130ns ± 1%−1.55%(p=0.005 n=7+6)
 
alloc/opdelta
RuntimeFungibleTokenTransfer-2273kB ± 0%273kB ± 0%~(p=0.653 n=6+7)
RuntimeResourceDictionaryValues-22.25MB ± 0%2.25MB ± 0%~(p=0.534 n=7+6)
Transfer-248.0B ± 0%48.0B ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
ContractInterfaceFungibleToken-226.7kB ± 0%26.7kB ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-266.3kB ± 0%66.3kB ± 0%~(p=1.000 n=7+7)
NewInterpreter/new_interpreter-2848B ± 0%848B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.34kB ± 0%1.34kB ± 0%~(all equal)
InterpretRecursionFib-21.14MB ± 0%1.14MB ± 0%~(p=1.315 n=6+7)
 
allocs/opdelta
RuntimeFungibleTokenTransfer-24.58k ± 0%4.58k ± 0%~(p=1.000 n=7+7)
RuntimeResourceDictionaryValues-237.6k ± 0%37.6k ± 0%~(p=0.401 n=7+6)
Transfer-21.00 ± 0%1.00 ± 0%~(all equal)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
ContractInterfaceFungibleToken-2460 ± 0%460 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
NewInterpreter/new_interpreter-213.0 ± 0%13.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-240.0 ± 0%40.0 ± 0%~(all equal)
InterpretRecursionFib-223.8k ± 0%23.8k ± 0%~(all equal)
 

@janezpodhostnik janezpodhostnik merged commit a73d741 into master May 11, 2022
@janezpodhostnik janezpodhostnik deleted the janez/disable-flow-go-sync branch May 11, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants