Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LS] NPM release v0.24.0 crash reporting #1641

Merged
merged 5 commits into from
May 16, 2022

Conversation

devbugging
Copy link
Contributor

@devbugging devbugging commented May 10, 2022

Closes: #1639

This PR updates the released version on npm that includes the crash reporting. It also improves crash reporting by covering the server init too.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@devbugging devbugging self-assigned this May 10, 2022
@devbugging devbugging changed the title [LS] Crash reporting improvements [LS] NPM release v0.24.0 crash reporting May 10, 2022
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #1641 (a1695e1) into master (e5859a1) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1641      +/-   ##
==========================================
+ Coverage   74.76%   74.78%   +0.02%     
==========================================
  Files         288      288              
  Lines       55386    55418      +32     
==========================================
+ Hits        41408    41444      +36     
+ Misses      12483    12481       -2     
+ Partials     1495     1493       -2     
Flag Coverage Δ
unittests 74.78% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/sema/checker.go 90.37% <0.00%> (-0.12%) ⬇️
runtime/parser2/expression.go 92.80% <0.00%> (-0.01%) ⬇️
runtime/parser2/lexer/tokentype.go 98.37% <0.00%> (+0.08%) ⬆️
runtime/runtime.go 86.98% <0.00%> (+0.10%) ⬆️
runtime/parser2/lexer/lexer.go 96.15% <0.00%> (+0.20%) ⬆️
runtime/parser2/parser.go 90.64% <0.00%> (+0.39%) ⬆️
runtime/parser2/type.go 88.73% <0.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5859a1...a1695e1. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 10, 2022

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit e5859a1
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
CheckContractInterfaceFungibleTokenConformance-2131µs ± 1%130µs ± 3%~(p=0.209 n=7+7)
ContractInterfaceFungibleToken-239.2µs ± 1%39.1µs ± 1%~(p=0.456 n=7+7)
InterpretRecursionFib-22.73ms ± 2%2.70ms ± 2%~(p=0.165 n=7+7)
NewInterpreter/new_interpreter-21.13µs ± 1%1.14µs ± 0%+0.43%(p=0.033 n=7+7)
NewInterpreter/new_sub-interpreter-22.19µs ± 1%2.21µs ± 0%~(p=0.050 n=7+7)
ParseArray-212.8ms ± 1%7.5ms ± 1%−41.67%(p=0.001 n=7+7)
ParseDeploy/byte_array-220.7ms ± 2%11.2ms ± 0%−46.08%(p=0.001 n=7+6)
ParseDeploy/decode_hex-21.16ms ± 1%1.16ms ± 1%~(p=0.318 n=7+7)
ParseFungibleToken-2181µs ± 2%139µs ± 0%−23.24%(p=0.002 n=6+6)
ParseInfix-28.40µs ± 1%6.53µs ± 1%−22.30%(p=0.001 n=7+7)
QualifiedIdentifierCreation/One_level-22.34ns ± 0%2.34ns ± 0%~(p=1.000 n=7+7)
QualifiedIdentifierCreation/Three_levels-2140ns ± 1%140ns ± 0%~(p=1.000 n=7+7)
RuntimeFungibleTokenTransfer-21.29ms ±21%1.15ms ±30%~(p=0.128 n=7+7)
RuntimeResourceDictionaryValues-26.35ms ± 1%6.43ms ± 3%~(p=0.268 n=5+7)
Transfer-284.2ns ± 1%84.5ns ± 1%~(p=0.509 n=7+6)
 
alloc/opdelta
CheckContractInterfaceFungibleTokenConformance-266.3kB ± 0%66.3kB ± 0%~(p=0.303 n=5+7)
ContractInterfaceFungibleToken-226.7kB ± 0%26.7kB ± 0%~(p=1.000 n=7+7)
InterpretRecursionFib-21.14MB ± 0%1.14MB ± 0%~(p=1.000 n=7+7)
NewInterpreter/new_interpreter-2848B ± 0%848B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.34kB ± 0%1.34kB ± 0%~(all equal)
ParseArray-213.5MB ± 0%2.9MB ± 1%−78.24%(p=0.001 n=7+7)
ParseDeploy/byte_array-221.0MB ± 0%4.3MB ± 2%−79.69%(p=0.001 n=7+7)
ParseDeploy/decode_hex-2218kB ± 0%213kB ± 0%−2.09%(p=0.001 n=7+7)
ParseFungibleToken-2199kB ± 0%36kB ± 0%−81.77%(p=0.001 n=7+7)
ParseInfix-26.76kB ± 0%2.12kB ± 0%−68.64%(p=0.001 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
RuntimeFungibleTokenTransfer-2273kB ± 0%234kB ± 0%−14.37%(p=0.001 n=7+7)
RuntimeResourceDictionaryValues-22.25MB ± 0%2.24MB ± 0%−0.60%(p=0.001 n=7+7)
Transfer-248.0B ± 0%48.0B ± 0%~(all equal)
 
allocs/opdelta
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
ContractInterfaceFungibleToken-2460 ± 0%460 ± 0%~(all equal)
InterpretRecursionFib-223.8k ± 0%23.8k ± 0%~(all equal)
NewInterpreter/new_interpreter-213.0 ± 0%13.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-240.0 ± 0%40.0 ± 0%~(all equal)
ParseArray-270.0k ± 0%70.0k ± 0%−0.05%(p=0.001 n=7+7)
ParseDeploy/byte_array-2105k ± 0%105k ± 0%−0.02%(p=0.001 n=7+7)
ParseDeploy/decode_hex-286.0 ± 0%79.0 ± 0%−8.14%(p=0.001 n=7+7)
ParseFungibleToken-21.07k ± 0%1.06k ± 0%−1.12%(p=0.001 n=7+7)
ParseInfix-273.0 ± 0%66.0 ± 0%−9.59%(p=0.001 n=7+7)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
RuntimeFungibleTokenTransfer-24.58k ± 0%4.57k ± 0%−0.20%(p=0.001 n=7+7)
RuntimeResourceDictionaryValues-237.6k ± 0%37.6k ± 0%−0.02%(p=0.001 n=7+7)
Transfer-21.00 ± 0%1.00 ± 0%~(all equal)
 

@devbugging devbugging closed this May 13, 2022
@devbugging devbugging reopened this May 16, 2022
@devbugging devbugging merged commit bddd08f into master May 16, 2022
@devbugging devbugging deleted the ls/improvement/crash-report-fix branch May 16, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update LS on NPM to include crash reporting
2 participants