cadence.Value.Type method back to original param list

[robert-e-davidson3]

Closes https://github.com/dapperlabs/cadence-private-issues/issues/46

Description

The SDK etc use the cadence.Value and cadence.Type types. This PR undoes a change to the cadence.Value.Type method so the API will remain unchanged in the next Cadence release.

The cadence.Value.MeteredType method was added for when memory metering is needed.

Another change: I added compile-time interface type checking for the cadence.Value types. ex: var _ Value = Void{}.

---

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work
• Code follows the standards mentioned here
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

[codecov]

Codecov Report

Merging #1633 (917e839) into feature/memory-metering (7cb1f67) will decrease coverage by 0.26%.
The diff coverage is 47.39%.

@@                     Coverage Diff                     @@
##           feature/memory-metering    #1633      +/-   ##
===========================================================
- Coverage                    76.62%   76.36%   -0.27%     
===========================================================
  Files                          291      291              
  Lines                        60092    60452     +360     
===========================================================
+ Hits                         46046    46163     +117     
- Misses                       12439    12678     +239     
- Partials                      1607     1611       +4     

Flag	Coverage Δ
unittests	76.36% <47.39%> (-0.27%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
runtime/convertTypes.go	61.50% <29.68%> (-14.90%)	⬇️
values.go	65.90% <34.11%> (-6.56%)	⬇️
encoding/json/decode.go	77.54% <41.02%> (+0.02%)	⬆️
types.go	78.20% <74.05%> (-1.52%)	⬇️
runtime/convertValues.go	78.18% <100.00%> (ø)
runtime/literal.go	86.29% <100.00%> (ø)
runtime/runtime.go	86.40% <100.00%> (ø)
runtime/sema/simple_type.go	92.30% <0.00%> (-3.85%)	⬇️
runtime/sema/check_unary_expression.go	91.22% <0.00%> (-0.30%)	⬇️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb1f67...917e839. Read the comment docs.

[github-actions]

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/memory-metering commit 33cd9e0
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

	old.txt	new.txt
	time/op		delta
RuntimeFungibleTokenTransfer-2	1.52ms ±22%	1.46ms ±30%	~	(p=0.805 n=7+7)
RuntimeResourceDictionaryValues-2	7.91ms ± 4%	7.93ms ± 1%	~	(p=0.383 n=7+7)
Transfer-2	100ns ± 2%	99ns ± 3%	~	(p=0.272 n=7+7)
ParseArray-2	16.6ms ± 9%	15.6ms ± 2%	~	(p=0.234 n=7+6)
ParseFungibleToken/Without_memory_metering-2	252µs ± 1%	251µs ± 1%	~	(p=0.937 n=6+6)
ParseFungibleToken/With_memory_metering-2	309µs ± 2%	309µs ± 3%	~	(p=0.836 n=6+7)
ParseDeploy/byte_array-2	24.6ms ± 4%	24.5ms ± 3%	~	(p=1.000 n=6+6)
ParseDeploy/decode_hex-2	1.42ms ± 2%	1.42ms ± 3%	~	(p=0.902 n=7+7)
ParseInfix-2	11.0µs ± 1%	11.1µs ± 8%	~	(p=0.710 n=7+7)
QualifiedIdentifierCreation/One_level-2	3.31ns ± 3%	3.31ns ± 4%	~	(p=0.874 n=7+7)
QualifiedIdentifierCreation/Three_levels-2	170ns ± 1%	170ns ± 1%	~	(p=0.469 n=6+7)
ContractInterfaceFungibleToken-2	48.5µs ± 1%	48.3µs ± 1%	~	(p=0.310 n=6+6)
CheckContractInterfaceFungibleTokenConformance-2	173µs ± 4%	173µs ± 2%	~	(p=0.805 n=7+7)
NewInterpreter/new_interpreter-2	1.35µs ± 2%	1.36µs ± 4%	~	(p=0.710 n=7+7)
NewInterpreter/new_sub-interpreter-2	2.82µs ± 8%	2.69µs ± 3%	~	(p=0.128 n=7+7)
InterpretRecursionFib-2	3.27ms ± 5%	3.24ms ± 4%	~	(p=0.805 n=7+7)
	alloc/op		delta
RuntimeFungibleTokenTransfer-2	276kB ± 0%	276kB ± 0%	~	(p=0.628 n=5+6)
RuntimeResourceDictionaryValues-2	2.25MB ± 0%	2.25MB ± 0%	~	(p=0.181 n=7+6)
Transfer-2	48.0B ± 0%	48.0B ± 0%	~	(all equal)
ParseFungibleToken/Without_memory_metering-2	199kB ± 0%	199kB ± 0%	~	(all equal)
QualifiedIdentifierCreation/One_level-2	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-2	64.0B ± 0%	64.0B ± 0%	~	(all equal)
CheckContractInterfaceFungibleTokenConformance-2	66.3kB ± 0%	66.3kB ± 0%	~	(all equal)
NewInterpreter/new_interpreter-2	888B ± 0%	888B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-2	1.40kB ± 0%	1.40kB ± 0%	~	(all equal)
InterpretRecursionFib-2	1.25MB ± 0%	1.25MB ± 0%	~	(p=0.284 n=7+7)
ParseFungibleToken/With_memory_metering-2	199kB ± 0%	199kB ± 0%	−0.00%	(p=0.042 n=7+6)
ContractInterfaceFungibleToken-2	26.7kB ± 0%	26.7kB ± 0%	−0.00%	(p=0.042 n=7+6)
	allocs/op		delta
RuntimeFungibleTokenTransfer-2	4.59k ± 0%	4.59k ± 0%	~	(p=0.697 n=7+6)
RuntimeResourceDictionaryValues-2	37.6k ± 0%	37.6k ± 0%	~	(p=0.274 n=7+7)
Transfer-2	1.00 ± 0%	1.00 ± 0%	~	(all equal)
ParseFungibleToken/Without_memory_metering-2	1.07k ± 0%	1.07k ± 0%	~	(all equal)
ParseFungibleToken/With_memory_metering-2	1.07k ± 0%	1.07k ± 0%	~	(all equal)
QualifiedIdentifierCreation/One_level-2	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-2	2.00 ± 0%	2.00 ± 0%	~	(all equal)
ContractInterfaceFungibleToken-2	460 ± 0%	460 ± 0%	~	(all equal)
CheckContractInterfaceFungibleTokenConformance-2	1.07k ± 0%	1.07k ± 0%	~	(all equal)
NewInterpreter/new_interpreter-2	13.0 ± 0%	13.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-2	41.0 ± 0%	41.0 ± 0%	~	(all equal)
InterpretRecursionFib-2	23.8k ± 0%	23.8k ± 0%	~	(all equal)

[SupunS]

Looks good!

[SupunS]

Thanks for adding these!