Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language reference docs improvement #1627

Merged
merged 2 commits into from
May 11, 2022
Merged

Conversation

alilloig
Copy link
Member

@alilloig alilloig commented May 6, 2022

Description

· Callout pointing out that Interface implementation requirements is not implemented yet
· Adding missing argument label in accounts get and revoke


  • Targeted PR against master branch
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent
Copy link
Member

@alilloig Thank you for your PR!

Please use the PR template and fill out the checklist that was provided: https://github.com/onflow/cadence/blob/master/.github/pull_request_template.md

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1627 (d32dd77) into master (f615bea) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1627   +/-   ##
=======================================
  Coverage   74.73%   74.73%           
=======================================
  Files         288      288           
  Lines       55340    55340           
=======================================
+ Hits        41357    41359    +2     
+ Misses      12489    12487    -2     
  Partials     1494     1494           
Flag Coverage Δ
unittests 74.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/interpreter/storage.go 72.78% <0.00%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f615bea...d32dd77. Read the comment docs.

@alilloig
Copy link
Member Author

alilloig commented May 6, 2022

@turbolent thanks for the feedback!! I should have avoided that mistake since the templete was already included in the PR but I wasn't sure on how to filling it out. I'm gonna ask for some help to my big sib @joshuahannan and get the PR properly done. Please apologize for the inconvenience I guess I'm still getting familiarized with the workflow.

@joshuahannan joshuahannan added Documentation Improvements or additions to documentation Improvement T-Documentation 📃 labels May 6, 2022
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! First PR!

@alilloig
Copy link
Member Author

alilloig commented May 6, 2022

@turbolent I believe the checklist it's ok now

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! First PR 🎉

Thank you for fixing the examples 👍

@turbolent
Copy link
Member

@alilloig Please feel free to merge

@alilloig
Copy link
Member Author

alilloig commented May 11, 2022

@turbolent Merging is still blocked for me, maybe I'm still lacking some permissions?

@turbolent turbolent merged commit 3672a6c into onflow:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants