-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language reference docs improvement #1627
Conversation
@alilloig Thank you for your PR! Please use the PR template and fill out the checklist that was provided: https://github.com/onflow/cadence/blob/master/.github/pull_request_template.md |
Codecov Report
@@ Coverage Diff @@
## master #1627 +/- ##
=======================================
Coverage 74.73% 74.73%
=======================================
Files 288 288
Lines 55340 55340
=======================================
+ Hits 41357 41359 +2
+ Misses 12489 12487 -2
Partials 1494 1494
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@turbolent thanks for the feedback!! I should have avoided that mistake since the templete was already included in the PR but I wasn't sure on how to filling it out. I'm gonna ask for some help to my big sib @joshuahannan and get the PR properly done. Please apologize for the inconvenience I guess I'm still getting familiarized with the workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! First PR!
@turbolent I believe the checklist it's ok now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! First PR 🎉
Thank you for fixing the examples 👍
@alilloig Please feel free to merge |
@turbolent Merging is still blocked for me, maybe I'm still lacking some permissions? |
Description
· Callout pointing out that Interface implementation requirements is not implemented yet
· Adding missing argument label in accounts get and revoke
master
branchFiles changed
in the Github PR explorer