Improve constant-sized type parsing

[turbolent]

Description

Optimize parsing of the size in constant-sized types by directly checking for an integer literal.

---

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work
• Code follows the standards mentioned here
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

[github-actions]

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit f615bea
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

	old.txt	new.txt
	time/op		delta
CheckContractInterfaceFungibleTokenConformance-2	189µs ± 4%	188µs ± 4%	~	(p=0.836 n=7+6)
ContractInterfaceFungibleToken-2	53.8µs ± 6%	53.5µs ± 7%	~	(p=0.710 n=7+7)
InterpretRecursionFib-2	3.42ms ± 9%	3.37ms ± 7%	~	(p=0.318 n=7+7)
NewInterpreter/new_interpreter-2	1.50µs ± 5%	1.46µs ± 4%	~	(p=0.181 n=7+6)
NewInterpreter/new_sub-interpreter-2	2.94µs ± 5%	2.83µs ± 4%	~	(p=0.053 n=7+7)
ParseArray-2	17.7ms ±11%	9.6ms ± 4%	−46.13%	(p=0.001 n=7+7)
ParseDeploy/byte_array-2	27.2ms ±11%	14.2ms ± 3%	−47.91%	(p=0.001 n=7+6)
ParseDeploy/decode_hex-2	1.54ms ± 7%	1.50ms ± 4%	~	(p=0.383 n=7+7)
ParseFungibleToken-2	254µs ± 3%	184µs ± 4%	−27.54%	(p=0.001 n=7+7)
ParseInfix-2	11.0µs ± 4%	8.3µs ± 3%	−24.11%	(p=0.001 n=7+7)
QualifiedIdentifierCreation/One_level-2	3.40ns ± 5%	3.43ns ± 5%	~	(p=0.620 n=7+7)
QualifiedIdentifierCreation/Three_levels-2	186ns ± 7%	182ns ± 4%	~	(p=0.456 n=7+7)
RuntimeFungibleTokenTransfer-2	1.57ms ±26%	1.49ms ±27%	~	(p=0.165 n=7+7)
RuntimeResourceDictionaryValues-2	8.60ms ± 5%	8.61ms ± 3%	~	(p=1.000 n=7+7)
Transfer-2	114ns ± 7%	111ns ± 5%	~	(p=0.318 n=7+7)
	alloc/op		delta
CheckContractInterfaceFungibleTokenConformance-2	66.3kB ± 0%	66.3kB ± 0%	~	(all equal)
ContractInterfaceFungibleToken-2	26.7kB ± 0%	26.7kB ± 0%	~	(p=1.000 n=7+7)
InterpretRecursionFib-2	1.14MB ± 0%	1.14MB ± 0%	~	(p=0.462 n=7+7)
NewInterpreter/new_interpreter-2	848B ± 0%	848B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-2	1.34kB ± 0%	1.34kB ± 0%	~	(all equal)
ParseArray-2	13.5MB ± 0%	3.0MB ± 2%	−77.98%	(p=0.001 n=7+7)
ParseDeploy/byte_array-2	21.0MB ± 0%	4.3MB ± 3%	−79.43%	(p=0.001 n=7+7)
ParseDeploy/decode_hex-2	218kB ± 0%	213kB ± 0%	−2.07%	(p=0.001 n=7+7)
ParseFungibleToken-2	199kB ± 0%	36kB ± 0%	−81.78%	(p=0.000 n=7+6)
ParseInfix-2	6.76kB ± 0%	2.10kB ± 0%	−68.87%	(p=0.001 n=7+7)
QualifiedIdentifierCreation/One_level-2	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-2	64.0B ± 0%	64.0B ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-2	273kB ± 0%	234kB ± 0%	−14.39%	(p=0.001 n=7+6)
RuntimeResourceDictionaryValues-2	2.25MB ± 0%	2.24MB ± 0%	−0.51%	(p=0.001 n=7+7)
Transfer-2	48.0B ± 0%	48.0B ± 0%	~	(all equal)
	allocs/op		delta
CheckContractInterfaceFungibleTokenConformance-2	1.07k ± 0%	1.07k ± 0%	~	(all equal)
ContractInterfaceFungibleToken-2	460 ± 0%	460 ± 0%	~	(all equal)
InterpretRecursionFib-2	23.8k ± 0%	23.8k ± 0%	~	(all equal)
NewInterpreter/new_interpreter-2	13.0 ± 0%	13.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-2	40.0 ± 0%	40.0 ± 0%	~	(all equal)
ParseArray-2	70.0k ± 0%	70.0k ± 0%	−0.04%	(p=0.003 n=7+5)
ParseDeploy/byte_array-2	105k ± 0%	105k ± 0%	−0.02%	(p=0.003 n=7+5)
ParseDeploy/decode_hex-2	86.0 ± 0%	79.0 ± 0%	−8.14%	(p=0.001 n=7+7)
ParseFungibleToken-2	1.07k ± 0%	1.06k ± 0%	−1.12%	(p=0.001 n=7+7)
ParseInfix-2	73.0 ± 0%	66.0 ± 0%	−9.59%	(p=0.001 n=7+7)
QualifiedIdentifierCreation/One_level-2	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-2	2.00 ± 0%	2.00 ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-2	4.58k ± 0%	4.57k ± 0%	−0.19%	(p=0.001 n=7+7)
RuntimeResourceDictionaryValues-2	37.6k ± 0%	37.6k ± 0%	−0.02%	(p=0.001 n=7+7)
Transfer-2	1.00 ± 0%	1.00 ± 0%	~	(all equal)

[codecov]

Codecov Report

Merging #1613 (882dea6) into master (f615bea) will increase coverage by 0.04%.
The diff coverage is 85.00%.

@@            Coverage Diff             @@
##           master    #1613      +/-   ##
==========================================
+ Coverage   74.73%   74.77%   +0.04%     
==========================================
  Files         288      288              
  Lines       55340    55407      +67     
==========================================
+ Hits        41357    41433      +76     
+ Misses      12489    12481       -8     
+ Partials     1494     1493       -1     

Flag	Coverage Δ
unittests	74.77% <85.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
runtime/parser2/type.go	88.73% <78.57%> (+0.58%)	⬆️
runtime/parser2/lexer/tokentype.go	98.37% <100.00%> (+0.08%)	⬆️
runtime/sema/checker.go	90.37% <0.00%> (-0.12%)	⬇️
runtime/parser2/expression.go	92.80% <0.00%> (-0.01%)	⬇️
runtime/interpreter/value.go	63.66% <0.00%> (+0.03%)	⬆️
runtime/interpreter/interpreter_expression.go	84.70% <0.00%> (+0.08%)	⬆️
runtime/parser2/parser.go	90.33% <0.00%> (+0.08%)	⬆️
runtime/runtime.go	86.98% <0.00%> (+0.10%)	⬆️
runtime/interpreter/interpreter.go	88.88% <0.00%> (+0.17%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f615bea...882dea6. Read the comment docs.

[SupunS]

Thanks for adding the negative literal test. I initially did wonder what would happen for the negative literals, but realized it would still be handled, because the next token is the not the 'literal'. Always nice to have a test case 👌