Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly transfer indexing expression #1568

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Apr 12, 2022

Port of #1565 to master.

There were conflicts, so I didn't push directly but opted for a safer PR


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

turbolent and others added 2 commits April 11, 2022 17:12
@turbolent turbolent self-assigned this Apr 12, 2022
@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 07c27c2
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
RuntimeResourceDictionaryValues-216.3ms ± 6%16.8ms ± 4%~(p=0.165 n=7+7)
RuntimeFungibleTokenTransfer-21.55ms ±23%1.39ms ±36%~(p=0.620 n=7+7)
ParseFungibleToken-2224µs ± 6%227µs ± 2%~(p=0.620 n=7+7)
ParseDeploy/byte_array-222.6ms ± 6%23.3ms ± 3%~(p=0.209 n=7+7)
ParseDeploy/decode_hex-21.42ms ± 5%1.47ms ± 3%~(p=0.165 n=7+7)
ParseArray-214.6ms ± 9%14.6ms ± 6%~(p=0.805 n=7+7)
ParseInfix-29.78µs ± 9%9.94µs ± 3%~(p=0.318 n=7+7)
QualifiedIdentifierCreation/One_level-23.30ns ± 6%3.27ns ± 5%~(p=0.902 n=7+7)
QualifiedIdentifierCreation/Three_levels-2170ns ± 4%173ns ± 7%~(p=0.456 n=7+7)
CheckContractInterfaceFungibleTokenConformance-2169µs ± 7%173µs ± 4%~(p=0.318 n=7+7)
ContractInterfaceFungibleToken-246.7µs ± 8%48.3µs ± 3%~(p=0.053 n=7+7)
InterpretRecursionFib-23.13ms ± 9%3.25ms ± 2%~(p=0.101 n=7+6)
NewInterpreter/new_interpreter-21.36µs ± 3%1.33µs ± 5%~(p=0.295 n=6+7)
NewInterpreter/new_sub-interpreter-22.61µs ± 9%2.61µs ± 7%~(p=0.902 n=7+7)
 
alloc/opdelta
ContractInterfaceFungibleToken-226.6kB ± 0%26.7kB ± 0%+0.36%(p=0.001 n=6+7)
CheckContractInterfaceFungibleTokenConformance-266.2kB ± 0%66.3kB ± 0%+0.15%(p=0.001 n=7+7)
RuntimeFungibleTokenTransfer-2273kB ± 0%273kB ± 0%+0.03%(p=0.001 n=7+7)
RuntimeResourceDictionaryValues-24.05MB ± 0%4.05MB ± 0%+0.01%(p=0.017 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
InterpretRecursionFib-21.26MB ± 0%1.26MB ± 0%~(p=0.450 n=7+6)
NewInterpreter/new_interpreter-2848B ± 0%848B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.34kB ± 0%1.34kB ± 0%~(all equal)
 
allocs/opdelta
ContractInterfaceFungibleToken-2458 ± 0%460 ± 0%+0.44%(p=0.001 n=7+7)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%+0.19%(p=0.001 n=7+7)
RuntimeFungibleTokenTransfer-24.54k ± 0%4.54k ± 0%+0.05%(p=0.008 n=7+7)
RuntimeResourceDictionaryValues-2102k ± 0%102k ± 0%+0.00%(p=0.001 n=7+7)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
InterpretRecursionFib-226.2k ± 0%26.2k ± 0%~(all equal)
NewInterpreter/new_interpreter-213.0 ± 0%13.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-240.0 ± 0%40.0 ± 0%~(all equal)
 

@turbolent turbolent merged commit 27de1c2 into master Apr 19, 2022
@turbolent turbolent deleted the bastian/fix-indexing-expression-transfer-2 branch April 19, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants