Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov config #1553

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Add codecov config #1553

merged 1 commit into from
Apr 6, 2022

Conversation

turbolent
Copy link
Member

Description

  • Require increasing coverage for all code (auto target; up to 5% variance)
  • Require full coverage for new code

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent added the Chore label Apr 4, 2022
@turbolent turbolent self-assigned this Apr 4, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1553 (20f9304) into master (6075ef4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1553   +/-   ##
=======================================
  Coverage   74.72%   74.72%           
=======================================
  Files         289      289           
  Lines       55633    55633           
=======================================
  Hits        41569    41569           
  Misses      12563    12563           
  Partials     1501     1501           
Flag Coverage Δ
unittests 74.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6075ef4...20f9304. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 6075ef4
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
ParseInfix-210.1µs ± 2%10.3µs ± 3%+1.62%(p=0.038 n=6+7)
RuntimeFungibleTokenTransfer-21.72ms ± 5%1.48ms ±26%~(p=0.101 n=6+7)
RuntimeResourceDictionaryValues-217.0ms ± 3%16.9ms ± 2%~(p=0.383 n=7+7)
ParseFungibleToken-2225µs ± 3%229µs ± 2%~(p=0.165 n=7+7)
ParseArray-217.8ms ± 7%17.8ms ± 6%~(p=1.000 n=7+7)
ParseDeploy/byte_array-228.5ms ± 4%29.7ms ± 5%~(p=0.128 n=7+7)
ParseDeploy/decode_hex-21.43ms ± 1%1.43ms ± 1%~(p=0.902 n=7+7)
QualifiedIdentifierCreation/One_level-23.25ns ± 3%3.23ns ± 3%~(p=1.000 n=7+7)
QualifiedIdentifierCreation/Three_levels-2176ns ± 2%176ns ± 1%~(p=0.972 n=6+7)
ContractInterfaceFungibleToken-248.4µs ± 2%49.2µs ± 2%~(p=0.073 n=6+7)
CheckContractInterfaceFungibleTokenConformance-2163µs ± 3%165µs ± 1%~(p=0.097 n=7+7)
InterpretRecursionFib-23.30ms ± 2%3.30ms ± 3%~(p=0.805 n=7+7)
NewInterpreter/new_interpreter-21.40µs ± 2%1.40µs ± 1%~(p=1.000 n=7+6)
NewInterpreter/new_sub-interpreter-22.75µs ± 3%2.76µs ± 1%~(p=0.879 n=7+7)
 
alloc/opdelta
RuntimeFungibleTokenTransfer-2273kB ± 0%273kB ± 0%~(p=1.000 n=7+7)
RuntimeResourceDictionaryValues-24.05MB ± 0%4.05MB ± 0%~(p=0.456 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
ContractInterfaceFungibleToken-226.6kB ± 0%26.6kB ± 0%~(p=1.000 n=7+7)
CheckContractInterfaceFungibleTokenConformance-266.2kB ± 0%66.2kB ± 0%~(all equal)
InterpretRecursionFib-21.26MB ± 0%1.26MB ± 0%~(p=0.385 n=7+6)
NewInterpreter/new_interpreter-2848B ± 0%848B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.34kB ± 0%1.34kB ± 0%~(all equal)
 
allocs/opdelta
RuntimeFungibleTokenTransfer-24.54k ± 0%4.54k ± 0%~(p=0.318 n=5+7)
RuntimeResourceDictionaryValues-2102k ± 0%102k ± 0%~(p=0.869 n=7+7)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
ContractInterfaceFungibleToken-2458 ± 0%458 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
InterpretRecursionFib-226.2k ± 0%26.2k ± 0%~(all equal)
NewInterpreter/new_interpreter-213.0 ± 0%13.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-240.0 ± 0%40.0 ± 0%~(all equal)
 

@turbolent turbolent merged commit decfebe into master Apr 6, 2022
@turbolent turbolent deleted the bastian/improve-codecov branch April 6, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants