-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the crypto doc #1548
Update the crypto doc #1548
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1548 +/- ##
==========================================
- Coverage 74.69% 74.69% -0.01%
==========================================
Files 289 289
Lines 55625 55625
==========================================
- Hits 41549 41547 -2
- Misses 12581 12583 +2
Partials 1495 1495
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit c63336c Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some small suggestions to keep wording consistent across the API
@turbolent I think I've addressed your comments, but please let me know if more changes are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for improving this! 👍
Closes #1021
Description
April mainnet spork updates the Flow Virtual Machine (FVM) implementation and some cryptography features in it.
This PR updates the doc to match the new functionalities provided by Cadence and the FVM after the upcoming spork.
It also provides more details on how to generate signatures that Cadence/FVM consider valid.