-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flowkit version update #1534
Flowkit version update #1534
Conversation
Semgrep is failing, I'm assuming there is no snapshot file in the LS module? should that be initialized? |
Codecov Report
@@ Coverage Diff @@
## master #1534 +/- ##
=======================================
Coverage 74.64% 74.64%
=======================================
Files 288 288
Lines 55364 55364
=======================================
+ Hits 41327 41329 +2
+ Misses 12538 12536 -2
Partials 1499 1499
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 2aaae59 Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@sideninja While at it, maybe we can also bump to the latest Cadence release (https://github.com/onflow/cadence/releases/v0.23.2)? |
Yes ofc. |
@turbolent sorry for delay, had some things come in between. Here is the version bump as well as other dependency updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating this!
@sideninja To please CI, I think you have to merge master into this branch to get the semgrep config, and run |
Description
The flowkit version was updated and API changes were implemented.
master
branchFiles changed
in the Github PR explorer