Forbid reinitialization of variable, resource-kinded fields #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 668062c Results
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Comment on lines
+299
to
+305
| // If the field is constant, | ||
| // or it is variable and resource-kinded, | ||
| // and it has already previously been initialized, | ||
| // report an error for the repeated assignment / initialization | ||
| // | ||
| // Assigning to a variable, resource-kinded field is invalid, | ||
| // because the initial value would get lost. |
There was a problem hiding this comment.
It might be clearer to use more well-named variables than to have a large comment. You started this with targetIsConstant.
There was a problem hiding this comment.
What is your concrete suggestion? Do you have an example?
There was a problem hiding this comment.
On second thought, it wouldn't be good to run initializedFieldMembers.Contains(accessedSelfMember) if unnecessary. It could be put into a function but that's probably less clear overall.
Anyway, here's what I was thinking:
...
targetIsConstant := member.VariableKind == ast.VariableKindConstant
targetIsResource := member.TypeAnnotation.Type.IsResourceType()
targetIsInitialized := functionActivation.InitializationInfo.InitializedFieldMembers.Contains(accessedSelfMember)
...
// Report error for repeated assignment/initialization of constants or resource variables.
// Cannot assign to resource-kinded fields because the initial value would be lost.
if (targetIsConstant || targetIsResource) && targetIsInitialized {
...
robert-e-davidson3
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In addition to constant fields, also variable resource-kinded fields may not be re-initialized.
masterbranchFiles changedin the Github PR explorer