Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capability-based Access Control Document Improvements #1519

Conversation

kgebreki
Copy link

@kgebreki kgebreki commented Mar 20, 2022

Closes #1517

Description

This PR contains minor edits to the examples used in the Capability-based Access Control doc. A full description of the changes is found in the issue.


Completed the following

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent added the Documentation Improvements or additions to documentation label Mar 23, 2022
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your improvements!

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2022

Codecov Report

Merging #1519 (4509b85) into master (5238cce) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1519      +/-   ##
==========================================
+ Coverage   74.68%   74.70%   +0.01%     
==========================================
  Files         289      289              
  Lines       55607    55618      +11     
==========================================
+ Hits        41528    41547      +19     
+ Misses      12584    12579       -5     
+ Partials     1495     1492       -3     
Flag Coverage Δ
unittests 74.70% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/sema/simple_type.go 92.30% <0.00%> (-3.85%) ⬇️
runtime/sema/member_set.go 93.75% <0.00%> (-0.59%) ⬇️
runtime/sema/errors.go 57.29% <0.00%> (+0.08%) ⬆️
runtime/sema/type.go 88.66% <0.00%> (+0.08%) ⬆️
runtime/sema/checker.go 89.59% <0.00%> (+0.11%) ⬆️
runtime/sema/check_assignment.go 97.45% <0.00%> (+0.13%) ⬆️
runtime/sema/ordered_map_member_struct.go 49.29% <0.00%> (+7.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5238cce...4509b85. Read the comment docs.

@turbolent turbolent merged commit c63336c into onflow:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation improvement request: Capability-based Access Control document
4 participants