-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check capabilities of dependencies #1476
Conversation
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 4f14349 Results
|
github.com/onflow/cadence/runtime/pretty (runtime) | ||
github.com/opentracing/opentracing-go (network) | ||
github.com/stretchr/testify/assert (runtime, file, network) | ||
github.com/zeebo/blake3/internal/consts (file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we didn't have to allow file
to any hash libraries. In this case blake3/internal/consts appears to just call os.GetEnv() and call cpu.* functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, same for the other packages: The parser has a utility to read a file, and the runtime
usage in the interpreter is just to handle Go errors (Go's runtime.Error
).
Description
Add support for gocap. This was recommended by @fxamacker 🙏
master
branchFiles changed
in the Github PR explorer