Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not wrap conditional in ${{}} #1473

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Conversation

robert-e-davidson3
Copy link
Contributor

@robert-e-davidson3 robert-e-davidson3 commented Mar 3, 2022

Attempt to fix workflow failures like this one: https://github.com/onflow/cadence/actions/runs/1929973038

Description

There's a syntax error in the sync-flow-go.yml workflow file. Another condition in that file omits thee ${{ ... }} wrapper so I am trying that.

I don't know how to test these changes so I'm doing so live. I believe the scope of potential damage is limited to the current situation where the automatic PRs for syncing cadence and flow-go aren't created.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

Merging #1473 (20f0000) into master (4f14349) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1473   +/-   ##
=======================================
  Coverage   73.00%   73.01%           
=======================================
  Files         288      288           
  Lines       39786    39786           
=======================================
+ Hits        29047    29048    +1     
+ Misses       9264     9263    -1     
  Partials     1475     1475           
Flag Coverage Δ
unittests 73.01% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/sema/simple_type.go 96.42% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f14349...20f0000. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 3, 2022

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 4f14349
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
QualifiedIdentifierCreation/Three_levels-2137ns ± 0%140ns ± 4%+2.00%(p=0.005 n=7+7)
ParseArray-212.3ms ± 1%12.5ms ± 1%+1.22%(p=0.041 n=6+6)
RuntimeFungibleTokenTransfer-21.25ms ±28%1.09ms ±30%~(p=0.456 n=7+7)
RuntimeResourceDictionaryValues-213.7ms ± 3%13.8ms ± 3%~(p=0.620 n=7+7)
ParseInfix-28.52µs ± 6%8.36µs ± 2%~(p=0.945 n=7+6)
ParseFungibleToken-2181µs ± 0%182µs ± 1%~(p=0.177 n=5+6)
ParseDeploy/byte_array-220.4ms ±12%19.6ms ± 2%~(p=0.836 n=7+6)
ParseDeploy/decode_hex-21.16ms ± 1%1.17ms ± 4%~(p=0.620 n=7+7)
QualifiedIdentifierCreation/One_level-22.34ns ± 0%2.34ns ± 0%~(p=0.814 n=7+7)
CheckContractInterfaceFungibleTokenConformance-2130µs ± 1%131µs ± 2%~(p=0.295 n=6+7)
ContractInterfaceFungibleToken-239.9µs ± 7%39.0µs ± 2%~(p=0.628 n=7+6)
InterpretRecursionFib-22.83ms ± 1%2.84ms ± 2%~(p=0.836 n=6+7)
NewInterpreter/new_interpreter-21.11µs ± 1%1.11µs ± 1%~(p=0.864 n=7+6)
NewInterpreter/new_sub-interpreter-22.14µs ± 1%2.15µs ± 1%~(p=0.534 n=6+7)
 
alloc/opdelta
RuntimeFungibleTokenTransfer-2273kB ± 0%273kB ± 0%~(p=0.120 n=7+7)
RuntimeResourceDictionaryValues-24.05MB ± 0%4.05MB ± 0%~(p=0.805 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-266.2kB ± 0%66.2kB ± 0%~(all equal)
ContractInterfaceFungibleToken-226.6kB ± 0%26.6kB ± 0%~(p=1.000 n=7+7)
InterpretRecursionFib-21.26MB ± 0%1.26MB ± 0%~(p=0.538 n=6+7)
NewInterpreter/new_interpreter-2848B ± 0%848B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.32kB ± 0%1.32kB ± 0%~(all equal)
 
allocs/opdelta
RuntimeFungibleTokenTransfer-24.53k ± 0%4.53k ± 0%~(p=0.053 n=7+7)
RuntimeResourceDictionaryValues-2102k ± 0%102k ± 0%~(p=0.762 n=7+7)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
ContractInterfaceFungibleToken-2458 ± 0%458 ± 0%~(all equal)
InterpretRecursionFib-226.2k ± 0%26.2k ± 0%~(all equal)
NewInterpreter/new_interpreter-213.0 ± 0%13.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-239.0 ± 0%39.0 ± 0%~(all equal)
 

@robert-e-davidson3 robert-e-davidson3 merged commit 3ecb20d into master Mar 4, 2022
@SupunS SupunS deleted the robert/fix-sync-flow-go branch March 17, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants