-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not wrap conditional in ${{}} #1473
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1473 +/- ##
=======================================
Coverage 73.00% 73.01%
=======================================
Files 288 288
Lines 39786 39786
=======================================
+ Hits 29047 29048 +1
+ Misses 9264 9263 -1
Partials 1475 1475
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 4f14349 Results
|
Co-authored-by: Bastian Müller <[email protected]>
Attempt to fix workflow failures like this one: https://github.com/onflow/cadence/actions/runs/1929973038
Description
There's a syntax error in the
sync-flow-go.yml
workflow file. Another condition in that file omits thee${{ ... }}
wrapper so I am trying that.I don't know how to test these changes so I'm doing so live. I believe the scope of potential damage is limited to the current situation where the automatic PRs for syncing cadence and flow-go aren't created.
master
branchFiles changed
in the Github PR explorer