Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI typo feature-secure-cadence #1465

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Fix CI typo feature-secure-cadence #1465

merged 1 commit into from
Mar 1, 2022

Conversation

robert-e-davidson3
Copy link
Contributor

@robert-e-davidson3 robert-e-davidson3 commented Mar 1, 2022

Closes nothing this is a quick fix for merged code.

Description

I changed one of the feature-secure-cadence instances to feature/secure-cadence but not the others.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@turbolent turbolent merged commit 489adeb into master Mar 1, 2022
@turbolent turbolent deleted the robert/fix-ci-typo branch March 1, 2022 18:56
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 3787e12
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
RuntimeFungibleTokenTransfer-21.53ms ±25%1.47ms ±26%~(p=1.000 n=7+7)
RuntimeResourceDictionaryValues-218.2ms ± 4%18.4ms ± 3%~(p=0.383 n=7+7)
ParseArray-217.1ms ±16%16.5ms ± 6%~(p=0.902 n=7+7)
ParseInfix-211.0µs ± 9%10.7µs ± 3%~(p=0.710 n=7+7)
ParseFungibleToken-2247µs ± 2%257µs ± 7%~(p=0.073 n=7+7)
ParseDeploy/byte_array-225.1ms ± 4%25.3ms ± 3%~(p=0.628 n=6+7)
ParseDeploy/decode_hex-21.57ms ± 3%1.59ms ± 6%~(p=0.456 n=7+7)
QualifiedIdentifierCreation/One_level-23.57ns ± 3%3.58ns ± 2%~(p=1.000 n=7+7)
QualifiedIdentifierCreation/Three_levels-2193ns ± 5%193ns ± 4%~(p=0.874 n=7+7)
CheckContractInterfaceFungibleTokenConformance-2185µs ± 3%186µs ± 2%~(p=0.534 n=7+6)
ContractInterfaceFungibleToken-253.2µs ± 3%53.6µs ± 7%~(p=0.902 n=7+7)
NewInterpreter/new_interpreter-21.45µs ±12%1.38µs ± 1%~(p=0.073 n=7+6)
NewInterpreter/new_sub-interpreter-22.73µs ± 2%2.73µs ± 3%~(p=0.937 n=6+6)
InterpretRecursionFib-23.09ms ± 6%3.08ms ± 4%~(p=1.000 n=7+7)
 
alloc/opdelta
RuntimeFungibleTokenTransfer-2272kB ± 0%272kB ± 0%~(p=0.302 n=7+7)
RuntimeResourceDictionaryValues-24.05MB ± 0%4.05MB ± 0%~(p=0.209 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-266.2kB ± 0%66.2kB ± 0%~(all equal)
ContractInterfaceFungibleToken-226.6kB ± 0%26.6kB ± 0%~(p=1.000 n=7+7)
NewInterpreter/new_interpreter-2768B ± 0%768B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.24kB ± 0%1.24kB ± 0%~(all equal)
InterpretRecursionFib-21.24MB ± 0%1.24MB ± 0%~(p=0.538 n=6+7)
 
allocs/opdelta
RuntimeFungibleTokenTransfer-24.52k ± 0%4.52k ± 0%~(p=1.000 n=7+7)
RuntimeResourceDictionaryValues-2102k ± 0%102k ± 0%~(p=0.825 n=7+7)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
ContractInterfaceFungibleToken-2458 ± 0%458 ± 0%~(all equal)
NewInterpreter/new_interpreter-212.0 ± 0%12.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-238.0 ± 0%38.0 ± 0%~(all equal)
InterpretRecursionFib-225.0k ± 0%25.0k ± 0%~(all equal)
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants