Check transfer and use of transfered or destroyed resources at runtime

[turbolent]

Work towards dapperlabs/cadence-private-issues#19

Description

Add a defensive check for resources: When a resource is transferred (moved), create a new instance (Go struct), instead of reusing the existing one. Also, mark the transferred resource as invalidated, and detect uses after invalidation.

We already had an existing check for uses of referenced resources after their destruction.

Combined, this allows checking the use (transfer or access) of invalidated (transferred or destroyed) resources.

---

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work
• Code follows the standards mentioned here
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

[github-actions]

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit f3de22f
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

	old.txt	new.txt
	time/op		delta
RuntimeFungibleTokenTransfer-2	1.69ms ±26%	1.66ms ±20%	~	(p=0.902 n=7+7)
RuntimeResourceDictionaryValues-2	17.8ms ± 3%	18.2ms ± 6%	~	(p=0.366 n=6+7)
ParseDeploy/byte_array-2	26.1ms ± 6%	25.7ms ±11%	~	(p=0.383 n=7+7)
ParseDeploy/decode_hex-2	1.53ms ± 3%	1.51ms ± 3%	~	(p=0.366 n=7+6)
ParseArray-2	16.1ms ± 3%	16.4ms ± 4%	~	(p=0.138 n=6+7)
ParseInfix-2	10.4µs ± 3%	11.1µs ± 9%	~	(p=0.101 n=6+7)
ParseFungibleToken-2	245µs ±11%	247µs ± 3%	~	(p=0.366 n=7+6)
QualifiedIdentifierCreation/One_level-2	3.49ns ± 3%	3.48ns ± 5%	~	(p=0.535 n=7+7)
QualifiedIdentifierCreation/Three_levels-2	179ns ± 4%	179ns ± 4%	~	(p=1.000 n=7+7)
ContractInterfaceFungibleToken-2	50.7µs ± 1%	51.1µs ± 4%	~	(p=0.908 n=6+7)
NewInterpreter/new_interpreter-2	1.37µs ± 5%	1.39µs ± 3%	~	(p=0.165 n=7+7)
NewInterpreter/new_sub-interpreter-2	2.73µs ± 9%	2.67µs ± 5%	~	(p=0.620 n=7+7)
CheckContractInterfaceFungibleTokenConformance-2	186µs ± 5%	181µs ± 1%	−2.79%	(p=0.035 n=7+6)
InterpretRecursionFib-2	3.03ms ± 3%	2.93ms ± 2%	−3.20%	(p=0.035 n=7+6)
	alloc/op		delta
RuntimeFungibleTokenTransfer-2	271kB ± 0%	272kB ± 0%	+0.32%	(p=0.001 n=7+7)
RuntimeResourceDictionaryValues-2	4.05MB ± 0%	4.05MB ± 0%	~	(p=0.165 n=7+7)
QualifiedIdentifierCreation/One_level-2	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-2	64.0B ± 0%	64.0B ± 0%	~	(all equal)
CheckContractInterfaceFungibleTokenConformance-2	66.2kB ± 0%	66.2kB ± 0%	~	(all equal)
ContractInterfaceFungibleToken-2	26.6kB ± 0%	26.6kB ± 0%	~	(p=0.286 n=7+7)
NewInterpreter/new_interpreter-2	768B ± 0%	768B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-2	1.24kB ± 0%	1.24kB ± 0%	~	(all equal)
InterpretRecursionFib-2	1.24MB ± 0%	1.24MB ± 0%	~	(p=0.434 n=7+6)
	allocs/op		delta
RuntimeFungibleTokenTransfer-2	4.51k ± 0%	4.52k ± 0%	+0.30%	(p=0.001 n=7+7)
RuntimeResourceDictionaryValues-2	102k ± 0%	102k ± 0%	+0.00%	(p=0.001 n=7+7)
QualifiedIdentifierCreation/One_level-2	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-2	2.00 ± 0%	2.00 ± 0%	~	(all equal)
CheckContractInterfaceFungibleTokenConformance-2	1.07k ± 0%	1.07k ± 0%	~	(all equal)
ContractInterfaceFungibleToken-2	458 ± 0%	458 ± 0%	~	(all equal)
NewInterpreter/new_interpreter-2	12.0 ± 0%	12.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-2	38.0 ± 0%	38.0 ± 0%	~	(all equal)
InterpretRecursionFib-2	25.0k ± 0%	25.0k ± 0%	~	(all equal)

[SupunS]

🎉