Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bug report issue template #1440

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Conversation

turbolent
Copy link
Member

Description

  • Prevent crashers from being reported publicly, guide reporter to security issue responsible disclosure process
  • Request additional information (OS, version, etc.)
  • Add instructions for gathering additional information for language server problems

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Feb 23, 2022
@github-actions
Copy link

github-actions bot commented Feb 23, 2022

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit bbb0c74
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
RuntimeResourceDictionaryValues-213.5ms ± 1%13.7ms ± 2%+1.58%(p=0.002 n=7+7)
RuntimeFungibleTokenTransfer-21.25ms ±30%1.03ms ±29%~(p=0.165 n=7+7)
ParseDeploy/byte_array-218.8ms ± 1%19.0ms ± 1%~(p=0.073 n=7+6)
ParseDeploy/decode_hex-21.14ms ± 0%1.14ms ± 0%~(p=0.240 n=6+6)
ParseArray-212.1ms ± 1%12.2ms ± 2%~(p=0.589 n=6+6)
ParseInfix-28.49µs ± 1%8.47µs ± 1%~(p=0.517 n=6+6)
ParseFungibleToken-2188µs ± 7%183µs ± 1%~(p=0.945 n=7+6)
QualifiedIdentifierCreation/One_level-22.42ns ± 0%2.42ns ± 1%~(p=0.452 n=6+6)
QualifiedIdentifierCreation/Three_levels-2124ns ± 0%125ns ± 3%~(p=0.225 n=6+6)
ContractInterfaceFungibleToken-240.4µs ± 1%40.3µs ± 1%~(p=0.485 n=6+6)
CheckContractInterfaceFungibleTokenConformance-2129µs ± 1%129µs ± 1%~(p=0.534 n=7+6)
InterpretRecursionFib-22.55ms ± 3%2.54ms ± 0%~(p=0.836 n=7+6)
NewInterpreter/new_interpreter-21.05µs ± 0%1.05µs ± 1%~(p=0.136 n=6+6)
NewInterpreter/new_sub-interpreter-22.18µs ± 1%2.19µs ± 1%~(p=0.168 n=7+6)
 
alloc/opdelta
RuntimeFungibleTokenTransfer-2282kB ± 0%282kB ± 0%~(p=1.000 n=6+7)
RuntimeResourceDictionaryValues-24.05MB ± 0%4.05MB ± 0%~(p=0.535 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
ContractInterfaceFungibleToken-226.6kB ± 0%26.6kB ± 0%~(p=0.592 n=7+7)
CheckContractInterfaceFungibleTokenConformance-266.2kB ± 0%66.2kB ± 0%~(all equal)
InterpretRecursionFib-21.24MB ± 0%1.24MB ± 0%~(p=0.121 n=5+6)
NewInterpreter/new_interpreter-2768B ± 0%768B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.24kB ± 0%1.24kB ± 0%~(all equal)
 
allocs/opdelta
RuntimeFungibleTokenTransfer-24.54k ± 0%4.54k ± 0%~(p=0.234 n=7+7)
RuntimeResourceDictionaryValues-2102k ± 0%102k ± 0%~(p=1.000 n=7+7)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
ContractInterfaceFungibleToken-2458 ± 0%458 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
InterpretRecursionFib-225.0k ± 0%25.0k ± 0%~(all equal)
NewInterpreter/new_interpreter-212.0 ± 0%12.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-238.0 ± 0%38.0 ± 0%~(all equal)
 

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #1440 (86a35e5) into master (bbb0c74) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1440      +/-   ##
==========================================
- Coverage   73.13%   73.12%   -0.02%     
==========================================
  Files         283      283              
  Lines       39082    39082              
==========================================
- Hits        28582    28578       -4     
- Misses       9054     9056       +2     
- Partials     1446     1448       +2     
Flag Coverage Δ
unittests 73.12% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/sema/checker.go 89.10% <0.00%> (-0.16%) ⬇️
runtime/sema/type.go 88.28% <0.00%> (-0.13%) ⬇️
runtime/sema/simple_type.go 96.42% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbb0c74...86a35e5. Read the comment docs.

@turbolent turbolent merged commit c3df02d into master Feb 23, 2022
@turbolent turbolent deleted the bastian/improve-bug-template branch February 23, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants