Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments for StorageMap ReadValue and WriteValue #1439

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

turbolent
Copy link
Member

Description

The comments for the functions for StorageMap.ReadValue and WriteValue were outdated.
Update the comments to the new behaviour.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent added the Documentation Improvements or additions to documentation label Feb 22, 2022
@turbolent turbolent self-assigned this Feb 22, 2022
@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 71986de
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
RuntimeFungibleTokenTransfer-21.79ms ±29%1.62ms ±36%~(p=0.209 n=7+7)
RuntimeResourceDictionaryValues-219.4ms ± 3%19.4ms ± 6%~(p=0.902 n=7+7)
ParseDeploy/byte_array-228.9ms ±15%27.7ms ± 4%~(p=0.731 n=7+6)
ParseDeploy/decode_hex-21.68ms ± 5%1.67ms ± 3%~(p=0.535 n=7+7)
ParseArray-218.2ms ± 4%17.7ms ± 3%~(p=0.051 n=6+7)
ParseInfix-211.9µs ± 3%12.1µs ± 6%~(p=0.628 n=6+7)
ParseFungibleToken-2274µs ± 2%283µs ±10%~(p=0.456 n=7+7)
QualifiedIdentifierCreation/One_level-23.99ns ± 5%3.89ns ± 3%~(p=0.104 n=7+7)
QualifiedIdentifierCreation/Three_levels-2199ns ± 3%194ns ± 3%~(p=0.073 n=7+6)
ContractInterfaceFungibleToken-261.1µs ±13%58.5µs ± 3%~(p=0.181 n=7+6)
CheckContractInterfaceFungibleTokenConformance-2209µs ± 6%210µs ± 2%~(p=0.366 n=7+6)
NewInterpreter/new_interpreter-21.53µs ± 3%1.53µs ± 4%~(p=1.000 n=6+7)
NewInterpreter/new_sub-interpreter-22.97µs ± 2%2.99µs ± 4%~(p=1.000 n=6+6)
InterpretRecursionFib-23.30ms ± 2%3.30ms ± 2%~(p=0.818 n=6+6)
 
alloc/opdelta
RuntimeFungibleTokenTransfer-2282kB ± 0%282kB ± 0%~(p=0.643 n=7+7)
RuntimeResourceDictionaryValues-24.05MB ± 0%4.05MB ± 0%~(p=0.420 n=6+6)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
ContractInterfaceFungibleToken-226.6kB ± 0%26.6kB ± 0%~(p=0.385 n=7+6)
CheckContractInterfaceFungibleTokenConformance-266.2kB ± 0%66.2kB ± 0%~(all equal)
NewInterpreter/new_interpreter-2768B ± 0%768B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.24kB ± 0%1.24kB ± 0%~(all equal)
InterpretRecursionFib-21.24MB ± 0%1.24MB ± 0%~(p=0.714 n=7+7)
 
allocs/opdelta
RuntimeFungibleTokenTransfer-24.54k ± 0%4.54k ± 0%~(p=0.804 n=7+7)
RuntimeResourceDictionaryValues-2102k ± 0%102k ± 0%~(p=0.906 n=7+7)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
ContractInterfaceFungibleToken-2458 ± 0%458 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
NewInterpreter/new_interpreter-212.0 ± 0%12.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-238.0 ± 0%38.0 ± 0%~(all equal)
InterpretRecursionFib-225.0k ± 0%25.0k ± 0%~(all equal)
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants