Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Daniel as code owner #1436

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Add Daniel as code owner #1436

merged 1 commit into from
Feb 18, 2022

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Feb 18, 2022

Description

@dsainati1 has made many excellent contributions to Cadence and I hope there will be many more to come 🎉


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from SupunS as a code owner February 18, 2022 18:34
@turbolent turbolent self-assigned this Feb 18, 2022
@turbolent turbolent requested a review from j1010001 February 18, 2022 18:34
Copy link
Contributor

@dsainati1 dsainati1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looking forward to contributing more!

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Well deserved! 🎉

@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 0126f95
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
RuntimeFungibleTokenTransfer-21.06ms ±28%1.15ms ±24%~(p=0.805 n=7+7)
RuntimeResourceDictionaryValues-212.7ms ± 4%12.9ms ± 5%~(p=0.318 n=7+7)
ParseDeploy/byte_array-218.2ms ± 7%18.5ms ± 4%~(p=0.383 n=7+7)
ParseDeploy/decode_hex-21.08ms ± 5%1.09ms ± 5%~(p=1.000 n=7+7)
ParseFungibleToken-2172µs ± 9%166µs ± 3%~(p=0.209 n=7+7)
ParseArray-211.9ms ±11%12.0ms ± 8%~(p=0.902 n=7+7)
ParseInfix-27.74µs ± 5%7.69µs ± 3%~(p=0.310 n=6+6)
QualifiedIdentifierCreation/One_level-22.17ns ± 8%2.14ns ±10%~(p=0.684 n=7+7)
QualifiedIdentifierCreation/Three_levels-2127ns ± 8%126ns ± 3%~(p=0.620 n=7+7)
ContractInterfaceFungibleToken-235.5µs ± 4%35.5µs ± 4%~(p=0.836 n=6+7)
CheckContractInterfaceFungibleTokenConformance-2120µs ± 8%118µs ± 5%~(p=1.000 n=7+7)
InterpretRecursionFib-22.20ms ± 6%2.21ms ± 6%~(p=1.000 n=6+7)
NewInterpreter/new_interpreter-21.00µs ± 7%0.98µs ± 6%~(p=0.456 n=7+7)
NewInterpreter/new_sub-interpreter-21.94µs ± 8%1.92µs ± 4%~(p=0.929 n=7+7)
 
alloc/opdelta
RuntimeFungibleTokenTransfer-2282kB ± 0%282kB ± 0%~(p=0.067 n=7+7)
RuntimeResourceDictionaryValues-24.05MB ± 0%4.05MB ± 0%~(p=0.165 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
ContractInterfaceFungibleToken-226.6kB ± 0%26.6kB ± 0%~(p=1.000 n=7+7)
CheckContractInterfaceFungibleTokenConformance-266.2kB ± 0%66.2kB ± 0%~(p=0.245 n=7+6)
InterpretRecursionFib-21.24MB ± 0%1.24MB ± 0%~(p=0.192 n=7+7)
NewInterpreter/new_interpreter-2768B ± 0%768B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.24kB ± 0%1.24kB ± 0%~(all equal)
 
allocs/opdelta
RuntimeFungibleTokenTransfer-24.54k ± 0%4.54k ± 0%~(p=0.417 n=7+7)
RuntimeResourceDictionaryValues-2102k ± 0%102k ± 0%~(p=0.053 n=7+5)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
ContractInterfaceFungibleToken-2458 ± 0%458 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
InterpretRecursionFib-225.0k ± 0%25.0k ± 0%~(all equal)
NewInterpreter/new_interpreter-212.0 ± 0%12.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-238.0 ± 0%38.0 ± 0%~(all equal)
 

@turbolent turbolent merged commit 71986de into master Feb 18, 2022
@turbolent turbolent deleted the bastian/code-owners branch February 18, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants