Various regression tests #1425
Various regression tests #1425
Conversation
robert-e-davidson3
requested review from
turbolent and
SupunS
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1425 +/- ##
==========================================
+ Coverage 73.00% 73.14% +0.14%
==========================================
Files 288 282 -6
Lines 39786 39067 -719
==========================================
- Hits 29044 28575 -469
+ Misses 9266 9045 -221
+ Partials 1476 1447 -29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 242fcfa Results
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
runtime/various_test.go
Outdated
| "github.com/onflow/cadence/runtime/sema" | ||
| ) | ||
|
|
||
| func TestVariousAgainstRegression(t *testing.T) { |
There was a problem hiding this comment.
I think it might be better to move each test to the related component (parser/lexer, sema/checker, interpreter). This allows running the component's tests individually and detect regressions in one component earlier in the development. For example, if we were to break the parser, all parser tests could pass, and then only when we would run the runtime tests, we would realize there is a regression.
For example, the first test case is a parser test case, so it should go into runtime/parser2/parser_test.go.
The next five test cases are checker tests, so they should go into runtime/tests/checker.
For the test cases where no error is expected, the tests should be "duplicated" in both the checker tests and the interpreter tests, so we can ensure they are successfully checked, but then also successfully interpreted (other successful tests are "duplicated" in a similar way).
Sorry I was not clear about where to add the tests to begin with, I will document this.
There was a problem hiding this comment.
@turbolent I moved the tests around and restructured them to fit with the other tests in those files.
robert-e-davidson3
force-pushed
the
robert/various-regressions
branch
from
19a32a3 to
f67db5b
Compare
Co-authored-by: Bastian Müller <[email protected]>
Co-authored-by: Bastian Müller <[email protected]>
Co-authored-by: Bastian Müller <[email protected]>
Closes https://github.com/dapperlabs/cadence-private-issues/issues/29
Description
Adds regression tests for Cadence. These bugs were found by Joe Soroka's fuzz testing.
masterbranchFiles changedin the Github PR explorer