Fix definite field initialization analysis

[SupunS]

Closes #1405

Description

MaybeJumpedOrReturned (now MaybeReturned) was used only to determine whether a branch of the function has a 'return'. Marking it as true for jumps (break and continue statements) was going against the above assumption/usage.

Reverted the change of using that flag for both jumps and returns, and continue to use it for returns only.

---

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work
• Code follows the standards mentioned here
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

[codecov-commenter]

Codecov Report

Merging #1424 (8882bb8) into master (8129778) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1424      +/-   ##
==========================================
- Coverage   73.14%   73.12%   -0.02%     
==========================================
  Files         282      282              
  Lines       39067    39065       -2     
==========================================
- Hits        28574    28568       -6     
- Misses       9050     9052       +2     
- Partials     1443     1445       +2     

Flag	Coverage Δ
unittests	73.12% <100.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
runtime/sema/check_while.go	100.00% <ø> (ø)
runtime/sema/check_assignment.go	96.38% <100.00%> (ø)
runtime/sema/check_return_statement.go	100.00% <100.00%> (ø)
runtime/sema/checker.go	89.10% <100.00%> (-0.16%)	⬇️
runtime/sema/return_info.go	100.00% <100.00%> (ø)
runtime/sema/type.go	88.28% <0.00%> (-0.13%)	⬇️
runtime/sema/simple_type.go	96.42% <0.00%> (+3.57%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8129778...8882bb8. Read the comment docs.

[github-actions]

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 8129778
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

	old.txt	new.txt
	time/op		delta
RuntimeFungibleTokenTransfer-2	1.50ms ±21%	1.47ms ±23%	~	(p=0.805 n=7+7)
RuntimeResourceDictionaryValues-2	17.0ms ± 6%	17.0ms ± 6%	~	(p=0.902 n=7+7)
ParseArray-2	16.9ms ± 7%	17.8ms ±11%	~	(p=0.209 n=7+7)
ParseInfix-2	9.93µs ± 4%	10.17µs ± 5%	~	(p=0.165 n=7+7)
ParseDeploy/byte_array-2	27.3ms ± 7%	28.8ms ±12%	~	(p=0.165 n=7+7)
ParseDeploy/decode_hex-2	1.42ms ± 2%	1.43ms ± 6%	~	(p=0.628 n=6+7)
ParseFungibleToken-2	220µs ± 5%	225µs ± 6%	~	(p=0.234 n=6+7)
QualifiedIdentifierCreation/Three_levels-2	167ns ± 4%	173ns ± 9%	~	(p=0.128 n=7+7)
ContractInterfaceFungibleToken-2	48.0µs ± 4%	47.5µs ± 4%	~	(p=0.731 n=7+6)
CheckContractInterfaceFungibleTokenConformance-2	160µs ± 9%	161µs ± 3%	~	(p=0.383 n=7+7)
NewInterpreter/new_interpreter-2	1.30µs ± 2%	1.30µs ± 3%	~	(p=0.596 n=7+7)
NewInterpreter/new_sub-interpreter-2	2.59µs ± 9%	2.58µs ± 6%	~	(p=0.805 n=7+7)
InterpretRecursionFib-2	2.80ms ± 7%	2.82ms ± 6%	~	(p=1.000 n=7+7)
QualifiedIdentifierCreation/One_level-2	3.19ns ± 5%	2.78ns ± 4%	−13.02%	(p=0.001 n=7+7)
	alloc/op		delta
RuntimeFungibleTokenTransfer-2	289kB ± 0%	289kB ± 0%	~	(p=0.913 n=7+6)
RuntimeResourceDictionaryValues-2	4.06MB ± 0%	4.06MB ± 0%	~	(p=0.535 n=7+7)
QualifiedIdentifierCreation/One_level-2	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-2	64.0B ± 0%	64.0B ± 0%	~	(all equal)
ContractInterfaceFungibleToken-2	26.6kB ± 0%	26.6kB ± 0%	~	(p=0.192 n=7+7)
CheckContractInterfaceFungibleTokenConformance-2	66.2kB ± 0%	66.2kB ± 0%	~	(all equal)
NewInterpreter/new_interpreter-2	768B ± 0%	768B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-2	1.24kB ± 0%	1.24kB ± 0%	~	(all equal)
InterpretRecursionFib-2	1.24MB ± 0%	1.24MB ± 0%	~	(p=0.400 n=7+6)
	allocs/op		delta
RuntimeFungibleTokenTransfer-2	4.65k ± 0%	4.65k ± 0%	~	(p=1.000 n=7+7)
RuntimeResourceDictionaryValues-2	102k ± 0%	102k ± 0%	~	(p=0.604 n=7+7)
QualifiedIdentifierCreation/One_level-2	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-2	2.00 ± 0%	2.00 ± 0%	~	(all equal)
ContractInterfaceFungibleToken-2	458 ± 0%	458 ± 0%	~	(all equal)
CheckContractInterfaceFungibleTokenConformance-2	1.07k ± 0%	1.07k ± 0%	~	(all equal)
NewInterpreter/new_interpreter-2	12.0 ± 0%	12.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-2	38.0 ± 0%	38.0 ± 0%	~	(all equal)
InterpretRecursionFib-2	25.0k ± 0%	25.0k ± 0%	~	(all equal)

[turbolent]

Nice work! 👏 Glad it was an easy fix, I couldn't quite see it 🙂