Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for linking to already linked paths #1416

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Feb 12, 2022

Work towards #1257

Description

This PR add some tests to verify the current behavior of creating links to already linked paths.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2022

Codecov Report

Merging #1416 (b96c430) into master (1939cc7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1416   +/-   ##
=======================================
  Coverage   73.08%   73.08%           
=======================================
  Files         280      280           
  Lines       38952    38952           
=======================================
  Hits        28469    28469           
  Misses       9039     9039           
  Partials     1444     1444           
Flag Coverage Δ
unittests 73.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1939cc7...b96c430. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 12, 2022

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 95e70f9
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
RuntimeResourceDictionaryValues-214.0ms ± 2%14.0ms ± 2%~(p=0.620 n=7+7)
RuntimeFungibleTokenTransfer-21.17ms ±28%1.13ms ±35%~(p=0.620 n=7+7)
ParseArray-212.9ms ± 9%12.4ms ± 1%~(p=0.209 n=7+7)
ParseDeploy/byte_array-220.4ms ± 9%19.7ms ± 1%~(p=0.073 n=7+7)
ParseDeploy/decode_hex-21.15ms ± 1%1.17ms ± 3%~(p=0.097 n=7+7)
ParseFungibleToken-2182µs ± 1%182µs ± 1%~(p=0.731 n=6+7)
ParseInfix-29.65µs ± 1%9.94µs ±11%~(p=0.620 n=7+7)
QualifiedIdentifierCreation/One_level-22.34ns ± 0%2.34ns ± 0%~(p=0.679 n=7+6)
QualifiedIdentifierCreation/Three_levels-2140ns ± 0%140ns ± 1%~(p=0.362 n=7+6)
CheckContractInterfaceFungibleTokenConformance-2135µs ± 5%130µs ± 1%~(p=0.073 n=7+6)
ContractInterfaceFungibleToken-239.3µs ± 2%39.3µs ± 1%~(p=1.000 n=7+7)
NewInterpreter/new_interpreter-21.05µs ± 1%1.05µs ± 0%~(p=1.000 n=7+6)
NewInterpreter/new_sub-interpreter-22.09µs ± 1%2.09µs ± 1%~(p=0.818 n=6+6)
InterpretRecursionFib-22.40ms ± 4%2.37ms ± 2%~(p=0.836 n=7+6)
 
alloc/opdelta
RuntimeResourceDictionaryValues-24.05MB ± 0%4.05MB ± 0%~(p=0.259 n=7+7)
RuntimeFungibleTokenTransfer-2278kB ± 0%278kB ± 0%~(p=0.259 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-266.2kB ± 0%66.2kB ± 0%~(all equal)
ContractInterfaceFungibleToken-226.6kB ± 0%26.6kB ± 0%~(all equal)
NewInterpreter/new_interpreter-2768B ± 0%768B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.24kB ± 0%1.24kB ± 0%~(all equal)
InterpretRecursionFib-21.24MB ± 0%1.24MB ± 0%~(p=0.450 n=7+7)
 
allocs/opdelta
RuntimeResourceDictionaryValues-2102k ± 0%102k ± 0%~(p=0.185 n=7+7)
RuntimeFungibleTokenTransfer-24.62k ± 0%4.62k ± 0%~(p=0.298 n=7+7)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
ContractInterfaceFungibleToken-2458 ± 0%458 ± 0%~(all equal)
NewInterpreter/new_interpreter-212.0 ± 0%12.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-238.0 ± 0%38.0 ± 0%~(all equal)
InterpretRecursionFib-225.0k ± 0%25.0k ± 0%~(all equal)
 

@SupunS SupunS marked this pull request as ready for review February 15, 2022 17:29
@SupunS SupunS requested a review from turbolent as a code owner February 15, 2022 17:29
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants