Allows adding new interface conformances during a contract update #1395
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1395 +/- ##
==========================================
+ Coverage 75.81% 75.84% +0.02%
==========================================
Files 279 279
Lines 38780 38774 -6
==========================================
+ Hits 29402 29407 +5
+ Misses 8016 8007 -9
+ Partials 1362 1360 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SupunS
force-pushed
the
supun/conformance-restrictions
branch
from
494d614 to
41d78ec
Compare
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit d3124c5 Results
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| for _, oldConformance := range oldConformances { | ||
| found := false | ||
| for _, newConformance := range newConformances { |
There was a problem hiding this comment.
Maybe we can optimize the quadratic search here to avoid blow-up (in a follow-up PR). I guess because the outer loop break on first missing, it is actually OK?
There was a problem hiding this comment.
Optimized it here: 3c22c34
|
|
||
| err := deployAndUpdate(t, "Test1", oldCode, newCode) | ||
| require.NoError(t, err) | ||
| }) | ||
| } | ||
|
|
||
| func TestConformanceChanges(t *testing.T) { |
There was a problem hiding this comment.
Good idea to add full runtime tests 👍
| // Remove the matched conformance, so we don't have to check it again. | ||
| // i.e: optimization | ||
| newConformances = append(newConformances[:index], newConformances[index+1:]...) |
There was a problem hiding this comment.
Great idea! Double checked with https://go.dev/play/p/N233f-oGIDh, as I was not quite sure how modifying newConformances here affects the range over it / the inner loop
There was a problem hiding this comment.
It always breaks from the inner-loop after modification, so should be safe. Thanks for double-checking!
Work towards #1394
Description
This PR allows adding interface conformances during a contract update.
Removing existing conformances are continue to be not allowed.
masterbranchFiles changedin the Github PR explorer