-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CharacterValue type #1392
Add CharacterValue type #1392
Conversation
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit d3124c5 Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, great work!
Co-authored-by: Bastian Müller <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1392 +/- ##
==========================================
- Coverage 75.81% 73.05% -2.77%
==========================================
Files 279 280 +1
Lines 38780 38900 +120
==========================================
- Hits 29402 28419 -983
- Misses 8016 9038 +1022
- Partials 1362 1443 +81
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just a couple minor things and then ready to get merged 👍
Closes #1373
Description
Cadence previously lacked a runtime character value, causing some inconsistency between the static
Character
type and values with that type at runtime. This adds runtimeCharacter
values, which are produced by indexing into a string and by creating a character variable like so:let x: Character = "a"
.master
branchFiles changed
in the Github PR explorer