Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uniseg to latest commit #1370

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Update uniseg to latest commit #1370

merged 1 commit into from
Jan 29, 2022

Conversation

turbolent
Copy link
Member

Description

Includes rivo/uniseg#16


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

Merging #1370 (e2384c9) into master (c7fd8cb) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1370      +/-   ##
==========================================
- Coverage   75.84%   75.83%   -0.02%     
==========================================
  Files         279      279              
  Lines       38770    38770              
==========================================
- Hits        29405    29401       -4     
- Misses       8007     8009       +2     
- Partials     1358     1360       +2     
Flag Coverage Δ
unittests 75.83% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/sema/checker.go 89.11% <0.00%> (-0.16%) ⬇️
runtime/sema/type.go 88.45% <0.00%> (-0.13%) ⬇️
runtime/sema/simple_type.go 96.42% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7fd8cb...e2384c9. Read the comment docs.

@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit c7fd8cb
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Results

old.txtnew.txt
time/opdelta
RuntimeResourceDictionaryValues-217.8ms ± 3%17.3ms ± 4%~(p=0.051 n=6+7)
RuntimeFungibleTokenTransfer-21.44ms ±23%1.50ms ±22%~(p=0.710 n=7+7)
ParseInfix-211.9µs ± 4%11.6µs ± 2%~(p=0.101 n=7+6)
ParseDeploy/byte_array-232.4ms ± 7%30.9ms ± 8%~(p=0.128 n=7+7)
ParseDeploy/decode_hex-21.46ms ± 5%1.44ms ± 3%~(p=0.383 n=7+7)
QualifiedIdentifierCreation/One_level-22.87ns ± 2%2.86ns ± 1%~(p=0.510 n=7+7)
QualifiedIdentifierCreation/Three_levels-2173ns ± 2%175ns ± 3%~(p=0.246 n=6+7)
CheckContractInterfaceFungibleTokenConformance-2165µs ± 4%165µs ± 4%~(p=0.902 n=7+7)
ContractInterfaceFungibleToken-250.5µs ± 4%49.8µs ± 4%~(p=0.445 n=6+7)
InterpretRecursionFib-22.94ms ± 8%2.84ms ± 5%~(p=0.165 n=7+7)
NewInterpreter/new_interpreter-21.33µs ± 4%1.34µs ± 7%~(p=0.932 n=7+7)
NewInterpreter/new_sub-interpreter-22.69µs ± 7%2.60µs ± 1%~(p=0.234 n=7+6)
ParseFungibleToken-2227µs ± 2%222µs ± 1%−2.05%(p=0.015 n=6+6)
ParseArray-219.2ms ± 3%18.6ms ± 1%−3.04%(p=0.004 n=5+6)
 
alloc/opdelta
RuntimeResourceDictionaryValues-24.05MB ± 0%4.05MB ± 0%~(p=0.165 n=7+7)
RuntimeFungibleTokenTransfer-2277kB ± 0%277kB ± 0%~(p=0.927 n=7+7)
QualifiedIdentifierCreation/One_level-20.00B 0.00B ~(all equal)
QualifiedIdentifierCreation/Three_levels-264.0B ± 0%64.0B ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-265.7kB ± 0%65.7kB ± 0%~(all equal)
ContractInterfaceFungibleToken-226.5kB ± 0%26.5kB ± 0%~(p=1.000 n=7+7)
InterpretRecursionFib-21.24MB ± 0%1.24MB ± 0%~(p=1.000 n=7+7)
NewInterpreter/new_interpreter-2768B ± 0%768B ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-21.24kB ± 0%1.24kB ± 0%~(all equal)
 
allocs/opdelta
RuntimeResourceDictionaryValues-2102k ± 0%102k ± 0%~(p=0.099 n=7+7)
RuntimeFungibleTokenTransfer-24.61k ± 0%4.61k ± 0%~(p=0.478 n=7+7)
QualifiedIdentifierCreation/One_level-20.00 0.00 ~(all equal)
QualifiedIdentifierCreation/Three_levels-22.00 ± 0%2.00 ± 0%~(all equal)
CheckContractInterfaceFungibleTokenConformance-21.07k ± 0%1.07k ± 0%~(all equal)
ContractInterfaceFungibleToken-2457 ± 0%457 ± 0%~(all equal)
InterpretRecursionFib-225.0k ± 0%25.0k ± 0%~(all equal)
NewInterpreter/new_interpreter-212.0 ± 0%12.0 ± 0%~(all equal)
NewInterpreter/new_sub-interpreter-238.0 ± 0%38.0 ± 0%~(all equal)
 

@turbolent turbolent merged commit 6a99054 into master Jan 29, 2022
@turbolent turbolent deleted the bastian/update-uniseg branch March 1, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants