Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object player/1358 fix broken links in cadence document #1368

Conversation

ObjectPlayer
Copy link
Contributor

Closes #1358

Description

Resolved all broken links in the cadence documents.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Jan 18, 2022
@turbolent turbolent added the Documentation Improvements or additions to documentation label Jan 18, 2022
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestions!

add AST exploration tool link

Co-authored-by: Bastian Müller <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022

Codecov Report

Merging #1368 (b45bc94) into master (4b954f5) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1368      +/-   ##
==========================================
- Coverage   75.84%   75.82%   -0.02%     
==========================================
  Files         279      279              
  Lines       38770    38770              
==========================================
- Hits        29405    29399       -6     
- Misses       8007     8011       +4     
- Partials     1358     1360       +2     
Flag Coverage Δ
unittests 75.82% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/interpreter/storage.go 71.42% <0.00%> (-1.69%) ⬇️
runtime/sema/checker.go 89.11% <0.00%> (-0.16%) ⬇️
runtime/sema/type.go 88.45% <0.00%> (-0.13%) ⬇️
runtime/sema/simple_type.go 96.42% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b954f5...b45bc94. Read the comment docs.

@kerrywei
Copy link
Contributor

Thank you for helping us to clean up the docs issue @ObjectPlayer . The relative linking issue has just been addressed, we I have some change to fix all bad links in Cadence at https://github.com/onflow/cadence/pull/1372/files , using relative paths

@turbolent turbolent merged commit 845c923 into onflow:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken links in Cadence documentation
4 participants